[test-results] [Bamboo] Asterisk Testing > Asterisk 1.8 Branch > #21 was SUCCESSFUL (with 325 tests). Change made by Mark Michelson.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk 1.8 Branch > #21 was successful.
-----------------------------------------------------------------------
Code has been updated by Mark Michelson.
All 2 jobs passed with 325 tests in total.

http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-21/


--------------
Code Changes
--------------
Mark Michelson (357761):

>Fix race condition that can cause important control frames (such as a hangup) to be missed.
>
>This takes two actions.
>
>1. Move the reading of the alertpipe in __ast_read() to immediately before the
>removal of frames from the readq. This means we won't do something silly like
>read from the alertpipe, then ignore the fact that there's a frame to get from
>the readq since channel's fdno is the AST_TIMING_FD.
>
>2. When ast_settimeout() sets the rate to 0 and the timingfunc to NULL, if the
>channel's fdno is the AST_TIMING_FD, then set the fdno to -1. This is because
>if the rate is 0 and the timingfunc is NULL, it means that the channel's timing
>fd is being invalidated, so any pending reads should not occur.
>
>This may actually solve more issues than the referenced one below, but it's not
>known at this time for sure.
>
>(closes issue ASTERISK-19223)
>reported by Frank-Michael Wittig
>
>Review: https://reviewboard.asterisk.org/r/1779
>
>


--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120302/30840c8f/attachment-0001.htm>