[test-results] [Bamboo] Asterisk Testing > Certified Asterisk 1.8.11 Branch > #25 was SUCCESSFUL (with 182 tests). Change made by Terry Wilson.
Bamboo
bamboo at asterisk.org
Tue Jul 24 23:14:40 CDT 2012
-----------------------------------------------------------------------
Asterisk Testing > Certified Asterisk 1.8.11 Branch > #25 was successful.
-----------------------------------------------------------------------
Code has been updated by Terry Wilson.
182 tests in total.
http://bamboo.asterisk.org/browse/TESTING-ASTERISKCERTIFIED1811-25/
--------------
Code Changes
--------------
Terry Wilson (370472):
>Revert a change that broke compilation
>
>1) There is no such function as ast_ref()
>2) The patch was originally credited as the one uploaded by Guenther
> Kelleter (license 6372) via issue AST-921, but the patch committed
> was not the patch referenced on the issue.
>3) Guenther Kelleter's patch was actually correct. It moved the
> ast_free above the presencechange_cleanup label. I am not
> committing his change as it is not technically necesary--calling
> ast_free(NULL) is perfectly safe and I worry that moving the
> ast_free outside of the label could lead to future bugs if
> someone ever adds another failure conditional and expects
> 'goto presencechange_cleanup;' to clean up after everything.
>
--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120724/2d0367c0/attachment-0001.htm>
More information about the Test-results
mailing list