[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #507 has FAILED (1 tests failed, no failures were new). Change made by Terry Wilson.

Bamboo bamboo at asterisk.org
Sat Jul 21 20:04:02 CDT 2012


-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #507 failed.
-----------------------------------------------------------------------
Code has been updated by Terry Wilson.
1/270 tests failed, no failures were new.

http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-507/


--------------
Failing Jobs
--------------
  - Asterisk CentOS 6 64-Bit (CentOS 6): 1 of 270 tests failed.



--------------
Code Changes
--------------
Terry Wilson (370341):

>Fix segfault introduced by conversion to ACO API
>
>The value "none" is specified in the config file as a valid value for
>the "video_mode" option. The code prior to the ACO conversion did not
>check for "none", but just ignored it and relied on the default zero
>value. The parsing with ACO is more strict, so without handling
>"none" specifically, parsing would fail.
>
>When parsing failed, but the module loaded anyway, the config info
>would never be stored, and one place in the code did not check for
>this case and would segfault. It was also possible that the
>aco_info struct's internals would be destroyed and used as well.
>
>This patch keeps the module from loading after parse failures, adds
>the "none" option to "video_mode", registers CLI functions only
>after parsing has completed, checks the config data for NULL before
>accessing it, and returns -1 on some allocation failures when
>initializing.
>
>
>(closes issue ASTERISK-20159)
>Reported by: Birger "WIMPy" Harzenetter
>Tested by: Birger "WIMPy" Harzenetter
>Patches:
>    confbridge_fix3.txt uploaded by Terry Wilson
>



--------------
Tests
--------------
Existing Test Failures (1)
   - AsteriskTestSuite: S/channels/ s i p/generic ccss

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120721/7529aebc/attachment-0001.htm>


More information about the Test-results mailing list