[test-results] [Bamboo] Asterisk Testing > Asterisk 1.8 Branch > #110 has FAILED (1 tests failed, no failures were new). Change made by Matthew Jordan.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk 1.8 Branch > #110 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
1/176 tests failed, no failures were new.

http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-110/


--------------
Failing Jobs
--------------
  - Asterisk 1.8 CentOS 6 64-Bit (CentOS 6): 1 of 176 tests failed.


--------------
Code Changes
--------------
Matthew Jordan (362204):

>Fix negative return handling in channel drivers
>
>In chan_agent, while handling a channel indicate, the agent channel driver
>must obtain a lock on both the agent channel, as well as the channel the
>agent channel is using.  To do so, it attempts to lock the other channel
>first, then unlock the agent channel which is locked prior to entry into
>the indicate handler.  If this unlock fails with a negative return value,
>which can occur if the object passed to agent_indicate is an invalid ao2
>object or is NULL, the return value is passed directly to strerror, which
>can only accept positive integer values.
>
>In chan_dahdi, the return value of dahdi_get_index is used to directly
>index into the sub-channel array.  If dahd_get_index returns a negative
>value, it would use that value to index into the array, which could cause
>an invalid memory access.  If dahdi_get_index returns a negative number,
>we now default to SUB_REAL.
>
>(issue ASTERISK-19655)
>Reported by: Matt Jordan
>
>Review: https://reviewboard.asterisk.org/r/1863/


--------------
Tests
--------------
Existing Test Failures (1)
   - AsteriskTestSuite: S/fastagi/stream-file

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120417/5fecade8/attachment-0001.htm>