[test-results] [Bamboo] Asterisk - Trunk > Ubuntu Lucid (10.04) > #1154 has FAILED. Change made by Terry Wilson.

[Bamboo]

-----------------------------------------------------------------------
Asterisk - Trunk > Ubuntu Lucid (10.04) > #1154 failed.
-----------------------------------------------------------------------
Code has been updated by Terry Wilson.
No failed tests found, a possible compilation error.

http://bamboo.asterisk.org/browse/ASTTRUNK-LUCID-1154/


--------------
Failing Jobs
--------------
  - amd64 (Default Stage): No tests found.


--------------
Code Changes
--------------
Terry Wilson (342385):

>Simplify queue membercount code
>
>Despite an ominous sounding comment stating that membercount was for "logged
>in" members only and thus we couldn't use ao2_container_count(), I could not
>find a single place in the code where that seemed to be accurate. The only time
>we decremented membercount was when we were marking something dead or actually
>removing it. The only places we incremented it were either after ao2_link(), or
>trying to correct for having set it to 0 during a reload. In every case where
>we were correcting the value, it seemed that we were trying to make the count
>actually match what ao2_container_count() would return. The only place I could
>find where we made a determination about something being "logged in" or not, we
>didn't trust the membercount, but instead looked at devicestate, paused, etc.
>
>This patch removes membercount, replaces its use with ao2_container_count, and
>manually adds the results of ao2_container_count to a "membercount" field for
>ast_data queue query results. This patch also would fix AST-676, but as it is
>slightly riskier than the previously committed fix, the two commits have been
>made separately.
>
>Reivew: https://reviewboard.asterisk.org/r/1541/
>........
>
>Merged revisions 342383 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>........
>
>Merged revisions 342384 from http://svn.asterisk.org/svn/asterisk/branches/10
>


--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20111025/37ae0b36/attachment-0001.htm>