[test-results] [Bamboo] Asterisk - Trunk > Ubuntu Lucid (10.04) > #536 has FAILED (1 tests failed, no failures were new). Change made by alecdavis.

[Bamboo]

-----------------------------------------------------------------------
Asterisk - Trunk > Ubuntu Lucid (10.04) > #536 failed.
-----------------------------------------------------------------------
Code has been updated by alecdavis.
1/2 jobs failed with 1 failing test, no failures were new.

http://bamboo.asterisk.org/browse/ASTTRUNK-LUCID-536/


--------------
Failing Jobs
--------------
  - amd64 (Default Stage): 1 of 105 tests failed.


--------------
Code Changes
--------------
alecdavis (318672):

>Merged revisions 318671 via svnmerge from 
>https://origsvn.digium.com/svn/asterisk/branches/1.8
>
>........
>  r318671 | alecdavis | 2011-05-13 10:52:08 +1200 (Fri, 13 May 2011) | 30 lines
>  
>  Fix directed group pickup feature code *8 with pickupsounds enabled 
>  
>  Since 1.6.2, the new pickupsound and pickupfailsound in features.conf cause many issues.
>  
>  1). chan_sip:handle_request_invite() shouldn't be playing out the fail/success audio, as it has 'netlock' locked.
>  2). dialplan applications for directed_pickups shouldn't beep.
>  3). feature code for directed pickup should beep on success/failure if configured.
>  
>  Created a sip_pickup() thread to handle the pickup and playout the audio, spawned from handle_request_invite.
>  
>  Moved app_directed:pickup_do() to features:ast_do_pickup().
>  
>  Functions below, all now use the new ast_do_pickup()
>  app_directed_pickup.c:
>     pickup_by_channel()
>     pickup_by_exten()
>     pickup_by_mark()
>     pickup_by_part()
>  features.c:
>     ast_pickup_call()
>  
>  (closes issue #18654)
>  Reported by: Docent
>  Patches: 
>        ast_do_pickup_1.8_trunk.diff.txt uploaded by alecdavis (license 585)
>  Tested by: lmadsen, francesco_r, amilcar, isis242, alecdavis, irroot, rymkus, loloski, rmudgett
>  
>  Review: https://reviewboard.asterisk.org/r/1185/
>........
>


--------------
Tests
--------------
Existing Test Failures (1)
   - AsteriskTestSuite: S/udptl v6

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20110512/55a3de80/attachment-0001.htm>