[test-results] [Bamboo] Asterisk - 1.8 > Ubuntu Lucid (10.04) > #496 has FAILED. Change made by seanbright.

[Bamboo]

-----------------------------------------------------------------------
Asterisk - 1.8 > Ubuntu Lucid (10.04) > #496 failed.
-----------------------------------------------------------------------
Code has been updated by seanbright.
1/2 jobs failed, with 0 failing tests.

http://bamboo.asterisk.org/browse/AST18-LUCID-496/


--------------
Failing Jobs
--------------
  - i386 (Default Stage): No tests found.


--------------
Code Changes
--------------
seanbright (323608):

>Merged revisions 323579 via svnmerge from 
>https://origsvn.digium.com/svn/asterisk/branches/1.6.2
>
>................
>  r323579 | seanbright | 2011-06-15 11:22:50 -0400 (Wed, 15 Jun 2011) | 32 lines
>  
>  Merged revisions 323559 via svnmerge from 
>  https://origsvn.digium.com/svn/asterisk/branches/1.4
>  
>  ........
>    r323559 | seanbright | 2011-06-15 11:15:30 -0400 (Wed, 15 Jun 2011) | 25 lines
>    
>    Resolve a segfault/bus error when we try to map memory that falls on a page
>    boundary.
>    
>    The fix for ASTERISK-15359 was incorrect in that it added 1 to the length of the
>    mmap'd region.  The problem with this is that reading/writing to that extra byte
>    outside of the bounds of the underlying fd causes a bus error.
>    
>    The real issue is that we are working with both a FILE * and the raw fd
>    underneath it and not synchronizing between them.  The code that was removed in
>    ASTERISK-15359 was correct, but we weren't flushing the FILE * before mapping
>    the fd.
>    
>    Looking at the manager code in 1.4 reveals that the FILE * in 'struct
>    mansession' is never used except to create a temporary file that we immediately
>    fdopen.  This means we just need to write a 0 byte to the fd and everything will
>    just work.  The other branches require a call to fflush() which, while not a
>    guaranteed fix, should reduce the likelihood of a crash.
>    
>    This all makes sense in my head.
>    
>    (closes issue ASTERISK-16460)
>    Reported by: Ravelomanantsoa Hoby (hoby)
>    Patches:
>    		issue17747_1.4_svn_markII.patch uploaded by Sean Bright (license #5060)
>  ........
>................
>


--------------
Tests
--------------
Fixed Tests (1)
   - AsteriskTestSuite: S/manager/action-events-response

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20110615/97a25735/attachment.htm>