[test-results] [Bamboo] Asterisk - 1.8 > Ubuntu Lucid (10.04) > #705 has FAILED (2 tests failed). Change made by rmudgett.

[Bamboo]

-----------------------------------------------------------------------
Asterisk - 1.8 > Ubuntu Lucid (10.04) > #705 failed.
-----------------------------------------------------------------------
Code has been updated by rmudgett.
2/118 tests failed.

http://bamboo.asterisk.org/browse/AST18-LUCID-705/


--------------
Failing Jobs
--------------
  - amd64 (Default Stage): 2 of 118 tests failed.


--------------
Code Changes
--------------
rmudgett (334009):

>Call pickup race leaves orphaned channels or crashes.
>
>Multiple users attempting to pickup a call that has been forked to
>multiple extensions either crashes or fails a masquerade with a "bad
>things may happen" message.
>
>This is the scenario that is causing all the grief:
>1) Pickup target is selected
>2) target is marked as being picked up in ast_do_pickup()
>3) target is unlocked by ast_do_pickup()
>4) app dial or queue gets a chance to hang up losing calls and calls
>ast_hangup() on target
>5) SINCE A MASQUERADE HAS NOT BEEN SETUP YET BY ast_do_pickup() with
>ast_channel_masquerade(), ast_hangup() completes successfully and the
>channel is no longer in the channels container.
>6) ast_do_pickup() then calls ast_channel_masquerade() to schedule the
>masquerade on the dead channel.
>7) ast_do_pickup() then calls ast_do_masquerade() on the dead channel
>8) bad things happen while doing the masquerade and in the process
>ast_do_masquerade() puts the dead channel back into the channels container
>9) The "orphaned" channel is visible in the channels list if a crash does
>not happen.
>
>This patch does the following:
>
>* Made ast_hangup() set AST_FLAG_ZOMBIE on a successfully hung-up channel
>and not release the channel lock until that has happened.
>
>* Made __ast_channel_masquerade() not setup a masquerade if either channel
>has AST_FLAG_ZOMBIE set.
>
>* Fix chan_agent misuse of AST_FLAG_ZOMBIE since it would no longer work.
>
>(closes issue ASTERISK-18222)
>Reported by: Alec Davis
>Tested by: rmudgett, Alec Davis, irroot, Karsten Wemheuer
>
>(closes issue ASTERISK-18273)
>Reported by: Karsten Wemheuer
>Tested by: rmudgett, Alec Davis, irroot, Karsten Wemheuer
>
>Review: https://reviewboard.asterisk.org/r/1400/
>


--------------
Tests
--------------
New Test Failures (2)
   - AsteriskTestSuite: S/fastagi/say-digits
   - AsteriskTestSuite: S/apps/directory context operator exit

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20110831/14ef0b1d/attachment.htm>