[test-results] [Bamboo] Asterisk - 1.6.2 - Linux - x86_64 build 115 has FAILED (24 tests failed, 23 failures were new). Change made by 7 authors

Bamboo bamboo at asterisk.org
Mon Sep 13 19:11:31 CDT 2010


-------------- next part --------------
-----------------------------------------------------------
AST-162-115 failed.
-----------------------------------------------------------
Code has been updated by qwell, twilson, oej, rmudgett, Paul Belanger, dvossel, Tilghman Lesher.
24/59 tests failed.

http://bamboo.asterisk.org/browse/AST-162-115/        


--------------
Code Changes
--------------
dvossel (286071):

>Blocked revisions 286070 via svnmerge
>
>........
>  r286070 | dvossel | 2010-09-10 15:03:50 -0500 (Fri, 10 Sep 2010) | 32 lines
>  
>  Fixes sip extension state update DEADLOCK
>  
>  PROBLEM:
>  In chan_sip, and all the other channel drivers, it is common for
>  us to hold the tech_pvt lock while we ask the Asterisk core about
>  an extension and context.  Every time we do this the locking
>  order becomes, (1. tech_pvt lock ---> 2. global context lock). In
>  chan_sip when a dialog subscribes to a hint, that locking order
>  is reversed in the extensionstate callback which will occur outside
>  of the channel_driver's monitor loop.  So, on an extension state
>  update we have (1. global context lock ----> 2. tech_pvt lock).
>  
>  Typically when we have to do a reversed locking order like this
>  we'd just do some sort of deadlock avoidance to fix the problem...
>  That will not work here.  There are more locks involved here than
>  just the context and tech_pvt.  Those are the two that are colliding,
>  but it is impossible to give up the context lock because the global
>  hints list lock MUST be held as well and we can not give that lock
>  up during the extensionstate callback traversal... The locking order
>  for the context and hints are (1. global context lock ----> 2.
>  hints list lock).  Deadlock avoidance is not an option here.
>  
>  SOLUTION:
>  The solution this patch implements is to queue the extension state updates
>  into a list and send the NOTIFY messages out during the do_monitor pvt
>  traversal.  This clears out the problem of having to hold the context
>  lock before the tech_pvt lock entirely.
>  
>  (closes issue #17888)
>  Reported by: zerohalo
>........
>

twilson (286115):

>Merged revisions 286059 via svnmerge from 
>https://origsvn.digium.com/svn/asterisk/branches/1.4
>
>........
>  r286059 | twilson | 2010-09-10 14:25:08 -0500 (Fri, 10 Sep 2010) | 16 lines
>  
>  Inherit CHANNEL() writes to both sides of a Local channel
>  
>  Having Local (/n) channels as queue members and setting the language in the
>  extension with Set(CHANNEL(language)=fr) sets the language on the Local/...,2
>  channel. Hold time report playbacks happen on the Local/...,1 channel and
>  therefor do not play in the specified language.
>  
>  This patch modifies func_channel_write to call the setoption callback and pass
>  the CHANNEL() write info to the callback. chan_local uses this information to
>  look up the other side of the channel and apply the same changes to it.
>  
>  (closes issue #17673)
>  Reported by: Guggemand
>  
>  Review: https://reviewboard.asterisk.org/r/903/
>........
>

Tilghman Lesher (286527):

>Refactor conversion to ast_poll() to fix callparking regression.
>


--------------
Tests
--------------
Failed Tests (24)
   - AsteriskTestSuite: Blind-transfer-parkingtimeout (New)
   - AsteriskTestSuite: Chanspy/chanspy barge (New)
   - AsteriskTestSuite: Directed pickup (New)
   - AsteriskTestSuite: Fastagi/channel-status (New)
   - AsteriskTestSuite: Fastagi/connect (New)
   - AsteriskTestSuite: Fastagi/control-stream-file (New)
   - AsteriskTestSuite: Fastagi/database (New)
   - AsteriskTestSuite: Fastagi/execute (New)
   - AsteriskTestSuite: Fastagi/get-data (New)
   - AsteriskTestSuite: Fastagi/hangup (New)
   - AsteriskTestSuite: Fastagi/record-file (New)
   - AsteriskTestSuite: Fastagi/say-alpha (New)
   - AsteriskTestSuite: Fastagi/say-date (New)
   - AsteriskTestSuite: Fastagi/say-datetime (New)
   - AsteriskTestSuite: Fastagi/say-digits (New)
   - AsteriskTestSuite: Fastagi/say-number (New)
   - AsteriskTestSuite: Fastagi/say-phonetic (New)
   - AsteriskTestSuite: Fastagi/say-time (New)
   - AsteriskTestSuite: Fastagi/stream-file (New)
   - AsteriskTestSuite: Feature attended transfer (New)
   - AsteriskTestSuite: Feature blonde transfer (New)
   - AsteriskTestSuite: Iax2/basic-call (New)
   - AsteriskTestSuite: One-step-parking (New)
   - AsteriskTestSuite: Callparking (Existing)


--
This message is automatically generated by Atlassian Bamboo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/test-results/attachments/20100913/a2fe727a/attachment-0001.htm 


More information about the Test-results mailing list