[dahdi-commits] sruffell: branch linux/2.5 r10145 - /linux/branches/2.5/drivers/dahdi/wct4xxp/
SVN commits to the DAHDI project
dahdi-commits at lists.digium.com
Thu Aug 18 14:35:01 CDT 2011
Author: sruffell
Date: Thu Aug 18 14:34:57 2011
New Revision: 10145
URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=10145
Log:
wct4xxp: Bug in timing cable with different span density cards
The logic loops through the static cards[] array to determine timing,
but the subloop was based off the current card's numspans member.
This could cause a null dereference in the case where two cards of
different span densities were connected via timing cables.
Reported-by: Doug Bailey <dbailey at digium.com>
Signed-off-by: Russ Meyerriecks <rmeyerriecks at digium.com>
Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=10140
Modified:
linux/branches/2.5/drivers/dahdi/wct4xxp/base.c
Modified: linux/branches/2.5/drivers/dahdi/wct4xxp/base.c
URL: http://svnview.digium.com/svn/dahdi/linux/branches/2.5/drivers/dahdi/wct4xxp/base.c?view=diff&rev=10145&r1=10144&r2=10145
==============================================================================
--- linux/branches/2.5/drivers/dahdi/wct4xxp/base.c (original)
+++ linux/branches/2.5/drivers/dahdi/wct4xxp/base.c Thu Aug 18 14:34:57 2011
@@ -2384,7 +2384,7 @@
while (p < 8) {
nonzero = 0;
for (x=0;cards[x];x++) {
- for (i = 0; i < wc->numspans; i++) {
+ for (i = 0; i < cards[x]->numspans; i++) {
if (cards[x]->tspans[i]->syncpos) {
nonzero = 1;
if ((cards[x]->tspans[i]->syncpos == p) &&
More information about the dahdi-commits
mailing list