<html>
<head>
<meta name="viewport" content="width=device-width" />
<base href="https://wiki.asterisk.org/wiki" />
<style type="text/css">
body, #email-content, #email-content-inner { font-family: Arial,FreeSans,Helvetica,sans-serif; }
body, p, blockquote, pre, code, td, th, li, dt, dd { font-size: 13px; }
small { font-size: 11px; }
body { width:100% !important; -webkit-font-smoothing: antialiased; }
body,
#email-wrapper { background-color: #f0f0f0; }
#email-wrapper-inner { padding: 20px; text-align: center; }
#email-content-inner { background-color: #fff; border: 1px solid #bbb; color: $menuTxtColour; padding:20px; text-align:left; }
#email-wrapper-inner > table { width: 100%; }
#email-wrapper-inner.thin > table { margin: 0 auto; width: 50%; }
#email-footer { padding: 0 16px 32px 16px; margin: 0; }
.email-indent { margin: 8px 0 16px 0; }
.email-comment { margin: 0 0 0 56px; }
.email-comment.removed { background-color: #ffe7e7; border: 1px solid #df9898; padding: 0 8px;}
#email-title-avatar { text-align: left; vertical-align: top; width: 48px; padding-right: 8px; }
#email-title-flavor { margin: 0; padding: 0 0 4px 0; }
#email-title-heading { font-size: 16px; line-height: 20px; min-height: 20px; margin: 0; padding: 0; }
#email-title .icon { border: 0; padding: 0 5px 0 0; text-align: left; vertical-align: middle; }
#email-actions { border-top: 1px solid #bbb; color: #505050; margin: 8px 0 0 0; padding: 0; }
#email-actions td { padding-top: 8px; }
#email-actions .left { max-width: 45%; text-align: left; }
#email-actions .right { text-align: right; }
.email-reply-divider { border-top: 1px solid #bbb; color: #505050; margin: 32px 0 8px 0; padding: 8px 0; }
.email-section-title { border-bottom: 1px solid #bbb; margin: 8px 0; padding: 8px 0 0 0; }
.email-metadata { color: #505050; }
a { color: #326ca6; text-decoration: none; }
a:hover { color: #336ca6; text-decoration: underline; }
a:active {color: #326ca6; }
a.email-footer-link { color: #505050; font-size: 11px; }
.email-item-list { list-style: none; margin: 4px 0; padding-left: 0; }
.email-item-list li { list-style: none; margin: 0; padding: 4px 0; }
.email-list-divider { color: #505050; padding: 0 0.35em; }
.email-operation-icon { padding-right: 5px; }
.avatar { -ms-interpolation-mode: bicubic; border-radius: 3px;}
.avatar-link { margin: 2px; }
.tableview th { border-bottom: 1px solid #69C; font-weight: bold; text-align: left; }
.tableview td { border-bottom: 1px solid #bbbbbb; text-align: left; padding: 4px 16px 4px 0; }
.aui-message { margin: 1em 0; padding: 8px; }
.aui-message.info { background-color: #e0f0ff; border: 1px solid #9eb6d4; }
.aui-message.success { background-color: #ddfade; border: 1px solid #93c49f; }
.aui-message.error,
.aui-message.removed { background-color: #ffe7e7; border: 1px solid #df9898; color: #000; }
.call-to-action-table { margin: 10px 1px 1px 1px;}
.call-to-cancel-container, .call-to-action-container { padding: 5px 20px; }
.call-to-cancel-container { border: 1px solid #aaa; background-color: #eee; border-radius: 3px; }
.call-to-cancel-container a.call-to-cancel-button { background-color: #eee; font-size: 14px; line-height: 1; padding: 0; margin: 0; color: #666; font-family: sans-serif;}
.call-to-action-container { border: 1px solid #486582; background-color: #3068A2; border-radius: 3px; padding: 4px 10px; }
.call-to-action-container a.call-to-action-button { background-color: #3068A2; font-size: 14px; line-height: 1; padding: 0; margin: 0; color: #fff; font-weight: bold; font-family: sans-serif; }
/** The span around the inline task checkbox image */
.diff-inline-task-overlay {
display: inline-block;
text-align: center;
height: 1.5em;
padding: 5px 0px 1px 5px;
margin-right: 5px;
/** Unfortunately, the negative margin-left is stripped out in gmail */
margin-left: -5px;
}
@media handheld, only screen and (max-device-width: 480px) {
div, a, p, td, th, li, dt, dd { -webkit-text-size-adjust: auto; }
small, small a { -webkit-text-size-adjust: 90%; }
td[id=email-wrapper-inner] { padding: 2px !important; }
td[id=email-content-inner] { padding: 8px !important; }
td[id="email-wrapper-inner"][class="thin"] > table { text-align: left !important; width: 100% !important; }
td[id=email-footer] { padding: 8px 12px !important; }
div[class=email-indent] { margin: 8px 0px !important; }
div[class=email-comment] { margin: 0 !important; }
p[id=email-title-flavor] a { display: block; } /* puts the username and the action on separate lines */
p[id=email-permalink] { padding: 4px 0 0 0 !important; }
table[id=email-actions] td { padding-top: 0 !important; }
table[id=email-actions] td.right { text-align: right !important; }
table[id=email-actions] .email-list-item { display: block; margin: 1em 0 !important; word-wrap: normal !important; }
span[class=email-list-divider] { display: none; }
}
</style>
</head>
<body style="font-family: Arial, FreeSans, Helvetica, sans-serif; font-size: 13px; width: 100%; -webkit-font-smoothing: antialiased; background-color: #f0f0f0">
<table id="email-wrapper" width="100%" cellspacing="0" cellpadding="0" border="0" style="background-color: #f0f0f0">
<tbody>
<tr valign="middle">
<td id="email-wrapper-inner" style="font-size: 13px; padding: 20px; text-align: center">
<table id="email-content" cellspacing="0" cellpadding="0" border="0" style="font-family: Arial, FreeSans, Helvetica, sans-serif; width: 100%">
<tbody>
<tr valign="top">
<td id="email-content-inner" align="left" style="font-family: Arial, FreeSans, Helvetica, sans-serif; font-size: 13px; background-color: #fff; border: 1px solid #bbb; padding: 20px; text-align: left">
<table id="email-title" cellpadding="0" cellspacing="0" border="0" width="100%">
<tbody>
<tr>
<td id="email-title-avatar" rowspan="2" style="font-size: 13px; text-align: left; vertical-align: top; width: 48px; padding-right: 8px"> <img class="avatar" src="cid:avatar_ce51dcf276530e4a4b00548e2a6d0905" border="0" height="48" width="48" style="-ms-interpolation-mode: bicubic; border-radius: 3px" /> </td>
<td valign="top" style="font-size: 13px">
<div id="email-title-flavor" class="email-metadata" style="margin: 0; padding: 0 0 4px 0; color: #505050">
<a href=" https://wiki.asterisk.org/wiki/display/~mjordan " style="color:#326ca6;text-decoration:none;; color: #326ca6; text-decoration: none">Matt Jordan</a> created a page:
</div> </td>
</tr>
<tr>
<td valign="top" style="font-size: 13px"> <h2 id="email-title-heading" style="font-size: 16px; line-height: 20px; min-height: 20px; margin: 0; padding: 0"> <a href="https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process" style="color: #326ca6; text-decoration: none"> <img class="icon" src="cid:page-icon" alt="" style="border: 0; padding: 0 5px 0 0; text-align: left; vertical-align: middle" /> <strong style="font-size:16px;line-height:20px;vertical-align:top;">Patch Contribution Process</strong> </a> </h2> </td>
</tr>
</tbody>
</table>
<div class="email-indent" style="margin: 8px 0 16px 0">
<div class="email-page">
<h1 id="PatchContributionProcess-Overview">Overview</h1>
<p style="font-size: 13px">As an open source project, the Asterisk project welcomes contributions that enhance and improve the functionality of Asterisk. This page describes the process for submitting patches to Asterisk.</p>
<div class="aui-message warning shadowed information-macro" style="margin: 1em 0; padding: 8px">
<p class="title" style="font-size: 13px">Read More!</p>
<span class="aui-icon icon-warning">Icon</span>
<div class="message-content">
<p style="font-size: 13px">This page links to many other pages on the wiki that provide deeper explanations regarding reporting of issues, writing of patches, and participation in the Asterisk project. Please read the information on those linked pages! Having well tested, high quality patches proposed to the Asterisk project helps everyone.</p>
</div>
</div>
<h1 id="PatchContributionProcess-SubmittingaPatch">Submitting a Patch</h1>
<ol>
<li style="font-size: 13px"> <p style="font-size: 13px">Before contributing a patch, make sure your patch conforms to the Asterisk project <a href="https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines" style="color: #326ca6; text-decoration: none">Coding Guidelines</a>.</p> </li>
<li style="font-size: 13px"> <p style="font-size: 13px">Create your patch in unified diff format.<br /> <br />The easiest way to do this is from a <a href="https://wiki.asterisk.org/wiki/display/AST/Subversion+Usage" style="color: #326ca6; text-decoration: none">checkout of Asterisk from Subversion</a>:</p>
<div class="preformatted panel" style="border-width: 1px;">
<div class="preformattedContent panelContent">
<pre style="font-size: 13px"># svn diff > my_fancy_patch.diff</pre>
</div>
</div> <p style="font-size: 13px"> <br />Alternatively, you can use the <code style="font-size: 13px">diff -u</code> command to create a patch in the appropriate format:</p>
<div class="preformatted panel" style="border-width: 1px;">
<div class="preformattedContent panelContent">
<pre style="font-size: 13px"># diff -u original/some_file.c modified/some_file.c > my_fancy_patch.diff</pre>
</div>
</div> </li>
<li style="font-size: 13px"> <p style="font-size: 13px">Open a new issue in the <a href="https://issues.asterisk.org" class="external-link" rel="nofollow" style="color: #326ca6; text-decoration: none">Asterisk issue tracker</a>. See <a href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines" style="color: #326ca6; text-decoration: none">Asterisk Issue Guidelines</a> for more information on how to report an issue in the issue tracker.</p>
<div class="aui-message success shadowed information-macro" style="margin: 1em 0; padding: 8px; background-color: #ddfade; border: 1px solid #93c49f">
<span class="aui-icon icon-success">Icon</span>
<div class="message-content">
<p style="font-size: 13px">If your patch fixes a bug, please write the patch against the oldest currently supported <a href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+Versions" style="color: #326ca6; text-decoration: none">version of Asterisk</a>. If your patch is a new feature or improvement, please write the patch against <a href="http://svn.asterisk.org/svn/asterisk/trunk" class="external-link" rel="nofollow" style="color: #326ca6; text-decoration: none">trunk</a>. See <a href="https://wiki.asterisk.org/wiki/display/AST/Software+Configuration+Management+Policies" style="color: #326ca6; text-decoration: none">Software Configuration Management Policies</a> for more information about Asterisk release branches and the policies affecting them.<br /> <br /> </p>
</div>
</div> </li>
<li style="font-size: 13px">Sign a License Contributor Agreement in the issue tracker.</li>
<li style="font-size: 13px">Attach your patch to the newly created issue, marking the patch as a code contribution.</li>
</ol>
<h1 id="PatchContributionProcess-CodeReview">Code Review</h1>
<p style="font-size: 13px">After you contribute a patch, bug marshals will triage the issue per the <a href="https://wiki.asterisk.org/wiki/display/AST/Issue+Tracker+Workflow" style="color: #326ca6; text-decoration: none">Issue Tracker Workflow</a>. At this time, it is appropriate to put your patch up for code review. The Asterisk project uses <a href="https://reviewboard.asterisk.org/dashboard/" class="external-link" rel="nofollow" style="color: #326ca6; text-decoration: none">Review Board</a> for peer review of patches - for instructions on how to submit your patch to Review Board, see <a href="https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage" style="color: #326ca6; text-decoration: none">Reviewboard Usage</a>.</p>
<p style="font-size: 13px">All users who have signed a license contributor agreement have access to Review Board and are encouraged to participate in the peer review process. This includes not only review of your patch, but review of other patches as well.</p>
<h2 id="PatchContributionProcess-SomeFrequentlyAskedQuestions">Some Frequently Asked Questions</h2>
<ol>
<li style="font-size: 13px"> <strong>Do I have to put my patch up for code review?</strong> <br /> <br />In short, no. Attaching your patch as a code contribution to an issue in JIRA is all that is required.<br /> <br />However, patches of any reasonable complexity <strong>should</strong> be put up for peer review. New features as well should always be reviewed.<br /> <br />In practice, many developers in the Asterisk community look to Review Board for patches that are ready to be considered for submission. As such, you are highly encouraged to submit your patch to Review Board for peer review - but <strong>please</strong> read the instructions on <a href="https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage" style="color: #326ca6; text-decoration: none">Reviewboard Usage</a>. You should also be aware of the <a href="https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines" style="color: #326ca6; text-decoration: none">Coding Guidelines</a>, as well as the INSERT CHECKLIST</li>
<li style="font-size: 13px"> <strong>No one has looked at my review. What do I do now?</strong> <br /> <br />First, please be patient. There may be lots of peer reviews occurring, and it can take some time for members of the community to comment on a review.<br /> <br />Second, help the reviewers by making sure that your patch is explained well, that the issue it solves/feature it provides is well understood, and that the patch is well tested. Unit tests and functional tests for the <a href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation" style="color: #326ca6; text-decoration: none">Asterisk Test Suite</a> will help immensely, and may also be necessary for your patch to be included.<br /> <br />Finally, get it involved! Contributors who participate in other reviews and show a willingness to test and help out with other submissions will probably receive more attention themselves.<br /> <br />When all else fails, ask for a review on the #asterisk-dev IRC channel or the <a href="http://lists.digium.com/" class="external-link" rel="nofollow" style="color: #326ca6; text-decoration: none">asterisk-dev</a> mailing list. Sometimes, we all just need a gentle nudge.</li>
</ol>
<h1 id="PatchContributionProcess-Committing">Committing</h1>
<p style="font-size: 13px">When a patch has been deemed correct and passed peer review - either on the issue in the issue tracker or Review Board - it will be committed by a developer with commit access. Which release branches the patch is committed into is determined by the <a href="https://wiki.asterisk.org/wiki/display/AST/Software+Configuration+Management+Policies" style="color: #326ca6; text-decoration: none">Software Configuration Management Policies</a>. All patches are committed to Asterisk trunk.</p>
<p style="font-size: 13px"> </p>
<p style="font-size: 13px"> </p>
<p style="font-size: 13px"> </p>
</div>
</div>
<table id="email-actions" class="email-metadata" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-top: 1px solid #bbb; color: #505050; margin: 8px 0 0 0; padding: 0; color: #505050">
<tbody>
<tr>
<td class="left" valign="top" style="font-size: 13px; padding-top: 8px; max-width: 45%; text-align: left"> <span class="email-list-item"><a href="https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process" style="color: #326ca6; text-decoration: none">View Online</a> </span> <span class="email-list-divider" style="color: #505050; padding: 0 0.350em">·</span> <span class="email-list-item"><a href="https://wiki.asterisk.org/wiki/plugins/likes/like.action?contentId=27820098" style="color: #326ca6; text-decoration: none">Like</a> </span> <span class="email-list-divider" style="color: #505050; padding: 0 0.350em">·</span> <span class="email-list-item"><a href="https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process?showComments=true&showCommentArea=true#addcomment" style="color: #326ca6; text-decoration: none">Add Comment</a> </span> </td>
<td class="right" width="50%" valign="top" style="font-size: 13px; padding-top: 8px; text-align: right"> <span class="email-list-item"><a href="https://wiki.asterisk.org/wiki/users/removespacenotification.action?spaceKey=AST" style="color: #326ca6; text-decoration: none">Stop watching space</a> </span> <span class="email-list-divider" style="color: #505050; padding: 0 0.350em">·</span> <span class="email-list-item"><a href="https://wiki.asterisk.org/wiki/users/editmyemailsettings.action" style="color: #326ca6; text-decoration: none">Manage Notifications</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-footer" align="center" style="font-size: 13px; padding: 0 16px 32px 16px; margin: 0"> <small style="font-size: 11px"> This message was sent by <a class="email-footer-link" style="color:#505050;font-size:11px;text-decoration:none;; color: #326ca6; text-decoration: none; color: #505050; font-size: 11px" href="http://www.atlassian.com/software/confluence">Atlassian Confluence</a> 5.1.5, <a class="email-footer-link" style="color:#505050;font-size:11px;text-decoration:none;; color: #326ca6; text-decoration: none; color: #505050; font-size: 11px" href="http://www.atlassian.com/software/confluence/overview/team-collaboration-software?utm_source=email-footer">Team Collaboration Software</a> </small> </td>
</tr>
</tbody>
</table>
</body>
</html>