<html>
<head>
<base href="https://wiki.asterisk.org/wiki">
<link rel="stylesheet" href="/wiki/s/en/2171/18/9/_/styles/combined.css?spaceKey=AST&forWysiwyg=true" type="text/css">
</head>
<body style="background: white;" bgcolor="white" class="email-body">
<div id="pageContent">
<div id="notificationFormat">
<div class="wiki-content">
<div class="email">
<h2><a href="https://wiki.asterisk.org/wiki/display/AST/AstriDevCon+2011">AstriDevCon 2011</a></h2>
<h4>Page <b>edited</b> by <a href="https://wiki.asterisk.org/wiki/display/~lmadsen">Leif Madsen</a>
</h4>
<div id="versionComment">
<b>Comment:</b>
Update P4 and P5 for 2011.<br />
</div>
<br/>
<h4>Changes (8)</h4>
<div id="page-diffs">
<table class="diff" cellpadding="0" cellspacing="0">
<tr><td class="diff-snipped" >...<br></td></tr>
<tr><td class="diff-unchanged" >*** Discussion about in the logger.conf to change the configuration so that the 'core set verbose 5' (or debug, etc) that it does not affect all the configuration files when you just want to change the verbosity on the console. <br>*** Configuration could be under a header, and then create your own filters for channels, and what verbosity,debug,etc. is output to a log file and console per file <br></td></tr>
<tr><td class="diff-added-lines" style="background-color: #dfd;">*** *Take Away*: Need to have a discussion of what people would want and need (requirements gathering), and then we can investigate how difficult it would be to implement, and what the order of implementation. <br></td></tr>
<tr><td class="diff-unchanged" > <br>h2. (P4, Simon's features) <br></td></tr>
<tr><td class="diff-snipped" >...<br></td></tr>
<tr><td class="diff-unchanged" >* Multiple SIP Sockets <br>** (Listen on multiple ports or on multiple interfaces, but not all; also set binding for RTP)...alternate idea / solution would be to make Asterisk capable of loading multiple SIP profiles, it might be easier <br></td></tr>
<tr><td class="diff-added-lines" style="background-color: #dfd;">** *Review 2011*: No change. <br></td></tr>
<tr><td class="diff-unchanged" >* Multiple DNS results <br>** (need to be able to traverse a list of DNS results, rather than just getting back one result) <br></td></tr>
<tr><td class="diff-added-lines" style="background-color: #dfd;">** *Review 2011*: Some work has been done, but chan_sip (or others) has not been enhanced to take advantage of that. <br></td></tr>
<tr><td class="diff-unchanged" >* ICE-lite <br>** (no code, responding correctly to ICE connectivity checks (STUN multiplexed on the RTP port) and understanding the SDP); it makes NAT traversal work for clients that do ICE; also addressed lightweight NAT refresh) <br></td></tr>
<tr><td class="diff-added-lines" style="background-color: #dfd;">** *Review 2011*: No change or progress. No one has tried to work on it. Appears to be very little deployment. <br></td></tr>
<tr><td class="diff-unchanged" > <br>h2. (P5) <br> <br>* -AstDB replacement- SQLite <br></td></tr>
<tr><td class="diff-deleted-lines" style="color:#999;background-color:#fdd;text-decoration:line-through;">** (realtime, there's code, nearly ready) <br></td></tr>
<tr><td class="diff-added-lines" style="background-color: #dfd;">** *Review 2011*: Have initial support implemented for Asterisk 10. Backend is being used. Terry is continuing to work on additional functionality in trunk. <br></td></tr>
<tr><td class="diff-unchanged" >* SIP identity <br>** (on reviewboard; needs to be forward ported; important for organizations w/ federated identities; a requirement for DTLS SRTP; not widely deployed) <br></td></tr>
<tr><td class="diff-added-lines" style="background-color: #dfd;">** *Review 2011*: No change. <br></td></tr>
<tr><td class="diff-unchanged" >* RTMP client channel driver <br></td></tr>
<tr><td class="diff-added-lines" style="background-color: #dfd;">** *Review 2011*: No change. <br></td></tr>
<tr><td class="diff-unchanged" > <br> <br></td></tr>
<tr><td class="diff-snipped" >...<br></td></tr>
</table>
</div> <h4>Full Content</h4>
<div class="notificationGreySide">
<div>
<ul>
<li><a href='#AstriDevCon2011-Introduction'>1. Introduction</a></li>
<li><a href='#AstriDevCon2011-DevelopersPresent'>2. Developers Present</a></li>
<li><a href='#AstriDevCon2011-Asterisk10Ideas'>3. Asterisk 10 Ideas</a></li>
<ul>
<li><a href='#AstriDevCon2011-%28P0%29'>3.1. (P0)</a></li>
<li><a href='#AstriDevCon2011-%28P1%29'>3.2. (P1)</a></li>
<li><a href='#AstriDevCon2011-%28P2%29'>3.3. (P2)</a></li>
<li><a href='#AstriDevCon2011-%28P3%29'>3.4. (P3)</a></li>
<li><a href='#AstriDevCon2011-%28P4%2CSimon%27sfeatures%29'>3.5. (P4, Simon's features)</a></li>
<li><a href='#AstriDevCon2011-%28P5%29'>3.6. (P5)</a></li>
<li><a href='#AstriDevCon2011-%28P6%29'>3.7. (P6)</a></li>
<li><a href='#AstriDevCon2011-%28P7%2Cnotkobaz%29'>3.8. (P7, not kobaz)</a></li>
<li><a href='#AstriDevCon2011-%28P8%2Cnicetohave%29'>3.9. (P8, nice to have)</a></li>
<li><a href='#AstriDevCon2011-%28P%3F%2CResearchRequired%29'>3.10. (P?, Research Required)</a></li>
</ul>
<li><a href='#AstriDevCon2011-TestingFrameworkIdeas'>4. Testing Framework Ideas</a></li>
<li><a href='#AstriDevCon2011-ReleasePolicyDiscussion'>5. Release Policy Discussion</a></li>
<li><a href='#AstriDevCon2011-Photosofattendees'>6. Photos of attendees</a></li>
</ul></div>
<h1><a name="AstriDevCon2011-Introduction"></a>1. Introduction</h1>
<p>AstriDevCon 2011 was held on Monday, October 24th. It was held on the day prior to AstriCon at the same location. A group of active development community members met and discussed a number of topics, including:</p>
<ul>
<li>Review of AstriDevCon 2011 (Asterisk)</li>
</ul>
<h1><a name="AstriDevCon2011-DevelopersPresent"></a>2. Developers Present</h1>
<ul>
<li>Erik Klein: Humbug Telecom</li>
<li>Dunling Li: BTS</li>
<li>Chris May</li>
<li>Shaun Ruffell: Digium</li>
<li>Bryan Johns: Digium</li>
<li>Mark Murawski: Telesoft</li>
<li>Kevin Fleming: Digium</li>
<li>Byron Clark: Jack Communications</li>
<li>Jamual Starkey: Headland Communications</li>
<li>Leif Madsen: LeifMadsen Enterprises, Inc / Digium</li>
<li>Matt Riddel: Asterisk Daily News</li>
<li>Nir Simonivich: Greenfield Technologies / Humbug Telecom</li>
<li>Paul Belanger: Digium</li>
<li>Claude Patry</li>
<li>Jason Parker: Digium</li>
<li>David Vossel: Digium</li>
<li>Matt Jordan: Digium</li>
<li>Ben Klang: Mojo Lingo / Adhearsion</li>
<li>Brad Watkins: Copyware</li>
</ul>
<h1><a name="AstriDevCon2011-Asterisk10Ideas"></a>3. Asterisk 10 Ideas</h1>
<p>We spent probably half of the day discussing Asterisk 10. We came up with a list of development projects we'd like to get done and then prioritized them.</p>
<h2><a name="AstriDevCon2011-%28P0%29"></a>3.1. (P0)</h2>
<p>P0 are committed projects that are going to get done.</p>
<ul>
<li><del><a href="/wiki/display/AST/T.38+Gateway" title="T.38 Gateway">T.38 Gateway</a></del> (Digium)</li>
<li><del>Performance of State Change Processing (Stefan Schmidt)</del>
<ul>
<li><del>(work is already being done on this front)</del></li>
</ul>
</li>
<li>SIP path support (Olle)
<ul>
<li>(first generation of code exists, needs more work, simple patch, going to get it done, needs an extra field in astdb; helps when there are 2 or more load balancing proxies in front of asterisk, when you'd like the call to be able to get back to Asterisk; see <a href="https://reviewboard.asterisk.org/r/991/" class="external-link" rel="nofollow">https://reviewboard.asterisk.org/r/991/</a>)</li>
<li><a href="https://issues.asterisk.org/view.php?id=18223" class="external-link" rel="nofollow">https://issues.asterisk.org/view.php?id=18223</a></li>
<li><b>Review 2011</b>: No change since 2010</li>
</ul>
</li>
<li>Group variables (Kobaz)
<ul>
<li>(on review board, in progress)</li>
<li><b>Review 2011</b>: Code written and then re-written this year, tested in production for a year. Feels good code wise. Some suggestions on reviewboard and should be converted to ao2.
<ul>
<li>Still want to get on Asterisk 10</li>
<li>Goal to commit for Asterisk 11</li>
<li><a href="http://reviewboard.asterisk.org/r/464" class="external-link" rel="nofollow">http://reviewboard.asterisk.org/r/464</a></li>
</ul>
</li>
</ul>
</li>
<li>Pre-Dial (Kobaz)
<ul>
<li>(practically done, or something)</li>
<li><b>Review 2011</b>: Very happy with the way it is. Could be committed after the re-write.
<ul>
<li>Goal to commit for Asterisk 11</li>
<li><a href="https://reviewboard.asterisk.org/r/1229/" class="external-link" rel="nofollow">https://reviewboard.asterisk.org/r/1229/</a></li>
</ul>
</li>
</ul>
</li>
<li>Distributed extension state using SIP (Olle)
<ul>
<li>(resources in place, doing it, 1.4 done before Christmas, project pinana)</li>
<li><b>Review 2011</b>: No changes known. Idle.</li>
</ul>
</li>
<li>Manager event docs (Paul Belanger)
<ul>
<li><b>Review 2011</b>: Code was created and working, but did not pass code review. Talked about it again a couple of months ago, and some work done.
<ul>
<li>About a day or two to get the framework completed</li>
<li>Then just need to insert the documentation into the code and then it could be completed.</li>
</ul>
</li>
</ul>
</li>
<li>Cross-platform documentation (Ben Klang)
<ul>
<li>(caveats for using Asterisk on operating system xyz; pull a PDF of the Wiki documentation into the source, don't forget to include basic installation information, and do it all in .txt - Ben)</li>
<li><b>Review 2011</b>: Documentation updated for Solaris. Is on the wiki, and just needs to be put into a better location. Leif will help restructure part of the wiki to make the Linux and Solaris documentation (and other operating systems) a better format.</li>
</ul>
</li>
<li>Fix libs to optionally init OpenSSL (Digium)
<ul>
<li>(or use existing tools; sort of a bug)</li>
<li><b>Review 2011</b>: Code on reviewboard, need to confirm that the code solves the problem, confirmed it doesn't cause harm
<ul>
<li>Testing required on multiple platforms and libraries</li>
</ul>
</li>
</ul>
</li>
<li>Make ast_channel an opaque type (Digium)
<ul>
<li><b>Review 2011</b>: Large project and has not been started. Should not be on P0.</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P1%29"></a>3.2. (P1)</h2>
<p>P1 is the highest priority.</p>
<ul>
<li>Who hung up? (there's a branch, shouldn't take too much time - Olle)
<ul>
<li><b>Review 2011</b>: Jason Parker thinks something like that may have been committed a few months ago by Jeffrey C. Ollie. Will need to review to see if anything has actually been done there.
<ul>
<li>Kobaz has a 2-3 line code change that simply adds events to Softhangup() and Hangup()</li>
<li>On a failed call, there is no access to the causecodes – would be powerful if we had access to it
<ul>
<li>Would need to develop some code that created a generic layer to convert between channel drivers (each does it different)</li>
<li>Need to investigate if there are any CEL events already created that will give some of that information</li>
</ul>
</li>
</ul>
</li>
</ul>
</li>
<li><del><a href="/wiki/display/AST/Media+Overhaul" title="Media Overhaul">Codecs (SILK, OPUS), Media Negotiation</a></del> (Digium)
<ul>
<li><b>Review 2011</b>: Every version of Asterisk had a fixed bitfield, and we needed to be conscious about adding new codecs (limited). Project was to remove that limitation. Reworked how media formats are represented in Asterisk. Integration of codecs like SILK and CELT. Helps with better support for video as well.
<ul>
<li>Framework in place</li>
<li>Need to now start using the framework to help add functionality to Asterisk</li>
<li>For Asterisk 11, would be nice to add re-invite support so that clients and re-negotiate resolutions (for video). End-to-end negotiation. Framework in place to do that, just need to add the functionality.</li>
</ul>
</li>
</ul>
</li>
<li>RTCP (Olle)
<ul>
<li>Pinefrog; Work to be done - Ported to trunk, added to CEL</li>
<li><b>Review 2011</b>: Idle</li>
</ul>
</li>
<li><del>Conferencing that supports a new magic media</del> (Digium)
<ul>
<li><b>Review 2011</b>: Completed and in Asterisk 10. Updated ConfBridge() application which was pretty much re-written. Now supports high resolution codecs and voice activity video switching within ConfBridge().</li>
<li><del>higher sampling rates</del></li>
<li><b>Review 2011</b>: Part of the codec negotiation framworks.</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P2%29"></a>3.3. (P2)</h2>
<ul>
<li>Async DNS (TCP DNS and use a good resolver)
<ul>
<li><b>Review 2011</b>: No change known.</li>
</ul>
</li>
<li>Named ACLs (deluxepine)
<ul>
<li><b>Review 2011</b>: Idle</li>
</ul>
</li>
<li><a href="/wiki/display/AST/SIP+Security+Events" title="SIP Security Events">SIP Security Events</a>
<ul>
<li><b>Review 2011</b>: Additional work was updated and put into Asterisk 10. Only reported manager authentication events prior to Asterisk 10.
<ul>
<li>Prior to Asterisk 10 relaxed policy a bit and added chan_sip security events (only for inbound registration).</li>
<li>Additional work needed throughout Asterisk to add more events.</li>
</ul>
</li>
</ul>
</li>
<li>Light weight means of holding NAT open in SIP (less complex than current qualify, Consider it done)
<ul>
<li><b>Review 2011</b>: No change.</li>
</ul>
</li>
<li>IPv6 for the restivus (IAX, Jabber/XMPP/Gtalk, Manager, etc.)
<ul>
<li><b>Review 2011</b>: No change.</li>
</ul>
</li>
<li><del>ConfBridge feature complete with MeetMe</del>
<ul>
<li><b>Review 2011</b>: Not entirely true, but very close.</li>
</ul>
</li>
<li>Support sound file containers (matroska)
<ul>
<li><b>Review 2011</b>: Suggestion to have (media) files used by Asterisk not just headerless files, so you could actually do things properly, like storing G729 that contains silent suppression information.
<ul>
<li>No change in Asterisk, but has been getting worked on for Asterisk SCF. Very complicated. Matroska is just a framework. Once stable for Asterisk SCF, we can consider building it for Asterisk as well.</li>
</ul>
</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P3%29"></a>3.4. (P3)</h2>
<ul>
<li>Unique identifier for filtering log data to a call
<ul>
<li>(finishing what was already begun w/ Clod's project, CLI filtering; should take a look at what Stephan from Unlimitel.ca's created)</li>
<li><b>Review 2011</b>: Claude's patch was only for CLI filtering.
<ul>
<li>Discussion about in the logger.conf to change the configuration so that the 'core set verbose 5' (or debug, etc) that it does not affect all the configuration files when you just want to change the verbosity on the console.</li>
<li>Configuration could be under a header, and then create your own filters for channels, and what verbosity,debug,etc. is output to a log file and console per file</li>
<li><b>Take Away</b>: Need to have a discussion of what people would want and need (requirements gathering), and then we can investigate how difficult it would be to implement, and what the order of implementation.</li>
</ul>
</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P4%2CSimon%27sfeatures%29"></a>3.5. (P4, Simon's features)</h2>
<ul>
<li>Multiple SIP Sockets
<ul>
<li>(Listen on multiple ports or on multiple interfaces, but not all; also set binding for RTP)...alternate idea / solution would be to make Asterisk capable of loading multiple SIP profiles, it might be easier</li>
<li><b>Review 2011</b>: No change.</li>
</ul>
</li>
<li>Multiple DNS results
<ul>
<li>(need to be able to traverse a list of DNS results, rather than just getting back one result)</li>
<li><b>Review 2011</b>: Some work has been done, but chan_sip (or others) has not been enhanced to take advantage of that.</li>
</ul>
</li>
<li>ICE-lite
<ul>
<li>(no code, responding correctly to ICE connectivity checks (STUN multiplexed on the RTP port) and understanding the SDP); it makes NAT traversal work for clients that do ICE; also addressed lightweight NAT refresh)</li>
<li><b>Review 2011</b>: No change or progress. No one has tried to work on it. Appears to be very little deployment.</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P5%29"></a>3.6. (P5)</h2>
<ul>
<li><del>AstDB replacement</del> SQLite
<ul>
<li><b>Review 2011</b>: Have initial support implemented for Asterisk 10. Backend is being used. Terry is continuing to work on additional functionality in trunk.</li>
</ul>
</li>
<li>SIP identity
<ul>
<li>(on reviewboard; needs to be forward ported; important for organizations w/ federated identities; a requirement for DTLS SRTP; not widely deployed)</li>
<li><b>Review 2011</b>: No change.</li>
</ul>
</li>
<li>RTMP client channel driver
<ul>
<li><b>Review 2011</b>: No change.</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P6%29"></a>3.7. (P6)</h2>
<ul>
<li>Structured identifiers for errors
<ul>
<li>(tag an error message with a unique string, specific to the error message and where it came from; should be alphanumeric to keep them short)</li>
</ul>
</li>
<li>AMI SetVar, Context limits
<ul>
<li>(there's code already...Olle has it)</li>
</ul>
</li>
<li>AMI filters on demand</li>
<li>DTLS SRTP
<ul>
<li>(not likely to be widely deployed in the next 12 months)</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P7%2Cnotkobaz%29"></a>3.8. (P7, not kobaz)</h2>
<ul>
<li>Asterisk register for XMPP account (Leif)</li>
<li>Write a Specification for AMI (not kobaz)</li>
<li>Multiple TLS server certs
<ul>
<li>(1 socket, requires support by OpenSSL; simpler to implement than multiple SIP profiles; don't know if any clients use it yet; needs more research)</li>
</ul>
</li>
</ul>
<h2><a name="AstriDevCon2011-%28P8%2Cnicetohave%29"></a>3.9. (P8, nice to have)</h2>
<ul class="alternate" type="square">
<li>Make resource modules that talk to DBs attempt reconnects</li>
<li>Apple's new file streaming format, derived from .m3u</li>
<li>Make MixMonitor and Monitor feature compatible</li>
</ul>
<h2><a name="AstriDevCon2011-%28P%3F%2CResearchRequired%29"></a>3.10. (P?, Research Required)</h2>
<ul>
<li>New app_queue (as if? no, seriously? talking about this scares Russell)</li>
<li>Identify and fix all bugs in AMI</li>
<li>Broadsoft or Dialog Info shared line appearance (SLA) support
<ul>
<li>(Tabled for later discussion)</li>
</ul>
</li>
<li>LDAP from within the dialplan
<ul>
<li>(we may already have it, needs research to see if the realtime driver does what's desired - Leif)</li>
</ul>
</li>
<li>Device state normalization</li>
<li>Anything DB over HTTP(s) with failover handling</li>
<li>Use a channel as a MoH Source</li>
<li>Kill Masquerades</li>
<li>Bridging thread pool</li>
<li>Threadify chan_sip</li>
<li>Export ISDN ROSE information up to Asterisk channels</li>
</ul>
<h1><a name="AstriDevCon2011-TestingFrameworkIdeas"></a>4. Testing Framework Ideas</h1>
<p>We discussed the automated testing that has been built for Asterisk and discussed ideas for future improvements.</p>
<ul class="alternate" type="square">
<li>Add Adhearsion</li>
<li>Media Analysis (Quality)</li>
<li>TestServer / TestClient</li>
<li>Emulate phone-specific behavior</li>
<li>Test ${RESULT} vars</li>
<li>Check memory usage (for leaks)</li>
<li>Custom statistics over time</li>
<li>Automated load tests</li>
<li>Valgrind integration</li>
<li>Tone generation and analysis</li>
<li>Broken dial strings</li>
<li>Bad options to applications</li>
<li>Make tests more generic so they can be toggled to run across multiple channels, or channel types, more easily</li>
<li>Try to access features that are disallowed</li>
<li>Test calls between versions of Asterisk</li>
<li>Randomize call length and application during load testing - "Fuzzing"</li>
<li>Automated crash analysis (generate backtraces and logs, etc)</li>
<li>Testing against a SIP Proxy</li>
<li>Non-root isolated test suite</li>
<li>RFC4475 and RFC5118 tests (SIP Torture tests)</li>
<li>More chan_sip parsing unit tests</li>
<li>SDP testing multiple media streaming</li>
<li>protos SIP tester</li>
<li>TAHI SIP tester for IPv6</li>
<li>test SSL / TLS SIP connectivity</li>
<li>Sound file I/O</li>
<li>Manager events for scenarios</li>
<li>Basic calls with all channel types</li>
<li>Connected party ID</li>
<li>Tonezone tests</li>
<li>Language tests</li>
</ul>
<h1><a name="AstriDevCon2011-ReleasePolicyDiscussion"></a>5. Release Policy Discussion</h1>
<p>We discussed Asterisk release policy. Specifically, we were considering the current policy that excludes features from a release branch. After a bit of discussion, it was decided that no changes to policy would be made. We did agree that a new self contained module that was not compiled by default would be fine, but that it would be rare that it would provide benefit, since most projects are modifications of existing code.</p>
<h1><a name="AstriDevCon2011-Photosofattendees"></a>6. Photos of attendees</h1>
<p>We rock.</p>
<p><span class="image-wrap" style="display: block; text-align: center"><a class="confluence-thumbnail-link 4752x3168" href='https://wiki.asterisk.org/wiki/download/attachments/19006492/IMG_4162.JPG'><img src="/wiki/download/thumbnails/19006492/IMG_4162.JPG" style="border: 0px solid black" /></a></span><br/>
<span class="image-wrap" style="display: block; text-align: center"><a class="confluence-thumbnail-link 4752x3168" href='https://wiki.asterisk.org/wiki/download/attachments/19006492/IMG_4164.JPG'><img src="/wiki/download/thumbnails/19006492/IMG_4164.JPG" style="border: 0px solid black" /></a></span><br/>
<span class="image-wrap" style="display: block; text-align: center"><a class="confluence-thumbnail-link 4752x3168" href='https://wiki.asterisk.org/wiki/download/attachments/19006492/IMG_4165.JPG'><img src="/wiki/download/thumbnails/19006492/IMG_4165.JPG" style="border: 0px solid black" /></a></span><br/>
<span class="image-wrap" style="display: block; text-align: center"><a class="confluence-thumbnail-link 4752x3168" href='https://wiki.asterisk.org/wiki/download/attachments/19006492/IMG_4166.JPG'><img src="/wiki/download/thumbnails/19006492/IMG_4166.JPG" style="border: 0px solid black" /></a></span></p>
</div>
<div id="commentsSection" class="wiki-content pageSection">
<div style="float: right;" class="grey">
<a href="https://wiki.asterisk.org/wiki/users/removespacenotification.action?spaceKey=AST">Stop watching space</a>
<span style="padding: 0px 5px;">|</span>
<a href="https://wiki.asterisk.org/wiki/users/editmyemailsettings.action">Change email notification preferences</a>
</div>
<a href="https://wiki.asterisk.org/wiki/display/AST/AstriDevCon+2011">View Online</a>
|
<a href="https://wiki.asterisk.org/wiki/pages/diffpagesbyversion.action?pageId=19006492&revisedVersion=7&originalVersion=6">View Changes</a>
|
<a href="https://wiki.asterisk.org/wiki/display/AST/AstriDevCon+2011?showComments=true&showCommentArea=true#addcomment">Add Comment</a>
</div>
</div>
</div>
</div>
</div>
</body>
</html>