<div dir="ltr">Sorry for the delay but this turned out to be a bit more complex than I anticipated.<div>There are reviews up on Gerrit for the 16 and 18 branches that address the issues below as well as clean up the implementation, plug some memory leaks, etc.</div><div>16: <a href="https://gerrit.asterisk.org/c/asterisk/+/18896">https://gerrit.asterisk.org/c/asterisk/+/18896</a><br></div><div>18: <a href="https://gerrit.asterisk.org/c/asterisk/+/18897">https://gerrit.asterisk.org/c/asterisk/+/18897</a></div><div><br></div><div>I anticipate these will make it into the next set of release candidates which are due to be cut tomorrow.</div><div><br></div><div>Give them a try.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 3, 2022 at 1:51 PM George Joseph <<a href="mailto:gjoseph@sangoma.com">gjoseph@sangoma.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Looks like it'll be tomorrow before I can get the patch up. I ran into some strange issues.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 2, 2022 at 1:43 PM Dan Cropp <<a href="mailto:dan@amtelco.com" target="_blank">dan@amtelco.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div>
<p class="MsoNormal">Thank you George<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> asterisk-users <<a href="mailto:asterisk-users-bounces@lists.digium.com" target="_blank">asterisk-users-bounces@lists.digium.com</a>>
<b>On Behalf Of </b>George Joseph<br>
<b>Sent:</b> Tuesday, August 2, 2022 2:40 PM<br>
<b>To:</b> Asterisk Users Mailing List - Non-Commercial Discussion <<a href="mailto:asterisk-users@lists.digium.com" target="_blank">asterisk-users@lists.digium.com</a>><br>
<b>Subject:</b> Re: [External] [asterisk-users] [External] Geo location 18.14.0-rc1 question<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Aug 2, 2022 at 1:35 PM George Joseph <<a href="mailto:gjoseph@sangoma.com" target="_blank">gjoseph@sangoma.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Aug 2, 2022 at 1:13 PM Dan Cropp <<a href="mailto:dan@amtelco.com" target="_blank">dan@amtelco.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal">Is the allow_routing setting on the geolocation Wiki Profile also not fully implemented?<u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Well, 99% of the code is there. The 1% is parsing the config option. Not sure how I missed that.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I'll have a patch up first thing in the morning UTC-6.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I'll call it "allow_use_for_routing" in profile.<u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Actually just "allow_routing_use"<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">In the code, I see geolocation_routing used instead of allow_routing.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Tried both and Asterisk indicates it cannot find suitable setting so it doesn’t create the profile object.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Dan<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> Dan Cropp
<br>
<b>Sent:</b> Tuesday, August 2, 2022 10:04 AM<br>
<b>To:</b> Asterisk Users Mailing List - Non-Commercial Discussion <<a href="mailto:asterisk-users@lists.digium.com" target="_blank">asterisk-users@lists.digium.com</a>><br>
<b>Subject:</b> RE: [External] [asterisk-users] Geo location 18.14.0-rc1 question<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Thank you George.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> asterisk-users <<a href="mailto:asterisk-users-bounces@lists.digium.com" target="_blank">asterisk-users-bounces@lists.digium.com</a>>
<b>On Behalf Of </b>George Joseph<br>
<b>Sent:</b> Tuesday, August 2, 2022 9:57 AM<br>
<b>To:</b> Asterisk Users Mailing List - Non-Commercial Discussion <<a href="mailto:asterisk-users@lists.digium.com" target="_blank">asterisk-users@lists.digium.com</a>><br>
<b>Subject:</b> Re: [External] [asterisk-users] Geo location 18.14.0-rc1 question<u></u><u></u></p>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Aug 2, 2022 at 8:46 AM Dan Cropp <<a href="mailto:dan@amtelco.com" target="_blank">dan@amtelco.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div>
<p class="MsoNormal">I believe I have everything configured correctly, but Asterisk is complaining about my configuration<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">It is complaining about confidence settings.
<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">From the Asterisk Geolocation Implementation Wiki, I believe I have this set correctly.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p style="margin:0in;background:white"><span style="font-size:10.5pt;font-family:Helvetica,sans-serif;color:rgb(51,51,51)">Sub-parameters:</span><u></u><u></u></p>
<ul type="disc">
<li class="MsoNormal" style="color:rgb(51,51,51);background:white">
<code><span style="font-size:10pt">value</span></code><span style="font-size:10.5pt;font-family:Helvetica,sans-serif">: A percentage indicating the confidence or "unknown".</span><u></u><u></u></li><li class="MsoNormal" style="color:rgb(51,51,51);background:white">
<code><span style="font-size:10pt">pdf</span></code><span style="font-size:10.5pt;font-family:Helvetica,sans-serif">: "unknown", "normal" or "rectangular"<br>
Example: </span><code><span style="font-size:10pt">confidence = value=80, pdf=unknown</span></code><span style="font-size:10.5pt;font-family:Helvetica,sans-serif"><br>
If no </span><code><span style="font-size:10pt">confidence</span></code><span style="font-size:10.5pt;font-family:Helvetica,sans-serif"> parameter is specified, the default is 95%.<br>
See <a href="https://wiki.asterisk.org/wiki/display/AST/Geolocation+Reference+Information#GeolocationReferenceInformation-rfc7459" target="_blank"><span style="color:rgb(25,46,132)">RFC7459</span></a> for the exact definition of this parameter.</span><u></u><u></u></li></ul>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">[08/02 09:30:03.724] ERROR[682944] config_options.c: Could not find option suitable for category 'IS_loc_1' named 'confidence' at line 12 of<u></u><u></u></p>
<p class="MsoNormal">[08/02 09:30:03.724] ERROR[682944] res_sorcery_config.c: Could not create an object of type 'location' with id 'IS_loc_1' from configuration file 'geolocation.conf'<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">[IS_loc_1]<u></u><u></u></p>
<p class="MsoNormal">type = location<u></u><u></u></p>
<p class="MsoNormal">format = civicAddress<u></u><u></u></p>
<p class="MsoNormal">confidence = value=95, pdf=unknown<u></u><u></u></p>
<p class="MsoNormal">location_info = country=US,A1=Wisconsin,A3=Madison<u></u><u></u></p>
<p class="MsoNormal">location_info = HNO=4800,RD=Main,STS=Drive,PC=53704<u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Remove the confidence param for now. I documented it before I implemented it. :)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Also seeing problems with location_refinement setting.<u></u><u></u></p>
<p class="MsoNormal">Again, I believe my setting matches what is on the Asterisk Geolocation Implementation wiki.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">[08/02 09:30:03.724] ERROR[682944] config_options.c: Could not find option suitable for category 'IS_prof_20' named 'location_refinement' at line 56 of<u></u><u></u></p>
<p class="MsoNormal">[08/02 09:30:03.724] ERROR[682944] res_sorcery_config.c: Could not create an object of type 'profile' with id 'IS_prof_20' from configuration file 'geolocation.conf'<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">[IS_prof_20]<u></u><u></u></p>
<p class="MsoNormal">type = profile<u></u><u></u></p>
<p class="MsoNormal">profile_action = prefer_incoming<u></u><u></u></p>
<p class="MsoNormal">pidf_element = person<u></u><u></u></p>
<p class="MsoNormal">usage_rules = retransmission_allowed=no<u></u><u></u></p>
<p class="MsoNormal">location_reference = IS_loc_22<u></u><u></u></p>
</div>
</div>
</blockquote>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div>
<p class="MsoNormal">location_refinement = ROOM=292<u></u><u></u></p>
<p class="MsoNormal">location_refinement = FLR=1<u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Pffft. I renamed this to "location_info_refinement" to better match the "location_info" parameter in the Location object. I forgot to rename it in the wiki documentation. If
you just change the name it should work.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Dan<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal">--
<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">
http://www.api-digital.com</a> --<br>
<br>
Check out the new Asterisk community forum at: <a href="https://community.asterisk.org/" target="_blank">
https://community.asterisk.org/</a><br>
<br>
New to Asterisk? Start here:<br>
<a href="https://wiki.asterisk.org/wiki/display/AST/Getting+Started" target="_blank">
https://wiki.asterisk.org/wiki/display/AST/Getting+Started</a><br>
<br>
asterisk-users mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-users" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-users</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
<p class="MsoNormal">-- <br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">
http://www.api-digital.com</a> --<br>
<br>
Check out the new Asterisk community forum at: <a href="https://community.asterisk.org/" target="_blank">
https://community.asterisk.org/</a><br>
<br>
New to Asterisk? Start here:<br>
<a href="https://wiki.asterisk.org/wiki/display/AST/Getting+Started" target="_blank">
https://wiki.asterisk.org/wiki/display/AST/Getting+Started</a><br>
<br>
asterisk-users mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-users" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-users</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
-- <br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br>
<br>
Check out the new Asterisk community forum at: <a href="https://community.asterisk.org/" rel="noreferrer" target="_blank">https://community.asterisk.org/</a><br>
<br>
New to Asterisk? Start here:<br>
<a href="https://wiki.asterisk.org/wiki/display/AST/Getting+Started" rel="noreferrer" target="_blank">https://wiki.asterisk.org/wiki/display/AST/Getting+Started</a><br>
<br>
asterisk-users mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-users" rel="noreferrer" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-users</a></blockquote></div></div>
</blockquote></div>