<div dir="ltr">Thank you very much Steve. Thanks for the in detail recommendations. I will make modifications and let you know. <div><br></div><div><br><div class="gmail_quote">On Sat, May 5, 2012 at 9:22 PM, Steve Edwards <span dir="ltr"><<a href="mailto:asterisk.org@sedwards.com" target="_blank">asterisk.org@sedwards.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Sat, 5 May 2012, ABBAS SHAKEEL wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I wrote this article for making the things easy for newbies Please have a look and let me know if you suggest some thing.<br>
</blockquote>
<br>
</div><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Please have a look and suggest changes<br>
<a href="http://younewplanet.com/index.php/articles/2012-articles-2/asterisk-configuration-step-by-step" target="_blank">http://younewplanet.com/<u></u>index.php/articles/2012-<u></u>articles-2/asterisk-<u></u>configuration-step-by-step</a><br>
</blockquote>
<br></div>
1) I don't see anything in the article that requires 'at least university level programming experience.'<br>
<br>
2) Using shading and colors to highlight 'code' makes the article hard to read and I suspect printing may render it useless. How about if you offset the code sections using font (which you already do), indentation, and consistent application of whitespace between code and text?<br>
<br>
3) Did you intend to install most of the prerequisite packages with '-v' instead of '-y?'<br>
<br>
4) You should be consistent in your choice of font and font attributes in your text.<br>
<br>
5) You should 'proof' your article for consistent and correct whitespace and capitalization.<br>
<br>
6) You should have your article read by someone whose primary language is English. I commend you for doing a better job than I could in any language other that English, but the article does not 'read' well.<br>
<br>
7) The inclusion of a loop-back connector is a nice touch.<br>
<br>
8) In the 'Sound Files Conversion and Usage' section, you say 'Wav (this is not the wav files that we play in windows it have a different compression).'<br>
<br>
I think you are referring to WAV49. The WAV files I use ('RIFF (little-endian) data, WAVE audio, Microsoft PCM, 16 bit, mono 8000 Hz') play fine on Windows and Linux. If I remember correctly, WAV49 uses GSM which confuses most Windows sound programs.<br>
<br>
9) In the shell snippet to convert sound files, you use backticks to substitute the file type. This method creates 3 processes. You can accomplish this using shell parameter expansion without creating any additional processes. For example<br>
<br>
sox "$a" "${a%.wav}.sln"<br>
<br>
Note that this method will not be confused by a file named 'test.wav.wav' either.<br>
<br>
10) You should present your 'Abbreviations' section in alphabetical order.<br>
<br>
I did not attempt to review most of the article for technical merit. I suspect the inclusion of Java AGIs and storing CDRs in a database are outside the interest of 'newbies' and warrant articles of their own.<span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
Thanks in advance,<br>
------------------------------<u></u>------------------------------<u></u>-------------<br>
Steve Edwards <a href="mailto:sedwards@sedwards.com" target="_blank">sedwards@sedwards.com</a> Voice: <a href="tel:%2B1-760-468-3867" value="+17604683867" target="_blank">+1-760-468-3867</a> PST<br>
Newline Fax: <a href="tel:%2B1-760-731-3000" value="+17607313000" target="_blank">+1-760-731-3000</a></font></span><br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
New to Asterisk? Join us for a live introductory webinar every Thurs:<br>
<a href="http://www.asterisk.org/hello" target="_blank">http://www.asterisk.org/hello</a><br>
<br>
asterisk-users mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-users" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-users</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Best Regards<br>
Shakeel Abbas<br><br>
</div></div>