[asterisk-users] Finding old patches

[Joshua C. Colp]

On Mon, Nov 20, 2023 at 1:45 PM Dovid Bender <dovid at telecurve.com> wrote:

> Hi,
>
> In the past when I wanted to back port a patch I would go on to the issue
> tracker and find a link to the patches that were uploaded ( I think
> through gerrit?). I am trying to see what changes were done for
> https://issues-archive.asterisk.org/ASTERISK-26109. It seems the code
> changes were introduced in 14.4.0-rc1. Is there any "n00b" way of seeing
> what patches were created for this specific issue?
>

The git commit history can be used, the commit message can be grepped,
example:

✔ jcolp at kappa:~/development/asterisk/github [21| …2⚑ 3]> git log | grep -B4
"OpenSSL 1.1.0 support"
Merge: a0c0b1c9cb 26c8552fff
Author: zuul <zuul at gerrit.asterisk.org>
Date:   Wed Nov 30 23:26:46 2016 -0600

    Merge "OpenSSL 1.1.0 support"
--
commit 26c8552fff499419bdf12b663e76ecfc408b3085
Author: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Date:   Tue Jun 28 23:26:59 2016 +0200

    OpenSSL 1.1.0 support

So the commit is "26c8552fff499419bdf12b663e76ecfc408b3085" and you can use
git show to display that commit, which includes the changes including in
diff format:

✔ jcolp at kappa:~/development/asterisk/github [21| …2⚑ 3]> git show 26c8552fff
commit 26c8552fff499419bdf12b663e76ecfc408b3085
Author: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Date:   Tue Jun 28 23:26:59 2016 +0200

    OpenSSL 1.1.0 support

    OpenSSL 1.1.0 includes some major changes in the interface. See
    https://wiki.openssl.org/index.php/1.1_API_Changes .

    Status: Right now there are still a few deprecation notes with OpenSSL
    1.1.0. But it's a start.

    Changes:
    * CRYPTO_LOCK is no longer available. Replace it with its value for now.
      I don't completely understand what it is used for there.
    * Remove several functions from libasteriskssl that seem to no longer be
      needed.
    * Structures have become opaque and are accesses with accessors.
    * ERR_remove_thread_state() no longer needed.
    * SSLv2 code now could no longer be used in 1.1.

    ASTERISK-26109 #close

    Change-Id: I5e29d477d486ca29b6aae0dc2f5dff960c1cb82b

diff --git a/main/iostream.c b/main/iostream.c

The same goes for the rest of the associated commits on the linked issue.

-- 
Joshua C. Colp
Asterisk Project Lead
Sangoma Technologies
Check us out at www.sangoma.com and www.asterisk.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-users/attachments/20231120/97fdbf06/attachment.html>