[asterisk-users] fromdomain not honored on outbound INVITE request

[Joshua Colp]

Thomas Rechberger wrote:
> meanwhile i got an answer from fprior who was testing patch already.
>
> add this code to chan_sip.c :
>
> /* Allow domain to be overridden */
> if (!ast_strlen_zero(p->fromdomain))
> d = p->fromdomain;
> else /* Save for any further attempts */
> ast_string_field_set(p, fromdomain, d);
>
> after this one (approx. at line 13741)
> /* Allow user to be overridden */
> if (!ast_strlen_zero(p->fromuser))
> l = p->fromuser;
> else /* Save for any further attempts */
> ast_string_field_set(p, fromuser, l);
>
> on 11.x it should after fromname section, but i guess wont matter.
> Will test this soon.
> The code is really that simple, is it really needed to have it signed
> from the author?

Modified fix is in all branches 1.8 and up. Just to give a glimpse into 
what I did:

1. Went back into past versions of Asterisk to see how long stuff has 
been this way
2. Looked to see if it was left out on purpose
3. Thought about the real world implications
4. Looked over required change
5. Committed to all branches

Cheers,

-- 
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org