[asterisk-users] Silencing VoiceMail() app in * 1.4.10

Atis Lezdins atis at iq-labs.net
Sun Mar 9 14:49:34 CDT 2008


On 3/9/08, Godwin Stewart Horwich IT Services <g.stewart at horwits.co.uk> wrote:
> On Sun, 9 Mar 2008 16:22:35 +0200, "Atis Lezdins" <atis at iq-labs.net> wrote:
>
>  > I think that giving 's' argument should silence all prompts including
>  > auth-thankyou. You should report a bug on http://bugs.digium.com ,
>  > fixing this should be trivial.
>
>
> It isn't that trivial.
>
>  I've looked at the source and the "silent" flag is not passed all the way
>  down the chain to the function that actually does the recording.
>
>  In apps/app_voicemail.c, the option is parsed by vm_exec() and passed on to
>  leave_voicemail().
>
>  leave_voicemail(), however, doesn't pass it down to play_record_review().
>  So by the time the call stack goes through ast_play_and_record_full() and
>  __ast_play_and_record() in main/app.c, where we see the foillowing code,
>  the status of the "silent" option is long lost:
>
>  if (outmsg == 2) {
>         ast_stream_and_wait(chan, "auth-thankyou", chan->language,"");
>  }
>
>  I will, however, work on a patch to pass the silent option down the chain
>  to this function, but it's going to mean a major overhaul.

Maybe you should ask for best way for this in asterisk-dev. I checked
wat you're saying and it seems to me that more logical would be to
play "auth-thankyou" in application, not __ast_play_and_record(), but
it may break some concept.

Regards,
Atis
-- 
Atis Lezdins,
VoIP Project Manager / Developer,
atis at iq-labs.net
Skype: atis.lezdins
Cell Phone: +371 28806004
Cell Phone: +1 800 7300689
Work phone: +1 800 7502835



More information about the asterisk-users mailing list