[Asterisk-Users] How do i make best use of Macro?

[Mark Spencer]

data should be considered a "const void *" in all honesty (maybe i should
enforce it).   Always copy to a local buffer before strseping it.

mark

On Wed, 11 Jun 2003, Steven Critchfield wrote:

> Since there was some interest in this, here is the diff against current
> cvs. Someone that is better at C should look into my use of strsep
> because there is a couple of warnings. Also there is a warning on my use
> of pbx_builtin_setvar_helper, but I can't see whats wrong here.
>
> BTW, SayNumber doesn't seem to say '0'.
>
> Usage is like this.
>
> exten => 1234,1,MeetMeCount(1234|var)
> exten => 1234,2,SayNumber(${var})
> exten => 1234,3,MeetMe(1234)
>
> ---------------------------------------------------------------------------------
>
>
> diff -U3 -r asterisk-orig/apps/app_meetme.c asterisk/apps/app_meetme.c
> --- asterisk-orig/apps/app_meetme.c     2003-06-11 23:14:38.000000000 -0500
> +++ asterisk/apps/app_meetme.c  2003-06-11 22:58:32.000000000 -0500
> @@ -54,9 +54,10 @@
>  "      'q' -- quiet mode (don't play enter/leave sounds)\n";
>
>  static char *descrip2 =
> -"  MeetMeCount(confno): Plays back the number of users in the specified MeetMe\n"
> -"conference.  Returns 0 on success or -1 on a hangup.  A ZAPTEL INTERFACE\n"
> -"MUST BE INSTALLED FOR CONFERENCING FUNCTIONALITY.\n";
> +"  MeetMeCount(confno[|var]): Plays back the number of users in the specifiedi\n"
> +"MeetMe conference. If var is specified, playback will be skipped and the value\n"
> +"will be returned in the variable. Returns 0 on success or -1 on a hangup.\n"
> +"A ZAPTEL INTERFACE MUST BE INSTALLED FOR CONFERENCING FUNCTIONALITY.\n";
>
>  STANDARD_LOCAL_USER;
>
> @@ -465,19 +466,29 @@
>         int res = 0;
>         struct conf *conf;
>         int cnt;
> +       char* confnum;
> +       char val[5] = "0"; /* I don't think we will ever get 99,999 callers into a single meetme */
> +
>         if (!data || !strlen(data)) {
>                 ast_log(LOG_WARNING, "MeetMeCount requires an argument (conference number)\n");
>                 return -1;
>         }
>         LOCAL_USER_ADD(u);
> -       conf = find_conf(data, 0);
> +       confnum = strsep((char*) &data,"|");
> +       conf = find_conf(confnum, 0);
>         if (conf)
>                 cnt = conf->users;
>         else
>                 cnt = 0;
> -       if (chan->_state != AST_STATE_UP)
> -               ast_answer(chan);
> -       res = ast_say_number(chan, cnt, "", chan->language);
> +       if(strlen(data)){
> +               /* have var so load it and exit */
> +               sprintf(val,"%i",cnt);
> +               pbx_builtin_setvar_helper(chan,(char*) data,&val);
> +       }else{
> +               if (chan->_state != AST_STATE_UP)
> +                       ast_answer(chan);
> +               res = ast_say_number(chan, cnt, "", chan->language);
> +       }
>         LOCAL_USER_REMOVE(u);
>         return res;
>  }
>
>
> --
> Steven Critchfield <critch at basesys.com>
>
> _______________________________________________
> Asterisk-Users mailing list
> Asterisk-Users at lists.digium.com
> http://lists.digium.com/mailman/listinfo/asterisk-users
>