[asterisk-security] [asterisk-dev] [Code Review] Add parking extension for non-default parking lots

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/884/#review2656
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/884/#comment5819>

    You have this patch against trunk, but you put the CHANGES entry in the new features for 1.8 section.  That's fine with me, since I actually think you should put this into the 1.8 branch, as well since it's still in beta.  I just wanted to be clear about which branches this patch is going into.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/884/#comment5821>

    there's some excessive indentation here



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/884/#comment5820>

    I'm not sure how I feel about this API call.  I don't think it is provided enough information to provide an accurate result of whether or not the parking extension is valid.
    
    Wouldn't the validity of the parking extension depend on which parking lot is in use?



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/884/#comment5822>

    don't forget to destroy the iterator


- Russell


On 2010-09-01 14:10:51, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/884/
> -----------------------------------------------------------
> 
> (Updated 2010-09-01 14:10:51)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I think the summary says all here, this was just something that wasn't implemented when multiparking was added.
> 
> 
> This addresses bug 14882.
>     https://issues.asterisk.org/view.php?id=14882
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 284482 
>   /trunk/channels/chan_dahdi.c 284482 
>   /trunk/channels/chan_iax2.c 284482 
>   /trunk/channels/chan_mgcp.c 284482 
>   /trunk/channels/chan_sip.c 284482 
>   /trunk/channels/sig_analog.c 284482 
>   /trunk/channels/sip/include/sip.h 284482 
>   /trunk/configs/features.conf.sample 284482 
>   /trunk/configure UNKNOWN 
>   /trunk/include/asterisk/features.h 284482 
>   /trunk/main/features.c 284482 
> 
> Diff: https://reviewboard.asterisk.org/r/884/diff
> 
> 
> Testing
> -------
> 
> I tested as I went and ran all of our parking tests.
> 
> 
> Thanks,
> 
> Jeff
> 
>


-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev