<html>
<head>
<base href="https://wiki.asterisk.org/wiki">
<link rel="stylesheet" href="/wiki/s/en/2171/18/9/_/styles/combined.css?spaceKey=TOP&forWysiwyg=true" type="text/css">
</head>
<body style="background: white;" bgcolor="white" class="email-body">
<div id="pageContent">
<div id="notificationFormat">
<div class="wiki-content">
<div class="email">
<h2><a href="https://wiki.asterisk.org/wiki/display/TOP/Generic+Session+Manager+Design">Generic Session Manager Design</a></h2>
<h4>Comment <b>removed</b> by <a href="https://wiki.asterisk.org/wiki/display/~khunt">Ken Hunt</a>
</h4>
<br/>
<div class="notificationGreySide">
<ol>
<li>It appears your "composition" / "aggregation" lines are all backwards. The diamond goes on the end of the container.</li>
<li>I'm not crazy about IceUtil::Time being in our public interface. (The scalable time design uses it only as a private member). But I don't have a great alternative to propose, so perhaps I'll shut up about it. (Perhaps our Time package should provide a Timestamp class.)</li>
<li>You aren't actually going to put the suffix Prx on those Endpoint member variables are you? If the type is <type>Prx, isn't that enough? I guess I could go either way on this one... just curious.</li>
<li>suspend() / unsuspend() - Should these be part of a general Service interface? Same perhaps for shutdown?</li>
<li>The UML model has another package between Asterisk SCF and Channel... namely Telephony. If you don't like that, we should discuss. I think there needs to be a package there... just not sure Telephony is the best name.</li>
</ol>
</div>
<div id="commentsSection" class="wiki-content pageSection">
<div style="float: right;" class="grey">
<a href="https://wiki.asterisk.org/wiki/users/removespacenotification.action?spaceKey=TOP">Stop watching space</a>
<span style="padding: 0px 5px;">|</span>
<a href="https://wiki.asterisk.org/wiki/users/editmyemailsettings.action">Change email notification preferences</a>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>