<html>
<head>
<base href="https://wiki.asterisk.org/wiki">
<link rel="stylesheet" href="/wiki/s/en/2171/18/9/_/styles/combined.css?spaceKey=TOP&forWysiwyg=true" type="text/css">
</head>
<body style="background: white;" bgcolor="white" class="email-body">
<div id="pageContent">
<div id="notificationFormat">
<div class="wiki-content">
<div class="email">
<h2><a href="https://wiki.asterisk.org/wiki/display/TOP/Generic+Session+Manager+Design">Generic Session Manager Design</a></h2>
<h4>Comment <b>removed</b> by <a href="https://wiki.asterisk.org/wiki/display/~khunt">Ken Hunt</a>
</h4>
<br/>
<div class="notificationGreySide">
<p>This looks good, but I do have some questions and comments.</p>
<p>1. Why does ChannelService inherit from SignalCommand and SignalCallback?<br/>
2. What is SessionInfo::role?<br/>
3. SessionInfo seems to be a bit restrictive regarding the number of endpoints involved. It has only a caller and destination endpoint ID. How would calls with more than two endpoints be handled?<br/>
4. I noticed Josh's comment regarding caller ID, but I don't see any representation of it in the current channel service diagram. To me, even if you don't have an idea of how the caller ID will be structured, it needs to be stored as part of the Endpoint. Furthermore, some facility, perhaps the Endpoint itself, should be able to provide the caller ID for a particular endpoint given its endpoint ID. This way, an operation such as ChannelService::listCurrentSessions() could provide identification information for the endpoints involved and would only have to have the endpoint ID stored.</p>
<p>That's all I have for now. Good work on this!</p>
</div>
<div id="commentsSection" class="wiki-content pageSection">
<div style="float: right;" class="grey">
<a href="https://wiki.asterisk.org/wiki/users/removespacenotification.action?spaceKey=TOP">Stop watching space</a>
<span style="padding: 0px 5px;">|</span>
<a href="https://wiki.asterisk.org/wiki/users/editmyemailsettings.action">Change email notification preferences</a>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>