[asterisk-scf-commits] asterisk-scf/integration/routing.git branch "disintegrated-build" created.
Commits to the Asterisk SCF project code repositories
asterisk-scf-commits at lists.digium.com
Thu Jun 16 17:22:38 CDT 2011
branch "disintegrated-build" has been created
at c2bab77760af5babe63247d737d8b4a48dcbd043 (commit)
- Log -----------------------------------------------------------------
commit c2bab77760af5babe63247d737d8b4a48dcbd043
Merge: 462facc 0f67d36
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Thu Jun 16 17:16:57 2011 -0500
Merge branch 'disintegrated-build' of git://git.asterisk.org/team/kpfleming/wip-cmake into disintegrated-build
diff --cc cmake/modules/cmake_uninstall.cmake.in
index 0000000,9b093d4..9b093d4
mode 000000,100644..100644
--- a/cmake/modules/cmake_uninstall.cmake.in
+++ b/cmake/modules/cmake_uninstall.cmake.in
commit 0f67d364f49cfb4e0c8351a37de7035ca1cb84e5
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Thu Jun 16 17:09:43 2011 -0500
Provide ability to automatically translate Slice files when needed.
When a Slice file is added to a component (to be translated and compiled),
other Slice files that it is dependent on may also need to be added to the
component. This patch adds automatic addition of dependency Slice files. See
the documentation for astscf_component_add_slices() to understand when this
function is performed and why.
diff --git a/AsteriskSCF.cmake b/AsteriskSCF.cmake
index 8887518..d83d3f6 100644
--- a/AsteriskSCF.cmake
+++ b/AsteriskSCF.cmake
@@ -322,7 +322,7 @@ function(astscf_project NAME ICE_VERSION)
# every component against those libraries at minimum
set(ASTSCF_ICE_LIBRARIES ICE ICEUTIL PARENT_SCOPE)
- astscf_slice_collection(GLOBAL NAME Ice PATH "${ICE_SLICE_DIR}" HEADERS "${ICE_INCLUDE_DIR}")
+ astscf_slice_collection(GLOBAL NOTRANSLATE NAME Ice PATH "${ICE_SLICE_DIR}" HEADERS "${ICE_INCLUDE_DIR}")
astscf_slice_include_collection(Ice)
set(SLICE_INCLUDE_DIRECTORIES ${SLICE_INCLUDE_DIRECTORIES} PARENT_SCOPE)
@@ -508,20 +508,25 @@ endfunction()
# collection's details.
#
# Syntax:
-# astscf_slice_collection([OVERRIDE] [GLOBAL NAME <name> | LOCAL]
+# astscf_slice_collection([OVERRIDE] [GLOBAL NAME <name> | LOCAL] [TRANSLATE | NOTRANSLATE]
# [PATH <path>] [LIBRARY <library] [HEADERS <path>])
#
# GLOBAL: defines a global collection; NAME is mandatory
# LOCAL: (default) defines a local collection; NAME will be 'LOCAL'
# OVERRIDE: must be specified in order to change PATH, LIBRARY or HEADERS
# for a previously-defined global collection
+# TRANSLATE: (default, unless the collection provides a library) Slice files
+# in this collection should be translated into header/source files
+# when used in a component
+# NOTRANSLATE: (default if the collection provides a library) Slice files in
+# this collection should not be translated
# NAME: name of the collection
# PATH: path to the directory where the Slice files are located
# HEADERS: path to the directory where Slice-generated headers are located
# LIBRARY: path or target name of a library built from Slice-generated sources
#
function(astscf_slice_collection)
- cmake_parse_arguments("" "OVERRIDE;GLOBAL;LOCAL" "NAME;PATH;LIBRARY;HEADERS" "" ${ARGN})
+ cmake_parse_arguments("" "OVERRIDE;GLOBAL;LOCAL;TRANSLATE;NOTRANSLATE" "NAME;PATH;LIBRARY;HEADERS" "" ${ARGN})
if(_GLOBAL AND NOT _NAME)
message(FATAL_ERROR "NAME argument to this function is mandatory for global Slice collections.")
endif()
@@ -547,6 +552,9 @@ function(astscf_slice_collection)
message(FATAL_ERROR "PATH argument to this function is mandatory.")
endif()
if(_GLOBAL)
+ list(APPEND collections ${_NAME} ${SLICE_GLOBAL_COLLECTIONS})
+ list(REMOVE_DUPLICATES collections)
+ __astscf_set_cache_string(SLICE_GLOBAL_COLLECTIONS "${collections}" "" ADVANCED)
if(_PATH)
__astscf_set_cache_path(SLICE_COLLECTION_${_NAME} "${real}" "Path to Slice files in collection ${_NAME}.")
endif()
@@ -556,6 +564,11 @@ function(astscf_slice_collection)
if(_HEADERS)
__astscf_set_cache_path(SLICE_COLLECTION_${_NAME}_HEADERS "${_HEADERS}" "Path to generated headers for Slice collection ${_NAME}.")
endif()
+ if(_NOTRANSLATE OR SLICE_COLLECTION_${_NAME}_LIBRARY)
+ __astscf_set_cache_string(SLICE_COLLECTION_${_NAME}_TRANSLATE "false" "" ADVANCED)
+ else()
+ __astscf_set_cache_string(SLICE_COLLECTION_${_NAME}_TRANSLATE "true" "" ADVANCED)
+ endif()
message(STATUS "Added Slice collection '${_NAME}' at ${_PATH}")
else()
if(_PATH)
@@ -621,7 +634,12 @@ endfunction()
# Function which records Slice files, from a collection, as being used by a
# component. The Slice files will be translated and compiled when the component
-# is built.
+# is built. In addition, any Slice files that the specified files are dependent
+# on (via #include) that come from Slice collections which don't provide
+# libraries (or have been marked explicitly as needing translation) will also be
+# added to the component automatically. This will also occur for any Slice files
+# from the same collection as the specified files, even if that collection does
+# provide a library or has not been marked as needing translation.
#
# The Slice files are passed in as a list of globs, relative to the collection's
# base directory. The globs default to regular non-recursive expansion. If you
@@ -664,7 +682,10 @@ function(astscf_component_add_slices COMPONENT COLLECTION)
endif()
endif()
+ __astscf_slice_compiler_arguments(slice_compiler_arguments)
+
set(collection_dir "${SLICE_COLLECTION_${COLLECTION}}")
+ set(collections ${${COMPONENT}_SLICE_COLLECTIONS})
# default to glob syntax by default. not as useful as GLOB_RECURSE, but
# follows the principle of least surprise
set(glob_style GLOB)
@@ -678,70 +699,74 @@ function(astscf_component_add_slices COMPONENT COLLECTION)
if(NOT slices)
message(FATAL_ERROR "Pattern '${slice_glob}' did not match any files in ${collection_dir}.")
endif()
- if(NOT found)
- set(collections ${${COMPONENT}_SLICE_COLLECTIONS})
+ # if the component isn't already using any Slice files from this collection,
+ # record this collection in the list
+ list(FIND collections ${COLLECTION} index)
+ if(index EQUAL -1)
list(APPEND collections ${COLLECTION})
- list(REMOVE_DUPLICATES collections)
- __astscf_set_cache_string(${COMPONENT}_SLICE_COLLECTIONS "${collections}" "" ADVANCED)
endif()
- set(found true)
- list(APPEND all_slices ${slices})
+ foreach(slice ${slices})
+ message(STATUS "Adding ${slice} from collection ${COLLECTION} to ${COMPONENT}")
+ endforeach()
+ list(APPEND new_slices ${slices})
endif()
endforeach()
- list(APPEND all_slices ${${COMPONENT}_${COLLECTION}_SLICES})
+ list(APPEND all_slices ${${COMPONENT}_${COLLECTION}_SLICES} ${new_slices})
list(REMOVE_DUPLICATES all_slices)
__astscf_set_cache_string(${COMPONENT}_${COLLECTION}_SLICES "${all_slices}" "" ADVANCED)
+ # now use the Slice compiler to find Slice files that the ones that were just added are dependent on
+ foreach(slice ${new_slices})
+ __astscf_slice_get_targets_and_sources(${COLLECTION} "${collection_dir}" "${slice}" "${slice_compiler_arguments}" targets sources)
+ foreach(source ${sources})
+ # check to see if a dependency Slice file is located in a known collection; if so, then
+ # it might also need to be added to this component
+ foreach(collection ${SLICE_GLOBAL_COLLECTIONS} PROJECT LOCAL)
+ # the dependency file should be also be added to this component (to be translated)
+ # if the collection it comes from is marked to cause translation, *or* if it
+ # comes from the same collection as the one which is dependent on it
+ if(SLICE_COLLECTION_${collection}_TRANSLATE OR (collection STREQUAL COLLECTION))
+ # check the initial parts of the path to the dependency file against the collection's
+ # Slice file directory path
+ if(SLICE_COLLECTION_${collection} AND ("${source}" MATCHES "${SLICE_COLLECTION_${collection}}/(.+)"))
+ list(FIND ${COMPONENT}_${collection}_SLICES ${CMAKE_MATCH_1} index)
+ if(index EQUAL -1)
+ message(STATUS "Auto-adding ${CMAKE_MATCH_1} from collection ${collection} to ${COMPONENT}")
+ # if the component isn't already using any Slice files from this collection,
+ # record this collection in the list
+ list(FIND collections ${collection} index)
+ if(index EQUAL -1)
+ list(APPEND collections ${collection})
+ endif()
+ list(APPEND new_slices_${collection} ${CMAKE_MATCH_1})
+ endif()
+ endif()
+ endif()
+ endforeach()
+ endforeach()
+ endforeach()
+ # now append all the auto-discovered Slice files to the appropriate lists for this component
+ foreach(collection ${SLICE_GLOBAL_COLLECTIONS} PROJECT LOCAL)
+ if(new_slices_${collection})
+ unset(all_slices)
+ list(APPEND all_slices ${${COMPONENT}_${collection}_SLICES} ${new_slices_${collection}})
+ list(REMOVE_DUPLICATES all_slices)
+ __astscf_set_cache_string(${COMPONENT}_${collection}_SLICES "${all_slices}" "" ADVANCED)
+ endif()
+ endforeach()
+ list(REMOVE_DUPLICATES collections)
+ __astscf_set_cache_string(${COMPONENT}_SLICE_COLLECTIONS "${collections}" "" ADVANCED)
endfunction()
-# Function which add a Slice file to a component. This handles all the magic of
-# creating the rules to run slice2cpp, adding the generated headers to the
-# include path, adding the generated .cpp file to the component, etc. The
-# generated files are placed in ${CMAKE_CURRENT_BINARY_DIR}/slice-<collection>.
+# Function which uses the Slice translator to discover the files that a particular Slice
+# file depends on, and the files the translator would generate from that Slice file. The
+# TARGETS argument specifies the name of a variable that will receive the list of generated
+# files; the SOURCES argument specifies the name of a variable that will receive the list
+# of dependency files.
#
-function(__astscf_component_add_one_slice COMPONENT COLLECTION COLLECTION_DIR SLICE)
- # Append the needed include directories for Slice definitions
- foreach(include ${SLICE_INCLUDE_DIRECTORIES})
- list(APPEND slice_compiler_arguments "-I${include}")
- endforeach()
-
- # Set some common Slice translator options:
- # - generate support for the Ice streaming interface
- # - generate checksums for definitions
- # - allow underscores to be used in identifiers
- list(APPEND slice_compiler_arguments "--stream" "--checksum" "--underscore")
-
- # If any Slice plugins are to be used, include them in the
- # compiler arguments
- if(SLICE_PLUGINS)
- foreach(plugin ${SLICE_PLUGINS})
- list(APPEND slice_compiler_arguments "--plugin=${plugin}")
- endforeach()
- endif()
-
- get_filename_component(slice_basename "${SLICE}" NAME_WE)
- get_filename_component(slice_subdir "${SLICE}" PATH)
-
- message(STATUS "Adding ${SLICE} from collection ${COLLECTION} to ${COMPONENT}")
- # compute the directory in which to put the generated code and header files
- set(slice_out_collection_dir "${CMAKE_CURRENT_BINARY_DIR}/${COMPONENT}/slice-${COLLECTION}")
- if(slice_subdir)
- set(slice_out_file_dir "${slice_out_collection_dir}/${slice_subdir}")
- else()
- set(slice_out_file_dir "${slice_out_collection_dir}")
- endif()
- # header files that refer to the one generated from this Slice file
- # will try to find it from the base of the collection, so add that
- # directory to the include path
- include_directories(SYSTEM "${slice_out_collection_dir}")
- # the C++ source file generated from this Slice file will try to find
- # the generated header in the same directory as the source, so add
- # the file's immediate directory to the include path as well
- include_directories(SYSTEM "${slice_out_file_dir}")
-
- # Determine this Slice file's dependencies
- message(STATUS "Determining dependencies for ${SLICE}")
+function(__astscf_slice_get_targets_and_sources COLLECTION COLLECTION_DIR SLICE COMPILER_ARGS TARGETS SOURCES)
+ message(STATUS "Determining dependencies for ${SLICE} from ${COLLECTION}")
execute_process(
- COMMAND ${SLICE_COMPILER} ${slice_compiler_arguments} --depend ${COLLECTION_DIR}/${SLICE}
+ COMMAND ${SLICE_COMPILER} ${COMPILER_ARGS} --depend ${COLLECTION_DIR}/${SLICE}
OUTPUT_VARIABLE raw_dependencies
ERROR_VARIABLE slice_errors)
if(slice_errors)
@@ -772,23 +797,41 @@ function(__astscf_component_add_one_slice COMPONENT COLLECTION COLLECTION_DIR SL
list(APPEND expsources ${dep_sources})
endforeach()
endif()
-
foreach(source ${expsources})
# put the spaces back in.
string(REPLACE "%20%" " " source ${source})
list(APPEND sources ${source})
endforeach()
- # prepend the slice_out_dir to the targets
- foreach(target ${targets})
- list(APPEND generated_files "${slice_out_file_dir}/${target}")
+ if(targets)
+ get_filename_component(slice_basename "${SLICE}" NAME_WE)
+ list(APPEND targets "${slice_basename}.h")
+ list(REMOVE_DUPLICATES targets)
+ list(SORT targets)
+ set(${TARGETS} ${targets} PARENT_SCOPE)
+ endif()
+
+ if(sources)
+ list(SORT sources)
+ set(${SOURCES} ${sources} PARENT_SCOPE)
+ endif()
+endfunction()
+
+# Function which collects together all the arguments that should be specified
+# to the Slice compiler, if it is to be executed in the current scope. The list of
+# arguments is stored in the variable named in the ARGUMENTS argument.
+#
+function(__astscf_slice_compiler_arguments ARGUMENTS)
+ # Append the needed include directories for Slice definitions
+ foreach(include ${SLICE_INCLUDE_DIRECTORIES})
+ list(APPEND slice_compiler_arguments "-I${include}")
endforeach()
- # you would think that would be enough, but slice2cpp doesn't generate a
- # dep for the .h file
- list(APPEND generated_files "${slice_out_file_dir}/${slice_basename}.h")
- # and be resilient in case it does so in the future...
- list(REMOVE_DUPLICATES generated_files)
- set_source_files_properties(${generated_files} PROPERTIES GENERATED 1)
+
+ # Set some common Slice translator options:
+ # - generate support for the Ice streaming interface
+ # - generate checksums for definitions
+ # - allow underscores to be used in identifiers
+ list(APPEND slice_compiler_arguments "--stream" "--checksum" "--underscore")
# create a preprocessor definition in the generated CXX files that enables
# the generated classes to be exported from the library (only necessary on
@@ -797,6 +840,53 @@ function(__astscf_component_add_one_slice COMPONENT COLLECTION COLLECTION_DIR SL
list(APPEND slice_compiler_arguments "--dll-export" "ASTSCF_DLL_EXPORT")
endif()
+ # If any Slice plugins are to be used, include them in the
+ # compiler arguments
+ if(SLICE_PLUGINS)
+ foreach(plugin ${SLICE_PLUGINS})
+ list(APPEND slice_compiler_arguments "--plugin=${plugin}")
+ endforeach()
+ endif()
+
+ set(${ARGUMENTS} ${slice_compiler_arguments} PARENT_SCOPE)
+endfunction()
+
+# Function which add a Slice file to a component. This handles all the magic of
+# creating the rules to run slice2cpp, adding the generated headers to the
+# include path, adding the generated .cpp file to the component, etc. The
+# generated files are placed in ${CMAKE_CURRENT_BINARY_DIR}/slice-<collection>.
+#
+function(__astscf_component_add_one_slice COMPONENT COLLECTION COLLECTION_DIR SLICE)
+ __astscf_slice_compiler_arguments(slice_compiler_arguments)
+
+ get_filename_component(slice_basename "${SLICE}" NAME_WE)
+ get_filename_component(slice_subdir "${SLICE}" PATH)
+
+ # compute the directory in which to put the generated code and header files
+ set(slice_out_collection_dir "${CMAKE_CURRENT_BINARY_DIR}/${COMPONENT}/slice-${COLLECTION}")
+ if(slice_subdir)
+ set(slice_out_file_dir "${slice_out_collection_dir}/${slice_subdir}")
+ else()
+ set(slice_out_file_dir "${slice_out_collection_dir}")
+ endif()
+
+ __astscf_slice_get_targets_and_sources(${COLLECTION} "${COLLECTION_DIR}" "${SLICE}" "${slice_compiler_arguments}" targets sources)
+
+ # prepend the slice_out_dir to the targets
+ foreach(target ${targets})
+ list(APPEND generated_files "${slice_out_file_dir}/${target}")
+ endforeach()
+ set_source_files_properties(${generated_files} PROPERTIES GENERATED 1)
+
+ # header files that refer to the one generated from this Slice file
+ # will try to find it from the base of the collection, so add that
+ # directory to the include path
+ include_directories(SYSTEM "${slice_out_collection_dir}")
+ # the C++ source file generated from this Slice file will try to find
+ # the generated header in the same directory as the source, so add
+ # the file's immediate directory to the include path as well
+ include_directories(SYSTEM "${slice_out_file_dir}")
+
file(MAKE_DIRECTORY ${slice_out_file_dir})
add_custom_command(
OUTPUT ${generated_files}
commit 462facccf5ee511044090f09230fc90617391fd9
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Wed Jun 15 16:55:31 2011 -0500
Provide 'astscf' prefix for linking to ice-util-cpp library.
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index b9b5408..5e236a0 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -1,6 +1,6 @@
include_directories(${logger_dir}/include)
include_directories(${util-cpp_dir}/include)
-include_directories(${ice-util-cpp_dir}/include)
+include_directories(${astscf-ice-util-cpp_dir}/include)
find_package(Lua51 REQUIRED)
include_directories(${LUA_INCLUDE_DIR})
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 4db355b..2578402 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -1,4 +1,4 @@
-include_directories(${ice-util-cpp_dir}/include)
+include_directories(${astscf-ice-util-cpp_dir}/include)
astscf_component_init(RoutingTest)
astscf_component_add_files(RoutingTest TestRouting.cpp)
commit 8ac19ce33aff7c7fd00119506fd9bbe779633f25
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Wed Jun 15 16:50:49 2011 -0500
Provide 'astscf' prefix for linking to util-cpp library.
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 214efbb..b9b5408 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -41,7 +41,7 @@ astscf_component_add_ice_libraries(BasicRoutingService IceStorm)
astscf_component_add_boost_libraries(BasicRoutingService thread date_time core regex)
astscf_component_add_slice_collection_libraries(BasicRoutingService ASTSCF)
astscf_component_build_icebox(BasicRoutingService)
-target_link_libraries(BasicRoutingService ${LUA_LIBRARIES} logging-client util-cpp)
+target_link_libraries(BasicRoutingService ${LUA_LIBRARIES} logging-client astscf-util-cpp)
astscf_component_install(BasicRoutingService)
astscf_component_init(BasicRoutingStateReplicator)
commit 4e955db86566250a639e2427c152206e3c64a3f0
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Wed Jun 15 16:40:16 2011 -0500
Install component-specific Slice files.
Use astscf_slice_collection_install() to install the Slice files provided
by each component, that define its interfaces. As part of this change, many
of these Slice files were renamed and moved into different namespaces, to
provide consistency.
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 35e9749..ba8ff6b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -4,3 +4,4 @@ add_subdirectory(src)
if(BUILD_TESTING)
add_subdirectory(test)
endif()
+astscf_slice_collection_install(PROJECT)
diff --git a/slice/BasicRoutingStateReplicationIf.ice b/slice/AsteriskSCF/Replication/BasicRoutingService/BasicRoutingStateReplicationIf.ice
similarity index 98%
rename from slice/BasicRoutingStateReplicationIf.ice
rename to slice/AsteriskSCF/Replication/BasicRoutingService/BasicRoutingStateReplicationIf.ice
index 4ea55c1..507444c 100644
--- a/slice/BasicRoutingStateReplicationIf.ice
+++ b/slice/AsteriskSCF/Replication/BasicRoutingService/BasicRoutingStateReplicationIf.ice
@@ -22,6 +22,10 @@
module AsteriskSCF
{
+
+module Replication
+{
+
module BasicRoutingService
{
["suppress"]
@@ -184,5 +188,6 @@ module V1
};
}; //module V1
-}; //module BasicRouting
+}; //module BasicRoutingService
+}; //module Replication
}; //module Asterisk SCF
diff --git a/src/BasicRoutingServiceApp.cpp b/src/BasicRoutingServiceApp.cpp
index 32c6ff9..ef38e4a 100644
--- a/src/BasicRoutingServiceApp.cpp
+++ b/src/BasicRoutingServiceApp.cpp
@@ -47,7 +47,7 @@ using namespace AsteriskSCF::Core::Routing::V1;
using namespace AsteriskSCF::Core::Discovery::V1;
using namespace AsteriskSCF::System::Component::V1;
using namespace AsteriskSCF::System::Logging;
-using namespace AsteriskSCF::BasicRoutingService::V1;
+using namespace AsteriskSCF::Replication::BasicRoutingService::V1;
using namespace AsteriskSCF::Discovery;
namespace
@@ -355,8 +355,8 @@ void BasicRoutingServiceApp::listenToStateReplicator()
// Are we in standby mode?
if (mReplicationContext->isComponentActive() == false)
{
- AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicatorPrx oneWayStateReplicator =
- AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicatorPrx::uncheckedCast(mReplicationContext->getReplicatorService()->ice_oneway());
+ AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateReplicatorPrx oneWayStateReplicator =
+ AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateReplicatorPrx::uncheckedCast(mReplicationContext->getReplicatorService()->ice_oneway());
oneWayStateReplicator->addListener(mReplicatorListenerProxy);
mListeningToReplicator = true;
@@ -385,8 +385,8 @@ void BasicRoutingServiceApp::stopListeningToStateReplicator()
try
{
- AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicatorPrx oneWayStateReplicator =
- AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicatorPrx::uncheckedCast(mReplicationContext->getReplicatorService()->ice_oneway());
+ AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateReplicatorPrx oneWayStateReplicator =
+ AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateReplicatorPrx::uncheckedCast(mReplicationContext->getReplicatorService()->ice_oneway());
oneWayStateReplicator->removeListener(mReplicatorListenerProxy);
@@ -576,8 +576,8 @@ void BasicRoutingServiceApp::locateBridgeManager()
*/
void BasicRoutingServiceApp::locateStateReplicator()
{
- BasicRoutingService::V1::RoutingStateReplicatorParamsPtr replicatorParams = new BasicRoutingService::V1::RoutingStateReplicatorParams();
- replicatorParams->category = BasicRoutingService::V1::StateReplicatorDiscoveryCategory;
+ RoutingStateReplicatorParamsPtr replicatorParams = new RoutingStateReplicatorParams();
+ replicatorParams->category = StateReplicatorDiscoveryCategory;
replicatorParams->name = mCommunicator->getProperties()->getPropertyWithDefault(mAppName + ".StateReplicatorName", "default");
try
diff --git a/src/BasicRoutingStateReplicatorApp.cpp b/src/BasicRoutingStateReplicatorApp.cpp
index 5fc57a6..198b97a 100644
--- a/src/BasicRoutingStateReplicatorApp.cpp
+++ b/src/BasicRoutingStateReplicatorApp.cpp
@@ -31,8 +31,7 @@ using namespace AsteriskSCF::Core;
using namespace AsteriskSCF::Core::Discovery::V1;
using namespace AsteriskSCF::System::Component::V1;
using namespace AsteriskSCF::System::Logging;
-using namespace AsteriskSCF::BasicRoutingService;
-using namespace AsteriskSCF::BasicRoutingService::V1;
+using namespace AsteriskSCF::Replication::BasicRoutingService::V1;
using namespace AsteriskSCF::Core::Routing::V1;
namespace
@@ -45,15 +44,17 @@ namespace AsteriskSCF
namespace BasicRoutingService
{
-typedef AsteriskSCF::Replication::StateReplicator< AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicator,
- AsteriskSCF::BasicRoutingService::V1::RoutingStateItemPtr,
+typedef AsteriskSCF::Replication::StateReplicator< RoutingStateReplicator,
+ RoutingStateItemPtr,
std::string,
- AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicatorListenerPrx> RoutingStateReplicatorI;
+ RoutingStateReplicatorListenerPrx> RoutingStateReplicatorI;
typedef IceUtil::Handle<RoutingStateReplicatorI> RoutingStateReplicatorIPtr;
};
};
+using namespace AsteriskSCF::BasicRoutingService;
+
/**
* This class implements a very simplistic replication capability using the StateReplicator template.
*/
@@ -86,7 +87,7 @@ private:
Discovery::V1::ServiceManagementPrx mComponentServiceManagement;
Discovery::V1::ServiceManagementPrx mStateReplicationManagement;
ConfiguredIceLoggerPtr mIceLogger;
- AsteriskSCF::BasicRoutingService::RoutingStateReplicatorIPtr mStateReplicator;
+ RoutingStateReplicatorIPtr mStateReplicator;
ComponentServicePrx mComponentServicePrx;
RoutingStateReplicatorPrx mStateReplicatorPrx;
@@ -166,16 +167,16 @@ void BasicRoutingStateReplicatorService::registerWithServiceLocator()
{
// Add our ComponentService interface and add it to the Service Locator.
// Note that this interface has its own adapter.
- string componentServiceGuid(AsteriskSCF::BasicRoutingService::V1::StateReplicatorComponentCategory);
+ string componentServiceGuid(StateReplicatorComponentCategory);
mComponentServiceManagement = mServiceLocatorManagement->addService(mComponentServicePrx, componentServiceGuid);
- setCategory(mComponentServiceManagement, AsteriskSCF::BasicRoutingService::V1::StateReplicatorComponentCategory);
+ setCategory(mComponentServiceManagement, StateReplicatorComponentCategory);
// Add our Replicator interface and add it to the Service Locator.
- string stateReplicationGuid(AsteriskSCF::BasicRoutingService::V1::StateReplicatorDiscoveryCategory);
+ string stateReplicationGuid(StateReplicatorDiscoveryCategory);
mStateReplicationManagement = mServiceLocatorManagement->addService(mStateReplicatorPrx, stateReplicationGuid);
ServiceLocatorParamsPtr discoveryParams = new ServiceLocatorParams();
- discoveryParams->category = AsteriskSCF::BasicRoutingService::V1::StateReplicatorDiscoveryCategory;
+ discoveryParams->category = StateReplicatorDiscoveryCategory;
string replicatorName = mCommunicator->getProperties()->getPropertyWithDefault(mAppName + ".InstanceName", "default");
ServiceLocatorParamsComparePrx compareProxy = ServiceLocatorParamsComparePrx::uncheckedCast(
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 1be47e4..214efbb 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -6,7 +6,7 @@ find_package(Lua51 REQUIRED)
include_directories(${LUA_INCLUDE_DIR})
astscf_component_init(BasicRoutingService)
-astscf_component_add_slices(BasicRoutingService PROJECT BasicRoutingStateReplicationIf.ice)
+astscf_component_add_slices(BasicRoutingService PROJECT AsteriskSCF/Replication/BasicRoutingService/BasicRoutingStateReplicationIf.ice)
astscf_component_add_files(BasicRoutingService BasicRoutingServiceApp.cpp)
astscf_component_add_files(BasicRoutingService SessionRouter.cpp)
astscf_component_add_files(BasicRoutingService SessionRouter.h)
@@ -46,7 +46,7 @@ astscf_component_install(BasicRoutingService)
astscf_component_init(BasicRoutingStateReplicator)
astscf_component_add_files(BasicRoutingStateReplicator BasicRoutingStateReplicatorApp.cpp)
-astscf_component_add_slices(BasicRoutingStateReplicator PROJECT BasicRoutingStateReplicationIf.ice)
+astscf_component_add_slices(BasicRoutingStateReplicator PROJECT AsteriskSCF/Replication/BasicRoutingService/BasicRoutingStateReplicationIf.ice)
astscf_component_add_ice_libraries(BasicRoutingStateReplicator IceStorm)
astscf_component_add_slice_collection_libraries(BasicRoutingStateReplicator ASTSCF)
astscf_component_build_icebox(BasicRoutingStateReplicator)
diff --git a/src/ConnectBridgedSessionsWithDestinationOperation.cpp b/src/ConnectBridgedSessionsWithDestinationOperation.cpp
index ca07b82..449d36c 100644
--- a/src/ConnectBridgedSessionsWithDestinationOperation.cpp
+++ b/src/ConnectBridgedSessionsWithDestinationOperation.cpp
@@ -25,7 +25,8 @@ using namespace AsteriskSCF;
using namespace AsteriskSCF::Core::Routing::V1;
using namespace AsteriskSCF::SessionCommunications::V1;
using namespace AsteriskSCF::System::Logging;
-using namespace ::AsteriskSCF::BasicRoutingService::V1;
+using namespace AsteriskSCF::BasicRoutingService;
+using namespace AsteriskSCF::Replication::BasicRoutingService::V1;
using namespace AsteriskSCF::StateMachine;
namespace
@@ -76,8 +77,7 @@ public:
ConnectBridgedSessionsWithDestinationOpStartPtr
opStart(new ConnectBridgedSessionsWithDestinationOpStart());
opStart->operationId = mOperation->getOperationId();
- opStart->key = mOperation->getOperationId() +
- AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestStartKeyMod;
+ opStart->key = mOperation->getOperationId() + ConnectBridgedSessionsWithDestStartKeyMod;
opStart->sessionToReplace = mOperation->getSessionToReplace();
opStart->destination = mOperation->getDestination();
@@ -91,8 +91,7 @@ public:
ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr
waitLookup(new ConnectBridgedSessionsWithDestinationOpWaitLookupState());
waitLookup->operationId = mOperation->getOperationId();
- waitLookup->key = mOperation->getOperationId() +
- AsteriskSCF::BasicRoutingService::V1::RouteSessionOpWaitLookupKeyMod;
+ waitLookup->key = mOperation->getOperationId() + RouteSessionOpWaitLookupKeyMod;
waitLookup->endpoints = mOperation->getLookupResult();
waitLookup->remainingSessions = mOperation->getRemainingSessions();
@@ -167,8 +166,7 @@ public:
ConnectBridgedSessionsWithDestinationOpBridgingStatePtr
bridgeOp(new ConnectBridgedSessionsWithDestinationOpBridgingState());
bridgeOp->operationId = mOperation->getOperationId();
- bridgeOp->key = mOperation->getOperationId() +
- AsteriskSCF::BasicRoutingService::V1::RouteSessionOpBridgingKeyMod;
+ bridgeOp->key = mOperation->getOperationId() + RouteSessionOpBridgingKeyMod;
bridgeOp->bridge = mOperation->getBridge();
pushState(bridgeOp);
@@ -282,7 +280,7 @@ ConnectBridgedSessionsWithDestinationOperation::~ConnectBridgedSessionsWithDesti
lg(Debug) << "ConnectBridgedSessionsWithDestinationOperation() being destroyed for " << mDestination ;
}
-void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr& stateItem)
+void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::OperationStateItemPtr& stateItem)
{
ConnectBridgedSessionsWithDestinationOpStartPtr start;
ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr waitLookup;
@@ -302,7 +300,7 @@ void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const Asteris
}
}
-void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpStartPtr& item)
+void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const ConnectBridgedSessionsWithDestinationOpStartPtr& item)
{
mSessionToReplace = item->sessionToReplace;
mDestination = item->destination;
@@ -311,13 +309,13 @@ void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const Asteris
mReplicatedStates.push_back(ConnectBridgedSessionsWithDestinationOp::STATE_LOOKUP);
}
-void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& item)
+void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& item)
{
mLookupResult = item->endpoints;
mReplicatedStates.push_back(ConnectBridgedSessionsWithDestinationOp::STATE_WAIT_LOOKUP_RESULTS);
}
-void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& item)
+void ConnectBridgedSessionsWithDestinationOperation::reflectUpdate(const ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& item)
{
mBridge = item->bridge;
diff --git a/src/ConnectBridgedSessionsWithDestinationOperation.h b/src/ConnectBridgedSessionsWithDestinationOperation.h
index 8730a61..c7a142f 100644
--- a/src/ConnectBridgedSessionsWithDestinationOperation.h
+++ b/src/ConnectBridgedSessionsWithDestinationOperation.h
@@ -92,7 +92,7 @@ public:
/**
* Update a replica object with new state information.
*/
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr& stateItem);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::OperationStateItemPtr& stateItem);
/**
* Set the state machine into the highest state possible based on all of the state updates
@@ -121,9 +121,9 @@ protected:
private:
void initStateMachine();
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpStartPtr& stateItem);
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& stateItem);
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& stateItem);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpStartPtr& stateItem);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& stateItem);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& stateItem);
/**
* This is a state handler for one of this operation's states.
diff --git a/src/EndpointRegistry.cpp b/src/EndpointRegistry.cpp
index 8756701..bc794ca 100644
--- a/src/EndpointRegistry.cpp
+++ b/src/EndpointRegistry.cpp
@@ -30,7 +30,8 @@ using namespace ::AsteriskSCF::Core::Endpoint::V1;
using namespace ::AsteriskSCF::Core::Routing::V1;
using namespace ::AsteriskSCF::System::Logging;
using namespace ::AsteriskSCF::Core::Routing::V1::Event;
-using namespace ::AsteriskSCF::BasicRoutingService::V1;
+using namespace ::AsteriskSCF::BasicRoutingService;
+using namespace ::AsteriskSCF::Replication::BasicRoutingService::V1;
using namespace ::AsteriskSCF::Discovery;
namespace
diff --git a/src/OperationReplicaCache.cpp b/src/OperationReplicaCache.cpp
index a0c5866..56c22e6 100644
--- a/src/OperationReplicaCache.cpp
+++ b/src/OperationReplicaCache.cpp
@@ -21,7 +21,8 @@
#include "SessionRouterOperation.h"
using namespace AsteriskSCF::Threading;
-using namespace AsteriskSCF::BasicRoutingService::V1;
+using namespace AsteriskSCF::BasicRoutingService;
+using namespace AsteriskSCF::Replication::BasicRoutingService::V1;
namespace AsteriskSCF
{
diff --git a/src/OperationReplicaCache.h b/src/OperationReplicaCache.h
index 5d207fb..740c66c 100644
--- a/src/OperationReplicaCache.h
+++ b/src/OperationReplicaCache.h
@@ -37,7 +37,7 @@ class OperationCachePriv;
class OperationReplicaCachePriv;
class SessionContext;
-typedef std::map<std::string, AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr> StateItemMapType;
+typedef std::map<std::string, AsteriskSCF::Replication::BasicRoutingService::V1::OperationStateItemPtr> StateItemMapType;
/**
* For each transaction id, we're going to cache the all the state items for the operation.
@@ -71,7 +71,7 @@ public:
{
}
- void cacheOperationState(const AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr& item)
+ void cacheOperationState(const AsteriskSCF::Replication::BasicRoutingService::V1::OperationStateItemPtr& item)
{
boost::unique_lock<boost::shared_mutex> lock(mLock);
diff --git a/src/ReplicationContext.h b/src/ReplicationContext.h
index 1e82e00..3050d48 100644
--- a/src/ReplicationContext.h
+++ b/src/ReplicationContext.h
@@ -25,7 +25,7 @@ namespace AsteriskSCF
{
namespace BasicRoutingService
{
-typedef AsteriskSCF::Discovery::SmartProxy<AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicatorPrx> ReplicatorServicePrx;
+typedef AsteriskSCF::Discovery::SmartProxy<AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateReplicatorPrx> ReplicatorServicePrx;
class ReplicationContextPriv;
diff --git a/src/RouteSessionOperation.cpp b/src/RouteSessionOperation.cpp
index 80c15e8..d8d25da 100644
--- a/src/RouteSessionOperation.cpp
+++ b/src/RouteSessionOperation.cpp
@@ -26,7 +26,8 @@ using namespace AsteriskSCF;
using namespace AsteriskSCF::Core::Routing::V1;
using namespace AsteriskSCF::SessionCommunications::V1;
using namespace AsteriskSCF::System::Logging;
-using namespace ::AsteriskSCF::BasicRoutingService::V1;
+using namespace AsteriskSCF::BasicRoutingService;
+using namespace AsteriskSCF::Replication::BasicRoutingService::V1;
using namespace AsteriskSCF::StateMachine;
namespace
@@ -78,8 +79,7 @@ public:
// Push this information to the state replicator.
RouteSessionOpStartPtr routeSessionOpStart(new RouteSessionOpStart());
routeSessionOpStart->operationId = mOperation->getOperationId();
- routeSessionOpStart->key = mOperation->getOperationId() +
- AsteriskSCF::BasicRoutingService::V1::RouteSessionOpStartKeyMod;
+ routeSessionOpStart->key = mOperation->getOperationId() + RouteSessionOpStartKeyMod;
routeSessionOpStart->source = mOperation->getSource();
routeSessionOpStart->destination = mOperation->getDestination();
@@ -92,8 +92,7 @@ public:
// We've obtained a result from our AMI lookup request.
RouteSessionOpWaitLookupStatePtr routeSessionOpWaitLookup(new RouteSessionOpWaitLookupState());
routeSessionOpWaitLookup->operationId = mOperation->getOperationId();
- routeSessionOpWaitLookup->key = mOperation->getOperationId() +
- AsteriskSCF::BasicRoutingService::V1::RouteSessionOpWaitLookupKeyMod;
+ routeSessionOpWaitLookup->key = mOperation->getOperationId() + RouteSessionOpWaitLookupKeyMod;
routeSessionOpWaitLookup->endpoints = mOperation->getLookupResult();
pushState(routeSessionOpWaitLookup);
@@ -165,8 +164,7 @@ public:
// Push this information to the state replicator.
RouteSessionOpBridgingStatePtr routeSessionOpBridging(new RouteSessionOpBridgingState());
routeSessionOpBridging->operationId = mOperation->getOperationId();
- routeSessionOpBridging->key = mOperation->getOperationId() +
- AsteriskSCF::BasicRoutingService::V1::RouteSessionOpBridgingKeyMod;
+ routeSessionOpBridging->key = mOperation->getOperationId() + RouteSessionOpBridgingKeyMod;
routeSessionOpBridging->bridge = mOperation->getBridge();
pushState(routeSessionOpBridging);
@@ -279,7 +277,7 @@ RouteSessionOperationPtr RouteSessionOperation::createReplica(const SessionConte
return op;
}
-void RouteSessionOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr& stateItem)
+void RouteSessionOperation::reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::OperationStateItemPtr& stateItem)
{
RouteSessionOpStartPtr start;
RouteSessionOpWaitLookupStatePtr waitLookup;
@@ -299,7 +297,7 @@ void RouteSessionOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService
}
}
-void RouteSessionOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::RouteSessionOpStartPtr& item)
+void RouteSessionOperation::reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::RouteSessionOpStartPtr& item)
{
mSource = item->source;
mDestination = item->destination;
@@ -308,14 +306,14 @@ void RouteSessionOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService
mReplicatedStates.push_back(RouteSessionOp::STATE_LOOKUP);
}
-void RouteSessionOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::RouteSessionOpWaitLookupStatePtr& item)
+void RouteSessionOperation::reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::RouteSessionOpWaitLookupStatePtr& item)
{
mLookupResult = item->endpoints;
mReplicatedStates.push_back(RouteSessionOp::STATE_WAIT_LOOKUP_RESULTS);
}
-void RouteSessionOperation::reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::RouteSessionOpBridgingStatePtr& item)
+void RouteSessionOperation::reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::RouteSessionOpBridgingStatePtr& item)
{
mBridge = item->bridge;
diff --git a/src/RouteSessionOperation.h b/src/RouteSessionOperation.h
index 1846f92..b5ce75c 100644
--- a/src/RouteSessionOperation.h
+++ b/src/RouteSessionOperation.h
@@ -89,7 +89,7 @@ public:
/**
* Update a replica object with new state information.
*/
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr& stateItem);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::OperationStateItemPtr& stateItem);
/**
* Set the state machine into the highest state possible based on all of the state updates
@@ -116,17 +116,17 @@ private:
/**
* Update a replica object with new state information of a specific type.
*/
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::RouteSessionOpStartPtr& item);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::RouteSessionOpStartPtr& item);
/**
* Update a replica object with new state information of a specific type.
*/
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::RouteSessionOpWaitLookupStatePtr& item);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::RouteSessionOpWaitLookupStatePtr& item);
/**
* Update a replica object with new state information of a specific type.
*/
- void reflectUpdate(const AsteriskSCF::BasicRoutingService::V1::RouteSessionOpBridgingStatePtr& item);
+ void reflectUpdate(const AsteriskSCF::Replication::BasicRoutingService::V1::RouteSessionOpBridgingStatePtr& item);
/**
* This is a state handler for one of this operation's states.
diff --git a/src/RoutingServiceEventPublisher.cpp b/src/RoutingServiceEventPublisher.cpp
index 788a805..80031e2 100644
--- a/src/RoutingServiceEventPublisher.cpp
+++ b/src/RoutingServiceEventPublisher.cpp
@@ -25,7 +25,7 @@
using namespace ::std;
using namespace ::AsteriskSCF::Core::Routing::V1;
using namespace ::AsteriskSCF::System::Logging;
-using namespace ::AsteriskSCF::BasicRoutingService::V1;
+using namespace ::AsteriskSCF::BasicRoutingService;
namespace
{
diff --git a/src/RoutingStateReplicatorListener.cpp b/src/RoutingStateReplicatorListener.cpp
index 3f4a729..3e96cc0 100644
--- a/src/RoutingStateReplicatorListener.cpp
+++ b/src/RoutingStateReplicatorListener.cpp
@@ -25,7 +25,8 @@
#include "RouteSessionOperation.h"
#include "EndpointRegistry.h"
-using namespace AsteriskSCF::BasicRoutingService::V1;
+using namespace AsteriskSCF::BasicRoutingService;
+using namespace AsteriskSCF::Replication::BasicRoutingService::V1;
using namespace AsteriskSCF::System::Logging;
namespace
@@ -53,7 +54,7 @@ public:
void stateRemovedForItems(const RoutingStateItemSeq& items, const Ice::Current& )
{
// Method local visitor implementation for handling removal of state items.
- class visitor : public AsteriskSCF::BasicRoutingService::V1::RoutingStateItemVisitor
+ class visitor : public RoutingStateItemVisitor
{
public:
visitor(RoutingStateReplicatorListenerPriv *impl) : mImpl(impl)
@@ -64,7 +65,7 @@ public:
RoutingStateReplicatorListenerPriv *mImpl;
// Used an intermediate class in the slice types, and the visitor didn't pick up the leaf classes to visit.
- void visitOperationStateItem(const ::AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr& operation)
+ void visitOperationStateItem(const OperationStateItemPtr& operation)
{
RouteSessionOpStartPtr routeSessinOpStart = RouteSessionOpStartPtr::dynamicCast(operation);
if (routeSessinOpStart != 0)
@@ -109,38 +110,38 @@ public:
}
}
- void visitRouteSessionOpStart(const ::AsteriskSCF::BasicRoutingService::V1::RouteSessionOpStartPtr& opState)
+ void visitRouteSessionOpStart(const RouteSessionOpStartPtr& opState)
{
// The operation cache keeps all the collected state for an operation under the transaction id.
mImpl->mOperationReplicaCache->getRouteSessionCache()->dropOperation(opState->operationId);
}
- void visitRouteSessionOpWaitLookupState(const ::AsteriskSCF::BasicRoutingService::V1::RouteSessionOpWaitLookupStatePtr& )
+ void visitRouteSessionOpWaitLookupState(const RouteSessionOpWaitLookupStatePtr& )
{
// Removing the Start state for this operation will clean it up.
}
- void visitRouteSessionOpBridgingState(const ::AsteriskSCF::BasicRoutingService::V1::RouteSessionOpBridgingStatePtr& )
+ void visitRouteSessionOpBridgingState(const RouteSessionOpBridgingStatePtr& )
{
// Removing the Start state for this operation will clean it up.
}
- void visitConnectBridgedSessionsWithDestinationOpStart(const ::AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpStartPtr& opState)
+ void visitConnectBridgedSessionsWithDestinationOpStart(const ConnectBridgedSessionsWithDestinationOpStartPtr& opState)
{
mImpl->mOperationReplicaCache->getConnectBridgedSessionsWithDestCache()->dropOperation(opState->operationId);
}
- void visitConnectBridgedSessionsWithDestinationOpWaitLookupState(const ::AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& )
+ void visitConnectBridgedSessionsWithDestinationOpWaitLookupState(const ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& )
{
// Removing the Start state for this operation will clean it up.
}
- void visitConnectBridgedSessionsWithDestinationOpBridgingState(const ::AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& )
+ void visitConnectBridgedSessionsWithDestinationOpBridgingState(const ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& )
{
// Removing the Start state for this operation will clean it up.
}
- void visitEndpointLocatorState(const ::AsteriskSCF::BasicRoutingService::V1::EndpointLocatorStatePtr& item)
+ void visitEndpointLocatorState(const EndpointLocatorStatePtr& item)
{
mImpl->mEndpointRegistry->removeEndpointLocator(item->key, ::Ice::Current());
}
@@ -148,7 +149,7 @@ public:
}; // end method-local visitor def
// Create the visitor. Smart pointer will cleanup when this method exits.
- AsteriskSCF::BasicRoutingService::V1::RoutingStateItemVisitorPtr v = new visitor(this);
+ RoutingStateItemVisitorPtr v = new visitor(this);
for (RoutingStateItemSeq::const_iterator item = items.begin(); item != items.end(); ++item)
{
@@ -165,7 +166,7 @@ public:
{
// Method-local visitor class for handling new state.
- class visitor : public AsteriskSCF::BasicRoutingService::V1::RoutingStateItemVisitor
+ class visitor : public RoutingStateItemVisitor
{
public:
visitor(RoutingStateReplicatorListenerPriv *impl, const Ice::Current& cur)
@@ -178,7 +179,7 @@ public:
const Ice::Current& mCurrent;
// Used an intermediate class in the slice types, and the visitor didn't pick up the leaf classes to visit.
- void visitOperationStateItem(const ::AsteriskSCF::BasicRoutingService::V1::OperationStateItemPtr& operation)
+ void visitOperationStateItem(const OperationStateItemPtr& operation)
{
RouteSessionOpStartPtr routeSessinOpStart = RouteSessionOpStartPtr::dynamicCast(operation);
if (routeSessinOpStart != 0)
@@ -223,37 +224,37 @@ public:
}
}
- void visitRouteSessionOpStart(const ::AsteriskSCF::BasicRoutingService::V1::RouteSessionOpStartPtr& opState)
+ void visitRouteSessionOpStart(const RouteSessionOpStartPtr& opState)
{
mImpl->mOperationReplicaCache->getRouteSessionCache()->cacheOperationState(opState);
}
- void visitRouteSessionOpWaitLookupState(const ::AsteriskSCF::BasicRoutingService::V1::RouteSessionOpWaitLookupStatePtr& opState)
+ void visitRouteSessionOpWaitLookupState(const RouteSessionOpWaitLookupStatePtr& opState)
{
mImpl->mOperationReplicaCache->getRouteSessionCache()->cacheOperationState(opState);
}
- void visitRouteSessionOpBridgingState(const ::AsteriskSCF::BasicRoutingService::V1::RouteSessionOpBridgingStatePtr& opState)
+ void visitRouteSessionOpBridgingState(const RouteSessionOpBridgingStatePtr& opState)
{
mImpl->mOperationReplicaCache->getRouteSessionCache()->cacheOperationState(opState);
}
- void visitConnectBridgedSessionsWithDestinationOpStart(const ::AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpStartPtr& opState)
+ void visitConnectBridgedSessionsWithDestinationOpStart(const ConnectBridgedSessionsWithDestinationOpStartPtr& opState)
{
mImpl->mOperationReplicaCache->getConnectBridgedSessionsWithDestCache()->cacheOperationState(opState);
}
- void visitConnectBridgedSessionsWithDestinationOpWaitLookupState(const ::AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& opState)
+ void visitConnectBridgedSessionsWithDestinationOpWaitLookupState(const ConnectBridgedSessionsWithDestinationOpWaitLookupStatePtr& opState)
{
mImpl->mOperationReplicaCache->getConnectBridgedSessionsWithDestCache()->cacheOperationState(opState);
}
- void visitConnectBridgedSessionsWithDestinationOpBridgingState(const ::AsteriskSCF::BasicRoutingService::V1::ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& opState)
+ void visitConnectBridgedSessionsWithDestinationOpBridgingState(const ConnectBridgedSessionsWithDestinationOpBridgingStatePtr& opState)
{
mImpl->mOperationReplicaCache->getConnectBridgedSessionsWithDestCache()->cacheOperationState(opState);
}
- void visitEndpointLocatorState(const ::AsteriskSCF::BasicRoutingService::V1::EndpointLocatorStatePtr& item)
+ void visitEndpointLocatorState(const EndpointLocatorStatePtr& item)
{
mImpl->mEndpointRegistry->addEndpointLocator(item->key, item->regExList, item->locator, mCurrent);
}
@@ -261,7 +262,7 @@ public:
}; // end method-local visitor def
// Create the visitor. Smart pointer will cleanup when this method exits.
- AsteriskSCF::BasicRoutingService::V1::RoutingStateItemVisitorPtr v = new visitor(this, current);
+ RoutingStateItemVisitorPtr v = new visitor(this, current);
for (RoutingStateItemSeq::const_iterator item = items.begin(); item != items.end(); ++item)
{
diff --git a/src/RoutingStateReplicatorListener.h b/src/RoutingStateReplicatorListener.h
index 5732494..d483a13 100644
--- a/src/RoutingStateReplicatorListener.h
+++ b/src/RoutingStateReplicatorListener.h
@@ -36,14 +36,14 @@ class RoutingStateReplicatorListenerPriv;
* this service is in standby mode, and ensures that this instance of the
* service has the latest dynamic state in case it is activated.
*/
-class RoutingStateReplicatorListenerImpl : public AsteriskSCF::BasicRoutingService::V1::RoutingStateReplicatorListener
+class RoutingStateReplicatorListenerImpl : public AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateReplicatorListener
{
public:
RoutingStateReplicatorListenerImpl(const EndpointRegistryPtr& registry, const boost::shared_ptr<OperationReplicaCache>& opCache);
~RoutingStateReplicatorListenerImpl();
void stateRemoved(const Ice::StringSeq&, const Ice::Current&);
- void stateRemovedForItems(const AsteriskSCF::BasicRoutingService::V1::RoutingStateItemSeq&, const Ice::Current&);
- void stateSet(const AsteriskSCF::BasicRoutingService::V1::RoutingStateItemSeq&, const Ice::Current&);
+ void stateRemovedForItems(const AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateItemSeq&, const Ice::Current&);
+ void stateSet(const AsteriskSCF::Replication::BasicRoutingService::V1::RoutingStateItemSeq&, const Ice::Current&);
bool operator==(RoutingStateReplicatorListenerImpl &rhs);
private:
commit 511a822b3c569cb07c5f5f0712c925f9890c0e5d
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Wed Jun 15 16:36:15 2011 -0500
Support installation of Slice collections.
Add the astscf_slice_collection_install() function, which will install the
collection's Slice files, header files and library (if they are provided).
diff --git a/AsteriskSCF.cmake b/AsteriskSCF.cmake
index 5d299de..8887518 100644
--- a/AsteriskSCF.cmake
+++ b/AsteriskSCF.cmake
@@ -586,7 +586,7 @@ function(astscf_slice_include_collection COLLECTION)
set(SLICE_INCLUDE_DIRECTORIES ${SLICE_INCLUDE_DIRECTORIES} PARENT_SCOPE)
if(SLICE_COLLECTION_${COLLECTION}_HEADERS)
set(path "${SLICE_COLLECTION_${COLLECTION}_HEADERS}")
- message(STATUS "Using C++ headers for Slice collection ${COLLECTION} from: ${path}")
+ message(STATUS "Using C++ headers for Slice collection ${COLLECTION} from ${path}")
# We mark the Slice include directory as a 'system' directory so that
# the compiler will be less likely to generate warnings and/or errors
# for the code in the generated header files.
@@ -912,44 +912,48 @@ function(astscf_component_install COMPONENT)
if(${COMPONENT}_TYPE STREQUAL "icebox")
install(
TARGETS ${COMPONENT}
- ARCHIVE DESTINATION ${ASTSCF_INSTALL_LIB_DIR}
- LIBRARY DESTINATION ${ASTSCF_INSTALL_ICEBOX_DIR}
- RUNTIME DESTINATION ${ASTSCF_INSTALL_ICEBOX_DIR}
+ ARCHIVE DESTINATION "${ASTSCF_INSTALL_LIB_DIR}"
+ LIBRARY DESTINATION "${ASTSCF_INSTALL_ICEBOX_DIR}"
+ RUNTIME DESTINATION "${ASTSCF_INSTALL_ICEBOX_DIR}"
)
else()
install(
TARGETS ${COMPONENT}
- ARCHIVE DESTINATION ${ASTSCF_INSTALL_LIB_DIR}
- LIBRARY DESTINATION ${ASTSCF_INSTALL_LIB_DIR}
- RUNTIME DESTINATION ${ASTSCF_INSTALL_BIN_DIR}
+ ARCHIVE DESTINATION "${ASTSCF_INSTALL_LIB_DIR}"
+ LIBRARY DESTINATION "${ASTSCF_INSTALL_LIB_DIR}"
+ RUNTIME DESTINATION "${ASTSCF_INSTALL_BIN_DIR}"
)
endif()
endfunction()
-# Install generated Slice header files to their proper location
-function(astscf_slice_headers_install)
- install(
- DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/generated/
- DESTINATION ${ASTSCF_INSTALL_INCLUDE_DIR}
- FILES_MATCHING PATTERN "*.h"
- )
-endfunction()
-
-# Install Slice files to their proper location
-function(astscf_slice_install DIR)
- install(
- DIRECTORY ${DIR}
- DESTINATION ${ASTSCF_INSTALL_SLICE_DIR}
- FILES_MATCHING PATTERN "*.ice"
- )
+function(astscf_slice_collection_install COLLECTION)
+ if(NOT SLICE_COLLECTION_${COLLECTION})
+ message(FATAL_ERROR "Slice collection ${COLLECTION} has not been defined.")
+ endif()
+ # install Slice files
+ install(DIRECTORY "${SLICE_COLLECTION_${COLLECTION}}/"
+ DESTINATION "${ASTSCF_INSTALL_SLICE_DIR}"
+ FILES_MATCHING
+ PATTERN "*.ice"
+ )
+ # if the collection has a library that is a target in
+ # this build, install it
+ if(SLICE_COLLECTION_${COLLECTION}_LIBRARY AND ASTSCF_COMPONENT_${SLICE_COLLECTION_${COLLECTION}_LIBRARY})
+ astscf_component_install(${SLICE_COLLECTION_${COLLECTION}_LIBRARY})
+ endif()
+ # if the collection has headers, install them
+ if(SLICE_COLLECTION_${COLLECTION}_HEADERS)
+ astscf_headers_install("${SLICE_COLLECTION_${COLLECTION}_HEADERS}/")
+ endif()
endfunction()
# Install header files to their proper location
function(astscf_headers_install DIR)
install(
- DIRECTORY ${DIR}
- DESTINATION ${ASTSCF_INSTALL_INCLUDE_DIR}
- FILES_MATCHING PATTERN "*.h"
+ DIRECTORY "${DIR}"
+ DESTINATION "${ASTSCF_INSTALL_INCLUDE_DIR}"
+ FILES_MATCHING
+ PATTERN "*.h"
)
endfunction()
commit 1a08a1b3160492d844621bc176099953fc8b095a
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Tue Jun 14 17:41:27 2011 -0500
Allow library type specific in astscf_build_library().
astscf_build_library() can now be told to build a STATIC, SHARED or MODULE
library; astscf_set_libtype() has been removed.
diff --git a/AsteriskSCF.cmake b/AsteriskSCF.cmake
index c225053..5d299de 100644
--- a/AsteriskSCF.cmake
+++ b/AsteriskSCF.cmake
@@ -877,21 +877,29 @@ function(astscf_component_build_standalone COMPONENT)
target_link_libraries(${COMPONENT} ${component_libs})
endfunction()
-function(astscf_set_libtype COMPONENT TYPE)
- set("${COMPONENT}_LIBTYPE" ${TYPE} PARENT_SCOPE)
-endfunction()
-
function(astscf_component_build_library COMPONENT)
+ cmake_parse_arguments("" "SHARED;STATIC;MODULE" "" "" ${ARGN})
if(NOT ASTSCF_${COMPONENT})
message(FATAL_ERROR "Component ${COMPONENT} has not been initialized.")
endif()
- message(STATUS "Building component ${COMPONENT} as a ${${COMPONENT}_LIBTYPE} library")
+ if(NOT (_SHARED OR _STATIC OR _MODULE))
+ set(libtype SHARED)
+ elseif(_SHARED AND NOT (_STATIC OR _MODULE))
+ set(libtype SHARED)
+ elseif(_STATIC AND NOT (_SHARED OR _MODULE))
+ set(libtype STATIC)
+ elseif(_MODULE AND NOT (_SHARED OR _STATIC))
+ set(libtype MODULE)
+ else()
+ message(FATAL_ERROR "Only one of STATIC, SHARED or MODULE may be specified.")
+ endif()
+ message(STATUS "Building component ${COMPONENT} as a ${libtype} library")
__astscf_set_cache_string(${COMPONENT}_TYPE library "" ADVANCED)
__astscf_component_slices(${COMPONENT})
__astscf_component_libraries(${COMPONENT})
# Now we actually create the component
- add_library(${COMPONENT} ${${COMPONENT}_LIBTYPE} ${${COMPONENT}_SOURCES})
+ add_library(${COMPONENT} ${libtype} ${${COMPONENT}_SOURCES})
# Link required libraries
target_link_libraries(${COMPONENT} ${component_libs})
endfunction()
commit dd47b0f4d2ffc34b0320708f73d74dde031a1bbe
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Tue Jun 14 17:30:59 2011 -0500
Remove unnecessary variable references.
diff --git a/AsteriskSCF.cmake b/AsteriskSCF.cmake
index d888eeb..c225053 100644
--- a/AsteriskSCF.cmake
+++ b/AsteriskSCF.cmake
@@ -856,7 +856,7 @@ function(astscf_component_build_icebox COMPONENT)
__astscf_component_libraries(${COMPONENT})
# Now we actually create the shared module
- add_library(${COMPONENT} MODULE ${${COMPONENT}_SLICES} ${${COMPONENT}_SOURCES})
+ add_library(${COMPONENT} MODULE ${${COMPONENT}_SOURCES})
# Link required libraries
target_link_libraries(${COMPONENT} ${component_libs})
endfunction()
@@ -872,7 +872,7 @@ function(astscf_component_build_standalone COMPONENT)
__astscf_component_libraries(${COMPONENT})
# Now we actually create the component
- add_executable(${COMPONENT} ${${COMPONENT}_SLICES} ${${COMPONENT}_SOURCES})
+ add_executable(${COMPONENT} ${${COMPONENT}_SOURCES})
# Link required libraries
target_link_libraries(${COMPONENT} ${component_libs})
endfunction()
@@ -891,7 +891,7 @@ function(astscf_component_build_library COMPONENT)
__astscf_component_libraries(${COMPONENT})
# Now we actually create the component
- add_library(${COMPONENT} ${${COMPONENT}_LIBTYPE} ${${COMPONENT}_SLICES} ${${COMPONENT}_SOURCES})
+ add_library(${COMPONENT} ${${COMPONENT}_LIBTYPE} ${${COMPONENT}_SOURCES})
# Link required libraries
target_link_libraries(${COMPONENT} ${component_libs})
endfunction()
commit cd1a2391c396d4181b4f12712c5aefe6dd373fef
Merge: 720c2f1 7fcb7f0
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Tue Jun 14 17:25:30 2011 -0500
Merge branch 'master' into disintegrated-build
commit 720c2f1afc5508207cb4deaee740aa73702444a1
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Tue Jun 14 17:24:31 2011 -0500
Use Slice collections support in AsteriskSCF.cmake.
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 46ef49c..1be47e4 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -1,4 +1,3 @@
-include_directories(${API_INCLUDE_DIR})
include_directories(${logger_dir}/include)
include_directories(${util-cpp_dir}/include)
include_directories(${ice-util-cpp_dir}/include)
@@ -40,14 +39,16 @@ astscf_component_add_files(BasicRoutingService RoutingStateReplicatorListener.h)
astscf_component_add_files(BasicRoutingService RoutingStateReplicatorListener.cpp)
astscf_component_add_ice_libraries(BasicRoutingService IceStorm)
astscf_component_add_boost_libraries(BasicRoutingService thread date_time core regex)
+astscf_component_add_slice_collection_libraries(BasicRoutingService ASTSCF)
astscf_component_build_icebox(BasicRoutingService)
-target_link_libraries(BasicRoutingService ${LUA_LIBRARIES} logging-client util-cpp astscf-api)
+target_link_libraries(BasicRoutingService ${LUA_LIBRARIES} logging-client util-cpp)
astscf_component_install(BasicRoutingService)
astscf_component_init(BasicRoutingStateReplicator)
astscf_component_add_files(BasicRoutingStateReplicator BasicRoutingStateReplicatorApp.cpp)
astscf_component_add_slices(BasicRoutingStateReplicator PROJECT BasicRoutingStateReplicationIf.ice)
astscf_component_add_ice_libraries(BasicRoutingStateReplicator IceStorm)
+astscf_component_add_slice_collection_libraries(BasicRoutingStateReplicator ASTSCF)
astscf_component_build_icebox(BasicRoutingStateReplicator)
-target_link_libraries(BasicRoutingStateReplicator logging-client astscf-api)
+target_link_libraries(BasicRoutingStateReplicator logging-client)
astscf_component_install(BasicRoutingStateReplicator)
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 37324e7..4db355b 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -1,4 +1,3 @@
-include_directories(${API_INCLUDE_DIR})
include_directories(${ice-util-cpp_dir}/include)
astscf_component_init(RoutingTest)
@@ -16,6 +15,6 @@ astscf_component_add_files(RoutingTest MockEndpointLocator.h)
astscf_component_add_files(RoutingTest MockEndpointLocator.cpp)
astscf_component_add_ice_libraries(RoutingTest IceStorm)
astscf_component_add_boost_libraries(RoutingTest unit_test_framework)
+astscf_component_add_slice_collection_libraries(RoutingTest ASTSCF)
astscf_component_build_icebox(RoutingTest)
-target_link_libraries(RoutingTest astscf-api)
astscf_test_icebox(RoutingTest config/routingtest-integ.config)
commit 59f28cd006a442312375e2366a22e90730bafac9
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Tue Jun 14 17:07:17 2011 -0500
Add initial support for Slice file 'collections'.
Adds various functions to handle collections of Slice-defined interfaces in
an easy-to-use manner; this insulates the scripts that build components
from having to know the actual paths where Slice files, headers files and
libraries are located.
diff --git a/AsteriskSCF.cmake b/AsteriskSCF.cmake
index 895cd13..d888eeb 100644
--- a/AsteriskSCF.cmake
+++ b/AsteriskSCF.cmake
@@ -184,6 +184,8 @@ endif()
include(CTest)
enable_testing()
+include(CMakeParseArguments)
+
if(UNIX AND EXISTS "${CMAKE_SOURCE_DIR}/.git")
add_custom_target(update COMMAND git pull WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}" COMMENT "Updating clone")
add_custom_target(pull COMMAND git pull WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}" COMMENT "Updating clone")
@@ -320,15 +322,8 @@ function(astscf_project NAME ICE_VERSION)
# every component against those libraries at minimum
set(ASTSCF_ICE_LIBRARIES ICE ICEUTIL PARENT_SCOPE)
- message(STATUS "Using Ice C++ headers from: ${ICE_INCLUDE_DIR}")
- # We mark the Ice include directory as a 'system' directory so that
- # the compiler will be less likely to generate warnings and/or errors
- # for the code in the Ice header files.
- include_directories(SYSTEM "${ICE_INCLUDE_DIR}")
-
- set(SLICE_COLLECTION_Ice "${ICE_SLICE_DIR}")
- list(APPEND SLICE_INCLUDE_DIRECTORIES "${ICE_SLICE_DIR}")
- list(REMOVE_DUPLICATES SLICE_INCLUDE_DIRECTORIES)
+ astscf_slice_collection(GLOBAL NAME Ice PATH "${ICE_SLICE_DIR}" HEADERS "${ICE_INCLUDE_DIR}")
+ astscf_slice_include_collection(Ice)
set(SLICE_INCLUDE_DIRECTORIES ${SLICE_INCLUDE_DIRECTORIES} PARENT_SCOPE)
# threading support required
@@ -339,6 +334,7 @@ function(astscf_project NAME ICE_VERSION)
list(APPEND cxx_flags "${CMAKE_THREAD_LIBS_INIT}")
else()
list(APPEND linker_flags "${CMAKE_THREAD_LIBS_INIT}")
+ endif()
endif()
# If C++0x support is requested, use a compiler check to see if it is available
@@ -426,20 +422,6 @@ macro(__astscf_ensure_abs_paths pathlist)
set(${pathlist} ${eap_temp})
endmacro()
-# Function which remembers Slice plugins to be used for all targets in the
-# current directory and below
-function(astscf_slice_plugins)
- if(NOT ARGN)
- message(FATAL_ERROR "You must pass at least one plugin to this function")
- endif()
- set(plugins ${SLICE_PLUGINS})
- foreach(plugin ${ARGN})
- list(APPEND plugins ${plugin})
- endforeach()
- list(REMOVE_DUPLICATES plugins)
- set(SLICE_PLUGINS ${plugins} PARENT_SCOPE)
-endfunction()
-
# Function which initializes a component for building
function(astscf_component_init COMPONENT)
message(STATUS "Setting up to build component ${COMPONENT}")
@@ -502,22 +484,144 @@ function(astscf_component_add_ice_libraries COMPONENT)
__astscf_set_cache_string(${COMPONENT}_ICE_LIBRARIES "${libs}" "" ADVANCED)
endfunction()
-function(astscf_slice_collection COLLECTION PATH)
- get_filename_component(real "${PATH}" REALPATH)
- set(SLICE_COLLECTION_${COLLECTION} "${real}" PARENT_SCOPE)
- message(STATUS "Added Slice collection '${COLLECTION}' at ${PATH}")
+# Function which remembers Slice plugins to be used for all targets in the
+# current directory and below
+function(astscf_slice_plugins)
+ if(NOT ARGN)
+ message(FATAL_ERROR "You must pass at least one plugin to this function")
+ endif()
+ set(plugins ${SLICE_PLUGINS})
+ foreach(plugin ${ARGN})
+ list(APPEND plugins ${plugin})
+ endforeach()
+ list(REMOVE_DUPLICATES plugins)
+ set(SLICE_PLUGINS ${plugins} PARENT_SCOPE)
endfunction()
+# Function which defines a 'collection' of Slice interfaces; the collection
+# will consist of one or more Slice files, and optionally header/source files
+# generated in C++ from them, also optionally a compiled library produced
+# from the generated sources. Both global and local collections are supported;
+# local collections are unnamed and visible only to the directory they are defined
+# in and below. This function can be called more than once for the same global
+# collection if desired, using the 'OVERRIDE' flag, in order to 'update' the
+# collection's details.
+#
+# Syntax:
+# astscf_slice_collection([OVERRIDE] [GLOBAL NAME <name> | LOCAL]
+# [PATH <path>] [LIBRARY <library] [HEADERS <path>])
+#
+# GLOBAL: defines a global collection; NAME is mandatory
+# LOCAL: (default) defines a local collection; NAME will be 'LOCAL'
+# OVERRIDE: must be specified in order to change PATH, LIBRARY or HEADERS
+# for a previously-defined global collection
+# NAME: name of the collection
+# PATH: path to the directory where the Slice files are located
+# HEADERS: path to the directory where Slice-generated headers are located
+# LIBRARY: path or target name of a library built from Slice-generated sources
+#
+function(astscf_slice_collection)
+ cmake_parse_arguments("" "OVERRIDE;GLOBAL;LOCAL" "NAME;PATH;LIBRARY;HEADERS" "" ${ARGN})
+ if(_GLOBAL AND NOT _NAME)
+ message(FATAL_ERROR "NAME argument to this function is mandatory for global Slice collections.")
+ endif()
+ if(_LOCAL AND _NAME)
+ message(FATAL_ERROR "NAME argument to this function is not allowed for local Slice collections.")
+ endif()
+ if(_NAME STREQUAL "LOCAL")
+ message(FATAL_ERROR "'LOCAL' name for Slice collections is reserved.")
+ endif()
+ if(_NAME STREQUAL "PROJECT")
+ message(FATAL_ERROR "'LOCAL' name for Slice collections is reserved.")
+ endif()
+ if(_LIBRARY)
+ if(_GLOBAL AND NOT (_HEADERS OR SLICE_COLLECTION_${_NAME}_HEADERS))
+ message(FATAL_ERROR "A collection with a library must also provide headers.")
+ elseif(_LOCAL AND NOT (_HEADERS OR SLICE_COLLECTION_LOCAL_HEADERS))
+ message(FATAL_ERROR "A collection with a library must also provide headers.")
+ endif()
+ endif()
+ if(_PATH)
+ get_filename_component(real "${_PATH}" REALPATH)
+ elseif(NOT (_OVERRIDE AND _GLOBAL AND SLICE_COLLECTION_${_NAME}))
+ message(FATAL_ERROR "PATH argument to this function is mandatory.")
+ endif()
+ if(_GLOBAL)
+ if(_PATH)
+ __astscf_set_cache_path(SLICE_COLLECTION_${_NAME} "${real}" "Path to Slice files in collection ${_NAME}.")
+ endif()
+ if(_LIBRARY)
+ __astscf_set_cache_string(SLICE_COLLECTION_${_NAME}_LIBRARY "${_LIBRARY}" "Library of generated code for Slice collection ${_NAME}.")
+ endif()
+ if(_HEADERS)
+ __astscf_set_cache_path(SLICE_COLLECTION_${_NAME}_HEADERS "${_HEADERS}" "Path to generated headers for Slice collection ${_NAME}.")
+ endif()
+ message(STATUS "Added Slice collection '${_NAME}' at ${_PATH}")
+ else()
+ if(_PATH)
+ set(SLICE_COLLECTION_LOCAL "${real}" PARENT_SCOPE)
+ endif()
+ if(_LIBRARY)
+ set(SLICE_COLLECTION_LOCAL_LIBRARY "${_LIBRARY}" PARENT_SCOPE)
+ endif()
+ if(_HEADERS)
+ set(SLICE_COLLECTION_LOCAL_HEADERS "${_HEADERS}" PARENT_SCOPE)
+ endif()
+ message(STATUS "Added local Slice collection at ${_PATH}")
+ endif()
+endfunction()
+
+# Function which makes the Slice files and header files from a collection
+# available to components in the current directory and below. The collection's
+# Slice file directory is added to SLICE_INCLUDE_DIRECTORIES (for later use
+# by the Slice translator), and the collection's header files directory
+# (if any) is added as a 'system' include directory for compilations.
+#
function(astscf_slice_include_collection COLLECTION)
+ if(NOT SLICE_COLLECTION_${COLLECTION})
+ message(FATAL_ERROR "Slice collection ${COLLECTION} has not been defined.")
+ endif()
list(APPEND SLICE_INCLUDE_DIRECTORIES "${SLICE_COLLECTION_${COLLECTION}}")
list(REMOVE_DUPLICATES SLICE_INCLUDE_DIRECTORIES)
set(SLICE_INCLUDE_DIRECTORIES ${SLICE_INCLUDE_DIRECTORIES} PARENT_SCOPE)
+ if(SLICE_COLLECTION_${COLLECTION}_HEADERS)
+ set(path "${SLICE_COLLECTION_${COLLECTION}_HEADERS}")
+ message(STATUS "Using C++ headers for Slice collection ${COLLECTION} from: ${path}")
+ # We mark the Slice include directory as a 'system' directory so that
+ # the compiler will be less likely to generate warnings and/or errors
+ # for the code in the generated header files.
+ include_directories(SYSTEM "${path}")
+ endif()
endfunction()
-# Adds Slice files from a collection to a target. This handles all the magic of
-# creating the rules to run slice2cpp, adding the generated headers to the
-# include path, adding the generated .cpp file to the component, etc. The
-# generated files are placed in ${CMAKE_CURRENT_BINARY_DIR}/slice-<collection>.
+# Function which links the library associated with a Slice collection into
+# a component.
+#
+function(astscf_component_add_slice_collection_libraries COMPONENT)
+ if(NOT ARGN)
+ message(FATAL_ERROR "You must pass at least one Slice collection to this function")
+ endif()
+ if(NOT ASTSCF_${COMPONENT})
+ message(FATAL_ERROR "Component ${COMPONENT} has not been initialized.")
+ endif()
+ set(libs ${${COMPONENT}_SLICE_LIBRARIES})
+ foreach(lib ${ARGN})
+ if(NOT SLICE_COLLECTION_${lib})
+ message(FATAL_ERROR "Slice collection ${lib} has not been defined.")
+ endif()
+ if(NOT SLICE_COLLECTION_${lib}_LIBRARY)
+ message(FATAL_ERROR "Slice collection ${lib} does not provide a library.")
+ endif()
+ message(STATUS "Linking component ${COMPONENT} to library from Slice collection ${lib}")
+ list(APPEND libs ${lib})
+ endforeach()
+ list(REMOVE_DUPLICATES libs)
+ __astscf_set_cache_string(${COMPONENT}_SLICE_LIBRARIES "${libs}" "" ADVANCED)
+endfunction()
+
+# Function which records Slice files, from a collection, as being used by a
+# component. The Slice files will be translated and compiled when the component
+# is built.
#
# The Slice files are passed in as a list of globs, relative to the collection's
# base directory. The globs default to regular non-recursive expansion. If you
@@ -528,6 +632,7 @@ endfunction()
#
# See http://www.cmake.org/cmake/help/cmake-2-8-docs.html#command:file for more
# details on the globbing syntax.
+#
function(astscf_component_add_slices COMPONENT COLLECTION)
if(NOT ARGN)
message(FATAL_ERROR "You must pass at least one Slice file to this function")
@@ -570,14 +675,29 @@ function(astscf_component_add_slices COMPONENT COLLECTION)
else()
# expand the glob into a list of files
file(${glob_style} slices RELATIVE "${collection_dir}" "${collection_dir}/${slice_glob}")
- foreach(slice ${slices})
- __astscf_component_add_one_slice(${COMPONENT} "${COLLECTION}" "${collection_dir}" "${slice}")
- endforeach()
+ if(NOT slices)
+ message(FATAL_ERROR "Pattern '${slice_glob}' did not match any files in ${collection_dir}.")
+ endif()
+ if(NOT found)
+ set(collections ${${COMPONENT}_SLICE_COLLECTIONS})
+ list(APPEND collections ${COLLECTION})
+ list(REMOVE_DUPLICATES collections)
+ __astscf_set_cache_string(${COMPONENT}_SLICE_COLLECTIONS "${collections}" "" ADVANCED)
+ endif()
+ set(found true)
+ list(APPEND all_slices ${slices})
endif()
endforeach()
- __astscf_set_cache_string(${COMPONENT}_SLICES "${${COMPONENT}_SLICES}" "" ADVANCED)
+ list(APPEND all_slices ${${COMPONENT}_${COLLECTION}_SLICES})
+ list(REMOVE_DUPLICATES all_slices)
+ __astscf_set_cache_string(${COMPONENT}_${COLLECTION}_SLICES "${all_slices}" "" ADVANCED)
endfunction()
+# Function which add a Slice file to a component. This handles all the magic of
+# creating the rules to run slice2cpp, adding the generated headers to the
+# include path, adding the generated .cpp file to the component, etc. The
+# generated files are placed in ${CMAKE_CURRENT_BINARY_DIR}/slice-<collection>.
+#
function(__astscf_component_add_one_slice COMPONENT COLLECTION COLLECTION_DIR SLICE)
# Append the needed include directories for Slice definitions
foreach(include ${SLICE_INCLUDE_DIRECTORIES})
@@ -619,7 +739,7 @@ function(__astscf_component_add_one_slice COMPONENT COLLECTION COLLECTION_DIR SL
include_directories(SYSTEM "${slice_out_file_dir}")
# Determine this Slice file's dependencies
- message(STATUS "Determining dependencies for ${slice_basename}")
+ message(STATUS "Determining dependencies for ${SLICE}")
execute_process(
COMMAND ${SLICE_COMPILER} ${slice_compiler_arguments} --depend ${COLLECTION_DIR}/${SLICE}
OUTPUT_VARIABLE raw_dependencies
@@ -686,8 +806,21 @@ function(__astscf_component_add_one_slice COMPONENT COLLECTION COLLECTION_DIR SL
DEPENDS ${sources} ${SLICE_COMPILER})
# the Slice and generated_files are now sources for the component
- set(file_list ${${COMPONENT}_SLICES} ${COLLECTION_DIR}/${SLICE} ${generated_files})
- set(${COMPONENT}_SLICES ${file_list} PARENT_SCOPE)
+ set(file_list ${${COMPONENT}_SOURCES} ${COLLECTION_DIR}/${SLICE} ${generated_files})
+ set(${COMPONENT}_SOURCES ${file_list} PARENT_SCOPE)
+endfunction()
+
+# Function which collects Slice files used by a component, causing them
+# to be translated, compiled and linked into the component
+#
+function(__astscf_component_slices COMPONENT)
+ foreach(collection ${${COMPONENT}_SLICE_COLLECTIONS})
+ set(collection_dir "${SLICE_COLLECTION_${collection}}")
+ foreach(slice ${${COMPONENT}_${collection}_SLICES})
+ __astscf_component_add_one_slice(${COMPONENT} ${collection} "${collection_dir}" "${slice}")
+ endforeach()
+ endforeach()
+ set(${COMPONENT}_SOURCES ${${COMPONENT}_SOURCES} PARENT_SCOPE)
endfunction()
# Function which collects libraries needed by a component
@@ -704,6 +837,9 @@ function(__astscf_component_libraries COMPONENT)
list(APPEND target_libs "${Boost_${lib}_LIBRARY}")
endforeach()
endif()
+ foreach(lib ${${COMPONENT}_SLICE_LIBRARIES})
+ list(APPEND target_libs "${SLICE_COLLECTION_${lib}_LIBRARY}")
+ endforeach()
set(component_libs ${target_libs} PARENT_SCOPE)
endfunction()
@@ -716,6 +852,7 @@ function(astscf_component_build_icebox COMPONENT)
__astscf_set_cache_string(${COMPONENT}_TYPE icebox "" ADVANCED)
find_package(Ice REQUIRED IceBox)
list(APPEND icelibs ${${COMPONENT}_ICE_LIBRARIES} ICEBOX)
+ __astscf_component_slices(${COMPONENT})
__astscf_component_libraries(${COMPONENT})
# Now we actually create the shared module
@@ -731,6 +868,7 @@ function(astscf_component_build_standalone COMPONENT)
endif()
message(STATUS "Building component ${COMPONENT} as a standalone executable")
__astscf_set_cache_string(${COMPONENT}_TYPE standalone "" ADVANCED)
+ __astscf_component_slices(${COMPONENT})
__astscf_component_libraries(${COMPONENT})
# Now we actually create the component
@@ -749,6 +887,7 @@ function(astscf_component_build_library COMPONENT)
endif()
message(STATUS "Building component ${COMPONENT} as a ${${COMPONENT}_LIBTYPE} library")
__astscf_set_cache_string(${COMPONENT}_TYPE library "" ADVANCED)
+ __astscf_component_slices(${COMPONENT})
__astscf_component_libraries(${COMPONENT})
# Now we actually create the component
commit 3c5bc4cc404a86074860741767ea394556240183
Merge: 2997fd6 8cfea72
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Mon Jun 13 15:58:03 2011 -0500
Merge branch 'master' into disintegrated-build
Conflicts:
AsteriskSCF.cmake
diff --cc AsteriskSCF.cmake
index eff7fc8,d039634..895cd13
--- a/AsteriskSCF.cmake
+++ b/AsteriskSCF.cmake
@@@ -264,146 -276,172 +270,150 @@@ macro(__astscf_compute_test_paths
endmacro()
# Function which initializes project specific things
-function(asterisk_scf_project NAME ICE_VERSION)
- if(ASTERISK_SCF_MASTER_PROJECT)
- # this is a sub-project, so just record the name and
- # move on
- set(ASTERISK_SCF_PROJECT "${NAME}" PARENT_SCOPE)
- set(ASTERISK_SCF_PROJECT_DIR "${CMAKE_CURRENT_SOURCE_DIR}" PARENT_SCOPE)
- return()
- else()
- set(ASTERISK_SCF_PROJECT "MASTER" PARENT_SCOPE)
- set(ASTERISK_SCF_MASTER_PROJECT true PARENT_SCOPE)
+function(astscf_project NAME ICE_VERSION)
+ if(ASTSCF_MASTER_PROJECT)
+ # this is a sub-project, so just record the name and
+ # move on
+ set(ASTSCF_PROJECT "${NAME}" PARENT_SCOPE)
+ set(ASTSCF_PROJECT_DIR "${CMAKE_CURRENT_SOURCE_DIR}" PARENT_SCOPE)
+ if(IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/slice")
+ set(SLICE_COLLECTION_PROJECT "${CMAKE_CURRENT_SOURCE_DIR}/slice" PARENT_SCOPE)
+ message(STATUS "Added project-specific Slice collection for '${NAME}' at ${CMAKE_CURRENT_SOURCE_DIR}/slice")
+ list(APPEND SLICE_INCLUDE_DIRECTORIES "${CMAKE_CURRENT_SOURCE_DIR}/slice")
+ set(SLICE_INCLUDE_DIRECTORIES ${SLICE_INCLUDE_DIRECTORIES} PARENT_SCOPE)
endif()
+ return()
+ else()
+ set(ASTSCF_PROJECT "MASTER" PARENT_SCOPE)
+ set(ASTSCF_MASTER_PROJECT true PARENT_SCOPE)
+ endif()
- message(STATUS "Setting up project ${NAME} for Ice version ${ICE_VERSION}")
-
- set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/lib" PARENT_SCOPE)
- set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/lib" PARENT_SCOPE)
- set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/bin" PARENT_SCOPE)
-
- set(CMAKE_INCLUDE_CURRENT_DIR true)
+ message(STATUS "Setting up project ${NAME} for Ice version ${ICE_VERSION}")
- # On Windows, IceBox C++ services must be compiled with some symbols exported;
- # the source code should use ASTERISK_SCF_ICEBOX_EXPORT to accomplish this, and this
- if(WIN32)
- message(STATUS "Setting ASTERISK_SCF_ICEBOX_EXPORT definition for Windows IceBox services")
- add_definitions(-DASTERISK_SCF_ICEBOX_EXPORT=__declspec\(dllexport\))
- else()
- add_definitions(-DASTERISK_SCF_ICEBOX_EXPORT=)
- endif()
+ set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/lib" PARENT_SCOPE)
+ set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/lib" PARENT_SCOPE)
+ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/bin" PARENT_SCOPE)
- # On Windows, 'debug' libraries should have a "d" suffix to indicate that they
- # are debug libraries
- if(WIN32)
- set_cache_var(CMAKE_DEBUG_POSTFIX "d")
- endif()
+ set(CMAKE_INCLUDE_CURRENT_DIR true)
- message(STATUS "Performing requirement checks for components")
- # set(Ice_DEBUG on)
- find_package(Ice 3.4 REQUIRED Ice IceUtil)
-
- # All components need the Ice library, and it needs the
- # IceUtil library (as do most components), so link
- # every component against those libraries at minimum
- set(ASTERISK_SCF_ICE_LIBRARIES ICE ICEUTIL PARENT_SCOPE)
-
- message(STATUS "Using Ice C++ headers from: ${ICE_INCLUDE_DIR}")
- # We mark the Ice include directory as a 'system' directory so that
- # the compiler will be less likely to generate warnings and/or errors
- # for the code in the Ice header files.
- include_directories(SYSTEM "${ICE_INCLUDE_DIR}")
-
- message(STATUS "Using Ice Slice files from: ${ICE_SLICE_DIR}")
- # We can't use asterisk_scf_slice_include_directories here because
- # the variable it sets will only be local to this function
- set(SLICE_INCLUDE_DIRECTORIES "${ICE_SLICE_DIR}" PARENT_SCOPE)
-
- # threading support required
- find_package(Threads REQUIRED)
- if(CMAKE_THREAD_LIBS_INIT)
- if(NOT CMAKE_HAVE_THREADS_LIBRARY)
- list(APPEND c_flags "${CMAKE_THREAD_LIBS_INIT}")
- list(APPEND cxx_flags "${CMAKE_THREAD_LIBS_INIT}")
- else()
- list(APPEND linker_flags "${CMAKE_THREAD_LIBS_INIT}")
- endif()
- endif()
+ # On Windows, IceBox C++ services and some other types of libraries must be compiled
+ # with some symbols exported; the source code should use ASTSCF_DLL_EXPORT to accomplish this
+ if(WIN32)
+ message(STATUS "Setting ASTSCF_DLL_EXPORT definition for Windows libraries")
+ add_definitions(-DASTSCF_DLL_EXPORT=__declspec\(dllexport\))
+ else()
+ add_definitions(-DASTSCF_DLL_EXPORT=)
+ endif()
- # If C++0x support is requested, use a compiler check to see if it is available
- # C++0x was on by default, but we disabled it due to problems with
- # Ubuntu 11.04.
- # See http://bugs.launchpad.net/ubuntu/+source/boost1.42/+bug/776860
- if(ENABLE_CPP0X)
- if(CMAKE_COMPILER_IS_GNUCXX)
- include(CheckCXXCompilerFlag)
- CHECK_CXX_COMPILER_FLAG(-std=c++0x HAVE_STD_CPP0X)
- if(HAVE_STD_CPP0X)
- add_definitions("-DCPP_ZEROX_SUPPORT")
- list(APPEND cxx_flags "-std=c++0x")
- message(STATUS "Support for C++0x Enabled")
- else()
- message(FATAL_ERROR "Compiler does not support C++0x")
- endif()
- endif()
- endif()
+ # On Windows, 'debug' libraries should have a "d" suffix to indicate that they
+ # are debug libraries
+ if(WIN32)
+ __astscf_set_cache_string(CMAKE_DEBUG_POSTFIX "d")
+ endif()
- if(CMAKE_COMPILER_IS_GNUC)
- list(APPEND c_flags_debug "-Wall" "-g3")
- list(APPEND c_flags_profile "-ftest-coverage" "-fprofile-arcs")
- endif()
+ message(STATUS "Performing requirement checks for components")
+ # set(Ice_DEBUG on)
+ find_package(Ice 3.4 REQUIRED Ice IceUtil)
+
+ # All components need the Ice library, and it needs the
+ # IceUtil library (as do most components), so link
+ # every component against those libraries at minimum
+ set(ASTSCF_ICE_LIBRARIES ICE ICEUTIL PARENT_SCOPE)
+
+ message(STATUS "Using Ice C++ headers from: ${ICE_INCLUDE_DIR}")
+ # We mark the Ice include directory as a 'system' directory so that
+ # the compiler will be less likely to generate warnings and/or errors
+ # for the code in the Ice header files.
+ include_directories(SYSTEM "${ICE_INCLUDE_DIR}")
+
+ set(SLICE_COLLECTION_Ice "${ICE_SLICE_DIR}")
+ list(APPEND SLICE_INCLUDE_DIRECTORIES "${ICE_SLICE_DIR}")
+ list(REMOVE_DUPLICATES SLICE_INCLUDE_DIRECTORIES)
+ set(SLICE_INCLUDE_DIRECTORIES ${SLICE_INCLUDE_DIRECTORIES} PARENT_SCOPE)
+
+ # threading support required
+ find_package(Threads REQUIRED)
+ if(CMAKE_THREAD_LIBS_INIT)
+ if(NOT CMAKE_HAVE_THREADS_LIBRARY)
+ list(APPEND c_flags "${CMAKE_THREAD_LIBS_INIT}")
+ list(APPEND cxx_flags "${CMAKE_THREAD_LIBS_INIT}")
+ else()
+ list(APPEND linker_flags "${CMAKE_THREAD_LIBS_INIT}")
- endif()
+ endif()
- # Use a compiler test for GCC to see if C++0x is supported; enable it if found.
- if(CMAKE_COMPILER_IS_GNUCXX)
- include(CheckCXXCompilerFlag)
- CHECK_CXX_COMPILER_FLAG(-std=c++0x HAVE_STD_CPP0X)
- if(HAVE_STD_CPP0X)
- add_definitions("-DCPP_ZEROX_SUPPORT")
- list(APPEND cxx_flags "-std=c++0x")
- message(STATUS "Support for C++0x Enabled")
- else()
- message(STATUS "Support for C++0x Disabled")
++ # If C++0x support is requested, use a compiler check to see if it is available
++ # C++0x was on by default, but we disabled it due to problems with
++ # Ubuntu 11.04.
++ # See http://bugs.launchpad.net/ubuntu/+source/boost1.42/+bug/776860
++ if(ENABLE_CPP0X)
+ if(CMAKE_COMPILER_IS_GNUCXX)
- list(APPEND cxx_flags ${ICE_CXX_FLAGS})
- list(APPEND cxx_flags_debug "-Wall" "-Wextra" "-g3")
- list(APPEND cxx_flags_debug "-Wshadow" "-Wmissing-format-attribute" "-Wformat=2" "-Wpointer-arith" "-Wconversion")
- include(CheckCXXCompilerFlag)
- CHECK_CXX_COMPILER_FLAG(-Wlogical-op HAVE_W_LOGICAL_OP)
- if(HAVE_W_LOGICAL_OP)
- list(APPEND cxx_flags_debug "-Wlogical-op")
- endif()
- list(APPEND cxx_flags_debug "-Werror")
- list(APPEND cxx_flags_profile "-ftest-coverage" "-fprofile-arcs")
- endif()
-
- if(CMAKE_SYSTEM MATCHES "SunOS.*")
- list(APPEND cxx_flags "-pthreads")
++ include(CheckCXXCompilerFlag)
++ CHECK_CXX_COMPILER_FLAG(-std=c++0x HAVE_STD_CPP0X)
++ if(HAVE_STD_CPP0X)
++ add_definitions("-DCPP_ZEROX_SUPPORT")
++ list(APPEND cxx_flags "-std=c++0x")
++ message(STATUS "Support for C++0x Enabled")
++ else()
++ message(FATAL_ERROR "Compiler does not support C++0x")
++ endif()
endif()
+ endif()
- append_to_var(CMAKE_C_FLAGS ${c_flags})
- append_to_var(CMAKE_C_FLAGS_DEBUG ${c_flags_debug})
- append_to_var(CMAKE_C_FLAGS_PROFILE ${c_flags_profile} ${c_flags_debug})
+ if(CMAKE_COMPILER_IS_GNUC)
+ list(APPEND c_flags_debug "-Wall" "-g3")
+ list(APPEND c_flags_profile "-ftest-coverage" "-fprofile-arcs")
+ endif()
- append_to_var(CMAKE_CXX_FLAGS ${cxx_flags})
- append_to_var(CMAKE_CXX_FLAGS_DEBUG ${cxx_flags_debug})
- append_to_var(CMAKE_CXX_FLAGS_PROFILE ${cxx_flags_profile} ${cxx_flags_debug})
+ if(CMAKE_COMPILER_IS_GNUCXX)
+ list(APPEND cxx_flags ${ICE_CXX_FLAGS})
+ list(APPEND cxx_flags_debug "-Wall" "-Wextra" "-g3")
+ list(APPEND cxx_flags_debug "-Wshadow" "-Wmissing-format-attribute" "-Wformat=2" "-Wpointer-arith" "-Wconversion")
+ # When building shared objects (libraries or modules), the linker normally
+ # doesn't try to ensure that all symbols referenced by the code linked
+ # into the object have been satisfied... which means that unresolved
+ # symbols won't be found until runtime. This flag tells the linker
+ # to do that resolution at link time, and report an error if a symbol
+ # is unresolved.
+ list(APPEND cxx_flags_debug "-Wl,--no-undefined")
+ include(CheckCXXCompilerFlag)
+ CHECK_CXX_COMPILER_FLAG(-Wlogical-op HAVE_W_LOGICAL_OP)
+ if(HAVE_W_LOGICAL_OP)
+ list(APPEND cxx_flags_debug "-Wlogical-op")
+ endif()
+ list(APPEND cxx_flags_debug "-Werror")
+ list(APPEND cxx_flags_profile "-ftest-coverage" "-fprofile-arcs")
+ endif()
- append_to_var(CMAKE_EXE_LINKER_FLAGS ${linker_flags})
- append_to_var(CMAKE_MODULE_LINKER_FLAGS ${linker_flags})
- append_to_var(CMAKE_SHARED_LINKER_FLAGS ${linker_flags})
+ if(CMAKE_SYSTEM MATCHES "SunOS.*")
+ list(APPEND cxx_flags "-pthreads")
+ endif()
- # Boost is required
- # Only specify those versions that are not "known" by default for
- # the oldest version of cmake supported.
- #
- set(Boost_ADDITIONAL_VERSIONS "1.44" "1.44.0" "1.45" "1.45.0" "1.46" "1.46.0" "1.46.1")
- find_package(Boost ${MIN_BOOST_VERSION} REQUIRED)
- set(Boost_CORE_FOUND "bazinga" PARENT_SCOPE)
- set(Boost_CORE_FOUND "bazinga")
+ __astscf_append_to_var(CMAKE_C_FLAGS ${c_flags})
+ __astscf_append_to_var(CMAKE_C_FLAGS_DEBUG ${c_flags_debug})
+ __astscf_append_to_var(CMAKE_C_FLAGS_PROFILE ${c_flags_profile} ${c_flags_debug})
- compute_test_paths()
+ __astscf_append_to_var(CMAKE_CXX_FLAGS ${cxx_flags})
+ __astscf_append_to_var(CMAKE_CXX_FLAGS_DEBUG ${cxx_flags_debug})
+ __astscf_append_to_var(CMAKE_CXX_FLAGS_PROFILE ${cxx_flags_profile} ${cxx_flags_debug})
- message(STATUS "Passed requirement checks for CXX components")
-endfunction()
+ __astscf_append_to_var(CMAKE_EXE_LINKER_FLAGS ${linker_flags})
+ __astscf_append_to_var(CMAKE_MODULE_LINKER_FLAGS ${linker_flags})
+ __astscf_append_to_var(CMAKE_SHARED_LINKER_FLAGS ${linker_flags})
-# Function which initializes a component for building
-function(asterisk_scf_component_init COMPONENT)
- message(STATUS "Setting up to build component ${COMPONENT}")
- set(ASTERISK_SCF_${COMPONENT} Bob PARENT_SCOPE)
-endfunction()
+ # Boost is required
+ # Only specify those versions that are not "known" by default for
+ # the oldest version of CMake supported.
+ #
+ set(Boost_ADDITIONAL_VERSIONS "1.44" "1.44.0" "1.45" "1.45.0" "1.46" "1.46.0" "1.46.1")
+ find_package(Boost ${MIN_BOOST_VERSION} REQUIRED)
+ set(Boost_CORE_FOUND "bazinga" PARENT_SCOPE)
+ set(Boost_CORE_FOUND "bazinga")
+ include_directories(SYSTEM ${Boost_INCLUDE_DIR})
+ link_directories(${Boost_LIBRARY_DIRS})
-# Find a Boost library.
-function(find_Boost_library LIBRARY)
- string(TOUPPER ${LIBRARY} libtag)
- if(NOT Boost_${libtag}_FOUND)
- find_package(Boost REQUIRED ${LIBRARY})
- endif()
- if(NOT Boost_${libtag}_FOUND)
- message(FATAL_ERROR "Boost library ${LIBRARY} not found")
- endif()
-endfunction()
+ __astscf_compute_test_paths()
-# Function which adds Boost libraries needed by a component
-function(asterisk_scf_component_add_boost_libraries COMPONENT)
- if(NOT ARGN)
- message(FATAL_ERROR "You must pass at least one library to this function")
- endif()
- set(libs ${${COMPONENT}_BOOST_LIBRARIES})
- # By default we are disabling boost auto-linking and specifying dynamic linking.
- add_definitions(-DBOOST_ALL_NO_LIB -DBOOST_ALL_DYN_LINK)
- foreach(lib ${ARGN})
- find_Boost_library(${lib})
- string(TOUPPER "${lib}" lib)
- list(APPEND libs ${lib})
- endforeach()
- list(REMOVE_DUPLICATES libs)
- set(${COMPONENT}_BOOST_LIBRARIES ${libs} PARENT_SCOPE)
- include_directories(SYSTEM ${Boost_INCLUDE_DIR})
- link_directories(${Boost_LIBRARY_DIRS})
+ message(STATUS "Passed requirement checks for CXX components")
endfunction()
# Ensures that a list of paths are all absolute paths.
commit 2997fd659feef09abd5026bbfc5ba953009cf266
Author: Kevin P. Fleming <kpfleming at digium.com>
Date: Mon Jun 13 15:53:59 2011 -0500
Ensure that shared objects have no unresolved symbols.
When doing builds on Linux, the linker will now ensure that all symbols
referenced by the object files linked into the module or library are
resolvable at link time (in other words, all libraries needed by the
code in the module/library have been specified to the linker). If any
symbols cannot be resolved, an error will be generated at link time (rather
than later at run time).
diff --git a/AsteriskSCF.cmake b/AsteriskSCF.cmake
index 4bdfcad..eff7fc8 100644
--- a/AsteriskSCF.cmake
+++ b/AsteriskSCF.cmake
@@ -358,6 +358,13 @@ function(astscf_project NAME ICE_VERSION)
list(APPEND cxx_flags ${ICE_CXX_FLAGS})
list(APPEND cxx_flags_debug "-Wall" "-Wextra" "-g3")
list(APPEND cxx_flags_debug "-Wshadow" "-Wmissing-format-attribute" "-Wformat=2" "-Wpointer-arith" "-Wconversion")
+ # When building shared objects (libraries or modules), the linker normally
+ # doesn't try to ensure that all symbols referenced by the code linked
+ # into the object have been satisfied... which means that unresolved
+ # symbols won't be found until runtime. This flag tells the linker
+ # to do that resolution at link time, and report an error if a symbol
+ # is unresolved.
+ list(APPEND cxx_flags_debug "-Wl,--no-undefined")
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG(-Wlogical-op HAVE_W_LOGICAL_OP)
if(HAVE_W_LOGICAL_OP)
commit 8cfea72afaa1a820910a25bcdfbe4bec3ed99c9d
Author: David M. Lee <dlee at digium.com>
Date: Mon Jun 13 11:03:05 2011 -0500
Removed cmake dep on pjproject's config_site.h
This resolves a couple of issues.
* make clean no longer trashes config_site.h
* incremental builds no longer needlessly regenerate pjproject deps.
... 33523 lines suppressed ...
--
asterisk-scf/integration/routing.git
More information about the asterisk-scf-commits
mailing list