[asterisk-scf-commits] asterisk-scf/integration/ice-util-c++.git branch "master" updated.

[Commits to the Asterisk SCF project code repositories]

branch "master" has been updated
       via  f7886c4b3ac299550ae6c81797c22d06daf82c27 (commit)
       via  84b79d8b0ecfdb8cf660b900c36681e918fd8890 (commit)
      from  e95b464acefee5d0d01a00837fd30a70eb4c0bf5 (commit)

Summary of changes:
 ProxyWrapper/src/ProxyWrapper.cpp |    3 ++-
 ProxyWrapper/src/ProxyWrapper.h   |   21 ++++-----------------
 2 files changed, 6 insertions(+), 18 deletions(-)


- Log -----------------------------------------------------------------
commit f7886c4b3ac299550ae6c81797c22d06daf82c27
Author: Joshua Colp <jcolp at digium.com>
Date:   Tue Oct 26 13:24:49 2010 -0400

    Remove comments about possible improvements because in reality it would be very scary to go down the two routes... very scary.

diff --git a/ProxyWrapper/src/ProxyWrapper.h b/ProxyWrapper/src/ProxyWrapper.h
index 3dbedc5..65a6f4e 100644
--- a/ProxyWrapper/src/ProxyWrapper.h
+++ b/ProxyWrapper/src/ProxyWrapper.h
@@ -36,21 +36,7 @@ namespace ProxyWrapper
  * a second time via the service locator.
  *
  * An improvement that would be nice would be to make the recovery
- * more general purpose. There are a couple of ways to try this.
- *
- * 1. Always ice_ping as the first operation of the -> operator
- * overload. This way we can be sure that the servant we are trying
- * to talk to is still reachable. If it's not, then we may be able to
- * ask the service locator for a new proxy and proceed. The advantage 
- * to this method is that we only ping proxies when we need them. The
- * disadvantage is that we add an extra RPC for each proxy operation.
- *
- * 2. Have a background thread that periodically ice_pings all wrapped
- * proxies. This thread can be responsible for alerting a proxy wrapper
- * to try to get a new proxy if one is unreachable. The advantage here is
- * that for RPC-heavy operations, we're not doubling the amount of RPCs
- * by pinging every time. The disadvantage is that we could be needlessly
- * pinging servants for essentially dormant services.
+ * more general purpose.
  */
 template <class P>
 class ProxyWrapper

commit 84b79d8b0ecfdb8cf660b900c36681e918fd8890
Author: Joshua Colp <jcolp at digium.com>
Date:   Tue Oct 26 13:23:12 2010 -0400

    The ProxyWrapper template is not specific to the SIP component, it can be used generally.

diff --git a/ProxyWrapper/src/ProxyWrapper.cpp b/ProxyWrapper/src/ProxyWrapper.cpp
index 8e6a17e..25281d6 100644
--- a/ProxyWrapper/src/ProxyWrapper.cpp
+++ b/ProxyWrapper/src/ProxyWrapper.cpp
@@ -18,11 +18,12 @@
 
 namespace AsteriskSCF
 {
-namespace SipChannelService
+namespace ProxyWrapper
 {
  /*
  * This .cpp is a temporary solution to get a CMakeProject that consists only of header files. 
  */
 
 };
+
 };
diff --git a/ProxyWrapper/src/ProxyWrapper.h b/ProxyWrapper/src/ProxyWrapper.h
index 6c23b84..3dbedc5 100644
--- a/ProxyWrapper/src/ProxyWrapper.h
+++ b/ProxyWrapper/src/ProxyWrapper.h
@@ -22,7 +22,7 @@
 
 namespace AsteriskSCF
 {
-namespace SipChannelService
+namespace ProxyWrapper
 {
 
 /**
@@ -158,5 +158,6 @@ private:
 	bool mInitialized;
 };
 
-}; // end SipChannelService
+}; // end ProxyWrapper
+
 }; // end AsteriskSCF

-----------------------------------------------------------------------


-- 
asterisk-scf/integration/ice-util-c++.git