[asterisk-scf-commits] asterisk-scf/integration/slice.git branch "session_cookies" updated.

Commits to the Asterisk SCF project code repositories asterisk-scf-commits at lists.digium.com
Tue Dec 7 10:54:50 CST 2010


branch "session_cookies" has been updated
       via  c35b6ff1ebd767530b6ce828a936bc0209aa893a (commit)
      from  fd9831065fa9e9799c7a6c200f0008ef50d76d22 (commit)

Summary of changes:
 SessionCommunications/SessionCommunicationsIf.ice |   74 +++------------------
 1 files changed, 10 insertions(+), 64 deletions(-)


- Log -----------------------------------------------------------------
commit c35b6ff1ebd767530b6ce828a936bc0209aa893a
Author: Kevin P. Fleming <kpfleming at digium.com>
Date:   Tue Dec 7 10:52:33 2010 -0600

    Remove 'interest management' by session manager.
    
    Based on discussions on CR-ASTSCF-13, it was decided that it wasn't
    appropriate (or efficient) for the session manager to have to track
    which cookie types each listener wants to receive. This commit
    simplifies the interfaces a bit by removing the cookie templates;
    now the session manager will send the entire list of cookies stored
    on the session to each listener when an event occurs.

diff --git a/SessionCommunications/SessionCommunicationsIf.ice b/SessionCommunications/SessionCommunicationsIf.ice
index 49aa661..b9b68c2 100644
--- a/SessionCommunications/SessionCommunicationsIf.ice
+++ b/SessionCommunications/SessionCommunicationsIf.ice
@@ -157,9 +157,7 @@ module V1
 	 *
 	 * @param source The session the event occurred on.
 	 *
-	 * @param cookies Any cookies present on the session which have types
-	 *        that match the template types the listener provided when it
-	 *        added itself to the session via the addListener() operation.
+	 * @param cookies Any cookies present on the session. which have types
 	 */
 	void connected(Session* source, SessionCookies cookies);
 
@@ -168,9 +166,7 @@ module V1
 	 *
 	 * @param source The session the event occurred on.
 	 *
-	 * @param cookies Any cookies present on the session which have types
-	 *        that match the template types the listener provided when it
-	 *        added itself to the session via the addListener() operation.
+	 * @param cookies Any cookies present on the session.
 	 */
 	void flashed(Session* source, SessionCookies cookies);
 
@@ -179,9 +175,7 @@ module V1
 	 *
 	 * @param source The session the event occurred on.
 	 *
-	 * @param cookies Any cookies present on the session which have types
-	 *        that match the template types the listener provided when it
-	 *        added itself to the session via the addListener() operation.
+	 * @param cookies Any cookies present on the session.
 	 */
 	void held(Session* source, SessionCookies cookies);
 
@@ -190,9 +184,7 @@ module V1
 	 *
 	 * @param source The session the event occurred on.
 	 *
-	 * @param cookies Any cookies present on the session which have types
-	 *        that match the template types the listener provided when it
-	 *        added itself to the session via the addListener() operation.
+	 * @param cookies Any cookies present on the session.
 	 *
 	 * @param response An code indentifying the details of the ongoing progress.
 	 */
@@ -203,9 +195,7 @@ module V1
 	 *
 	 * @param source The session the event occurred on.
 	 *
-	 * @param cookies Any cookies present on the session which have types
-	 *        that match the template types the listener provided when it
-	 *        added itself to the session via the addListener() operation.
+	 * @param cookies Any cookies present on the session.
 	 */
 	void ringing(Session* source, SessionCookies cookies);
 
@@ -214,9 +204,7 @@ module V1
 	 *
 	 * @param source The session the event occurred on.
 	 *
-	 * @param cookies Any cookies present on the session which have types
-	 *        that match the template types the listener provided when it
-	 *        added itself to the session via the addListener() operation.
+	 * @param cookies Any cookies present on the session.
 	 *
 	 * @param response An code describing the why the session stopped.
 	 */
@@ -227,9 +215,7 @@ module V1
 	 *
 	 * @param source The session the event occurred on.
 	 *
-	 * @param cookies Any cookies present on the session which have types
-	 *        that match the template types the listener provided when it
-	 *        added itself to the session via the addListener() operation.
+	 * @param cookies Any cookies present on the session.
 	 */
 	void unheld(Session* source, SessionCookies cookies);
     };
@@ -254,18 +240,6 @@ module V1
 	 *
 	 * @param listener An instance of a SessionListener object.
 	 *
-	 * @param cookieTypes A sequence of zero or more concrete objects,
-	 *        each of which are of a type derived from SessionCookie.
-	 *        The session manager will store this sequence of cookies
-	 *        with the Session, so that it can use them as a template
-	 *        to know which types of cookies should be sent to this
-	 *        listener when events occur. Before invoking an operation
-	 *        on the listener itself, the session manager will make
-	 *        copies of all the cookies currently attached to the session
-	 *        whose types match (exactly) any template cookie provided
-	 *        in this sequence, and include them as a parameter to the
-	 *        operation invocation on the listener.
-	 *
 	 * @return A SessionInfo object containing the current state of the session.
 	 *       This allows "listeners" to be configured with a some initial state
 	 *       to give context to future notifications.
@@ -273,10 +247,8 @@ module V1
 	 * @see SessionListener
 	 *
 	 * @see SessionInfo
-	 *
-	 * @see SessionCookies
 	 */
-	SessionInfo addListener(SessionListener* listener, SessionCookies cookieTypes);
+	SessionInfo addListener(SessionListener* listener);
 
 	/**
 	 * Set (or replace) cookies on the session.
@@ -414,21 +386,9 @@ module V1
 	 *
 	 * @param listener A proxy to the Listener to add to the Session.
 	 *
-	 * @param cookieTypes A sequence of zero or more concrete objects,
-	 *        each of which are of a type derived from SessionCookie.
-	 *        The session manager will store this sequence of cookies
-	 *        with the Session, so that it can use them as a template
-	 *        to know which types of cookies should be sent to this
-	 *        listener when events occur. Before invoking an operation
-	 *        on the listener itself, the session manager will make
-	 *        copies of all the cookies currently attached to the session
-	 *        whose types match (exactly) any template cookie provided
-	 *        in this sequence, and include them as a parameter to the
-	 *        operation invocation on the listener.
-	 *
 	 * @return A current copy of the session information.
 	 */
-	SessionInfo setBridge(Bridge* newBridge, SessionListener* listener, SessionCookies cookieTypes);
+	SessionInfo setBridge(Bridge* newBridge, SessionListener* listener);
 
 	/**
 	 * Removes this Session from it's associated Bridge.
@@ -598,25 +558,11 @@ module V1
 	 *    newly created session. May be a nil reference if an initial listener is not
 	 *    required.
 	 *
-	 * @param cookieTypes A sequence of zero or more concrete objects,
-	 *        each of which are of a type derived from SessionCookie.
-	 *        The session manager will store this sequence of cookies
-	 *        with the Session, so that it can use them as a template
-	 *        to know which types of cookies should be sent to this
-	 *        listener when events occur. Before invoking an operation
-	 *        on the listener itself, the session manager will make
-	 *        copies of all the cookies currently attached to the session
-	 *        whose types match (exactly) any template cookie provided
-	 *        in this sequence, and include them as a parameter to the
-	 *        operation invocation on the listener.
-	 *
 	 * @return A newly created session object for the destination.
 	 *
 	 * @see SessionListener
-	 *
-	 * @see SessionCookies
 	 */
-	Session* createSession(string destination, SessionListener* listener, SessionCookies cookieTypes);
+	Session* createSession(string destination, SessionListener* listener);
 
 	/**
 	 * Returns the active sessions for this session endpoint.

-----------------------------------------------------------------------


-- 
asterisk-scf/integration/slice.git



More information about the asterisk-scf-commits mailing list