<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">Le 01/04/2016 14:00, Joshua Colp a
écrit :<br>
</div>
<blockquote cite="mid:56FE62FA.4080506@digium.com" type="cite">Jean
Aunis wrote:
<br>
<blockquote type="cite">Hello,
<br>
<br>
As described in the issue ASTERISK-25866
<br>
<a class="moz-txt-link-rfc2396E" href="https://issues.asterisk.org/jira/browse/ASTERISK-25866"><https://issues.asterisk.org/jira/browse/ASTERISK-25866></a>,
it appears
<br>
that ChanSpy is randomly loosing audio frames, because it sets
the flags
<br>
AST_AUDIOHOOK_TRIGGER_SYNC and AST_AUDIOHOOK_SMALL_QUEUE when
creating
<br>
the audiohook: these option cause the audiohook's queue to be
flushed of
<br>
"old" frames at very short intervals.
<br>
<br>
I have submitted a patch on gerrit which does two things :
<br>
1- do not set the flag AST_AUDIOHOOK_TRIGGER_SYNC if ChanSpy has
been
<br>
called with the option "o": in this case we only listen to the
audio
<br>
coming from this channel so this flag is useless
<br>
2- create a new option "l" which prevents the flag
<br>
AST_AUDIOHOOK_SMALL_QUEUE from being set. I find it better than
just
<br>
removing the flag in all cases, because this may introduce some
delay in
<br>
the audio, which may not be acceptable for many ChanSpy users.
<br>
<br>
What do you think of the idea ?
<br>
</blockquote>
<br>
I think this is fine, provided there is still some high ceiling
value. Allowing a queue to potentially grow out of control would
be bad.
<br>
<br>
I think if we were able to switch things to using a timer instead
we could actually get rid of this synchronization. It exists
because it has to bring together two directions and then provide
the media.
<br>
<br>
I also don't see your review on gerrit. Java (yay Java!) ran out
of memory somewhat overnight it seems and I've restarted gerrit
this morning. That may have caused the review to not actually get
submitted. If you do so again it should work fine and if not we
can help figure out why.
<br>
<br>
Cheers,
<br>
<br>
</blockquote>
I just pushed again, but it seems the branch was not created. I used
the following command (taken from the wiki):<br>
<br>
<font face="Courier New, Courier, monospace">git review -t
ASTERISK-25866</font><br>
<br>
And here is the output :<br>
<br>
<font face="Courier New, Courier, monospace">remote: Processing
changes: new: 1, refs: 1, done <br>
remote: <br>
remote: New Changes: <br>
remote: <a class="moz-txt-link-freetext" href="https://gerrit.asterisk.org/2520">https://gerrit.asterisk.org/2520</a> app_chanspy: reduce
audio loss on the spying channel. <br>
remote: <br>
To <a class="moz-txt-link-abbreviated" href="mailto:ssh://PrescomJA@gerrit.asterisk.org:29418/asterisk">ssh://PrescomJA@gerrit.asterisk.org:29418/asterisk</a><br>
* [new branch] HEAD -> refs/publish/master/ASTERISK-25866</font><br>
<br>
Best regards<br>
<br>
Jean Aunis<br>
</body>
</html>