<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3822/">https://reviewboard.asterisk.org/r/3822/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 17th, 2014, 5:38 p.m. EDT, <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3822/diff/3/?file=64775#file64775line176" style="color: black; font-weight: bold; text-decoration: underline;">/team/group/media_formats-reviewed-trunk/main/format_compatibility.c</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">uint64_t ast_format_compatibility_codec2bitfield(const struct ast_codec *codec)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">struct</span> <span class="n">ast_format</span> <span class="o">*</span><span class="n">ast_format_compatibility_bitfield2format</span><span class="p">(</span><span class="kt">uint64_t</span> <span class="n">bitfield</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure this should be moved from the core since the conversion the other way is used by other modules.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moving it back into the core if needed is easier than moving it out of the core after it is part of a release. I can move it back now if you'd like, I took it out of the core on the assumption that we want to discourage use of these functions where possible.
If I don't hear back from you I'll move it back later tonight.</pre>
<br />
<p>- Corey</p>
<br />
<p>On July 17th, 2014, 4:06 p.m. EDT, Corey Farrell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Corey Farrell.</div>
<p style="color: grey;"><i>Updated July 17, 2014, 4:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Move all ast_codec_pref functions to channels/iax2/codec_pref.c.
* Move ast_format_compatibility_cap2bitfield, ast_format_compatibility_bitfield2cap and ast_format_compatibility_bitfield2format to channels/iax2/format_compatibility.c
* Change prefix of all moved functions from ast_ to iax2_.
* Fix comment in include/asterisk/config_options.h
ast_format_compatibility_format2bitfield and ast_format_compatibility_codec2bitfield are the only functions that remain in main/format_compatibility.c as they are used by other modules.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile only.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/media_formats-reviewed-trunk/main/format_compatibility.c <span style="color: grey">(418850)</span></li>
<li>/team/group/media_formats-reviewed-trunk/include/asterisk/format_compatibility.h <span style="color: grey">(418850)</span></li>
<li>/team/group/media_formats-reviewed-trunk/include/asterisk/config_options.h <span style="color: grey">(418850)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/iax2/parser.c <span style="color: grey">(418850)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/iax2/include/format_compatibility.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/iax2/include/codec_pref.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/iax2/format_compatibility.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/iax2/codec_pref.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/chan_iax2.c <span style="color: grey">(418850)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3822/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>