<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3419/">https://reviewboard.asterisk.org/r/3419/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2014, 9:56 a.m. CDT, <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3419/diff/1/?file=57067#file57067line58" style="color: black; font-weight: bold; text-decoration: underline;">./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/start-call.xml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><recv</span> <span class="na">request=</span><span class="s">"INFO"</span><span class="nt">/></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This needs to send a response 200 OK back and should also check the contents of the INFO request.</pre>
</blockquote>
<p>On April 10th, 2014, 1:35 p.m. CDT, <b>Benjamin Keith Ford</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I understand why the 200 OK should be sent, but as for the INFO request, I'm curious why it needs to check the contents since this test is just to see if a picture update event shows up or not. Is it just for a confirmation of what kind of packet it is receiving?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That is correct. INFO requests are used for more than just fast picture updates.</pre>
<br />
<p>- opticron</p>
<br />
<p>On April 4th, 2014, 4:12 p.m. CDT, Benjamin Keith Ford wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Benjamin Keith Ford.</div>
<p style="color: grey;"><i>Updated April 4, 2014, 4:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23562">ASTERISK-23562</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test verifies that when two PJSIP endpoints are in a call with video enabled, fast picture updates can be received when one endpoint requests INFO. The following code was added as well to create a TestEvent that spawns when the INFO is created:
Index: channels/chan_pjsip.c
===================================================================
--- channels/chan_pjsip.c (revision 408267)
+++ channels/chan_pjsip.c (working copy)
@@ -57,6 +57,7 @@
#include "asterisk/stasis_endpoints.h"
#include "asterisk/stasis_channels.h"
#include "asterisk/indications.h"
+#include "asterisk/manager.h"
#include "asterisk/res_pjsip.h"
#include "asterisk/res_pjsip_session.h"
@@ -1112,8 +1113,14 @@
ao2_cleanup(channel->session);
}
}
+ manager_event(EVENT_FLAG_TEST, "TestEvent",
+ "Type: AST_CONTROL_VIDUPDATE\r\n"
+ "Result: Success");
} else {
res = -1;
+ manager_event(EVENT_FLAG_TEST, "TestEvent",
+ "Type: AST_CONTROL_VIDUPDATE\r\n"
+ "Result: Failure");
}
break;
case AST_CONTROL_CONNECTED_LINE:</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/start-call.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/receive-call.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(4918)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3419/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>