<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3062/">https://reviewboard.asterisk.org/r/3062/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Tzafrir Cohen.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2014, 5:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I realised that the main reason I needed a wrapper script was for running a different instance of Asterisk with live_ast. This requires editing a number of pathes, which is sub-optimal.
I ended up having live_ast provide its own systemd unit under live/asterisk-live.service . The user will need to copy that file to /etc/systemd/system if the user wants to add asterisk-live as a separate service (stop asterisk, start asterisk-live).
I set the working directory to /var/lib/asterisk . As the working directory is writable, there is no reason to actively disable core files and thus adding -g to the command line looks like a good idea.
I also added example cleanup script that should do the same job as the cleanup code in safe_asterisk (though it does not report failures). I decided that /var/spool/asterisk/cores is a good storage for core files. This script is an example only and is not installed by default.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Installs a systemd service file for Asterisk.
Systeemd is the new "one daemon to rule them all" for Linux: http://www.freedesktop.org/wiki/Software/systemd/
On systems without systemd this should be just a harmless (though maybe annoying) text file.
This is aimed at replacing safe_asterisk with a more reliable main loop. It almost does that. Is still fails to handle failures, as it seems that systemd's ExecPostStop command does not get the exist status of the stopped command.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/contrib/scripts/live_ast <span style="color: grey">(407855)</span></li>
<li>/trunk/contrib/scripts/asterisk_cleanup <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/asterisk.service <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/Makefile <span style="color: grey">(407855)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3062/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>