<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3178/">https://reviewboard.asterisk.org/r/3178/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2014, 12:18 a.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3178/diff/1/?file=53410#file53410line316" style="color: black; font-weight: bold; text-decoration: underline;">/main/format_cap_ng.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">316</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">317</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">AST_LIST_REMOVE_CURRENT</span><span class="p">(</span><span class="n">entry</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">318</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">AST_VECTOR_REMOVE_CMP_ORDERED</span><span class="p">(</span><span class="o">&</span><span class="n">cap</span><span class="o">-></span><span class="n">preference_order</span><span class="p">,</span> <span class="n">framed</span><span class="o">-></span><span class="n">format</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">319</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">FORMAT_CAP_FRAMED_ELEM_CMP</span><span class="p">,</span> <span class="n">FORMAT_CAP_FRAMED_ELEM_CLEANUP</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">320</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">ao2_ref</span><span class="p">(</span><span class="n">framed</span><span class="p">,</span> <span class="o">-</span><span class="mi">1</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should the call to AST_VECTOR_REMOVE_CMP_ORDERED be outside the list traversal?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope! That macro removes based on the specific format pointer provided to it, and since this function is for removing by type it has to remove multiple formats.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On February 7th, 2014, 2:59 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2014, 2:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change has a few things in it:
1. Some media related things have been moved around to more logical places or their own parts (smoothers).
2. A new implementation of media formats according to https://wiki.asterisk.org/wiki/display/AST/Media+Format+Rewrite. The implementation doesn't completely adhere to the design since I tweaked things but it mostly conforms.
3. Unit tests for the above implementation.
What I'd like feedback on is the actual media formats implementation and the API design itself. Is this something you would be comfortable using?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran unit tests, all passed.
Note: I know AO2 throws a fit and it's because a container isn't getting initialized. Getting said container initialized requires beginning the hacking apart process.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/tests/test_format_cap.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/tests/test_format_cache.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/tests/test_core_format.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/tests/test_core_codec.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/res_rtp_asterisk.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/res/res_fax.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/main/smoother.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/frame.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/main/format_ng.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/format_cap_ng.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/format_cache.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/format.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/main/codec_builtin.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/codec.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/asterisk.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/vector.h <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/smoother.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/frame.h <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/format_ng.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/format_cap_ng.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/format_cache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/format.h <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/codec.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3178/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>