<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3132/">https://reviewboard.asterisk.org/r/3132/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 24th, 2014, 9:17 a.m. CST, <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3132/diff/2/?file=53020#file53020line16" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/channels/pjsip/tests.yaml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p-Indicator">-</span> <span class="l-Scalar-Plain">dir</span><span class="p-Indicator">:</span> <span class="s">'sdp_offer_answer'</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch seems to be missing all the tests.yaml files along the new path specifying subdirectories and tests.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually I missed svn add'ing a large number of files, now fixed.</pre>
<br />
<p>- Scott</p>
<br />
<p>On January 28th, 2014, 1:19 p.m. CST, Scott Griepentrog wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Griepentrog.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2014, 1:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23018">ASTERISK-23018</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is just a copy of tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host with allow=all instead of allow=ulaw.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It correctly fails without the 3131 code implemented.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(4563)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/udp/offer_ulaw_allow_all/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv6/tcp/offer_ulaw_allow_all/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/tcp/offer_ulaw_allow_all/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3132/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>