<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3096/">https://reviewboard.asterisk.org/r/3096/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 9th, 2014, 3:55 p.m. CST, <b>Kevin Harwell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3096/diff/1/?file=50801#file50801line229" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/lib/python/asterisk/bridge_test_case.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __init__(self, test_path = '', test_config = None):</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __init__(self, test_path='', test_config=None):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="p">(</span><span class="n">ami</span><span class="p">,</span> <span class="n">event</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More a question of curisiosity here, but is there a reason a return value was added? It doesn't appear to be used.
(was added in a few other methods too)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mostly just added because it gets rid of the Pylint "parameter not used" error.
In the end, there's two pseudo-useful reasons to have it here beyond that:
(1) If, for whatever reason, starpy was modified to actually call the event callbacks in a deferred, then each AMI event callback would be returning something to pass to the next callback, which is generally nice
(2) It doesn't hurt anything?
But really, I wouldn't care if someone didn't bother with this, or we removed them.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 9th, 2014, 3:55 p.m. CST, <b>Kevin Harwell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3096/diff/1/?file=50841#file50841line63" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/lib/python/asterisk/sipp.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">if</span></span><span class="hl"> </span><span class="s"><span class="hl">'</span>fail<span class="hl">-on-</span>any<span class="hl">'</span></span><span class="hl"> </span><span class="ow"><span class="hl">in</span></span> <span class="bp">self</span><span class="o">.</span><span class="n">_test_config</span><span class="p"><span class="hl">:</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="bp"><span class="hl">self</span></span><span class="o"><span class="hl">.</span></span><span class="n"><span class="hl">_</span>fail<span class="hl">_on_</span>any</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span> <span class="bp">self</span><span class="o">.</span><span class="n">_test_config</span><span class="o"><span class="hl">.</span></span><span class="n"><span class="hl">get</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">'fail-on-any'</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="ow"><span class="hl">or</span></span><span class="hl"> </span><span class="bp"><span class="hl">True</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Won't this always set _fail_on_any to true even if the option is found and is returned as false?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup - I shouldn't have used this to extract the parameter here. I'll double check that I didn't introduce any others as well.</pre>
<br />
<p>- Matt</p>
<br />
<p>On December 30th, 2013, 3:52 p.m. CST, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2013, 3:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does a reasonable job of making the Python code in lib/python/asterisk compliant with PEP 8. (Reasonable being > 9 on the pylint "how am I doing?" code rating)
A few disclaimers:
(1) This patch does not go into the python code for the tests themselves, other than to make the tests run. Making the individual tests PEP 8 compliant would be nice, but it's a whole lot more work with less benefit.
(2) Not *everything* was cleaned up in the libraries. In general, I tried to get the vast majority of findings, but there are a few minor nitpicks here and there.
(3) This patch is scarier than it looks. No semantics were changed in the process of doing this: this is all just formatting/guidelines/etc.
Note that this will break the world, however, as it renames a number of python modules, functions, etc.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything still runs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/udptl_v6/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/udptl/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/skeleton_test/run-test <span style="color: grey">(UNKNOWN)</span></li>
<li>/asterisk/trunk/tests/rest_api/request-bodies/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/rest_api/content-type/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/rest_api/authentication/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/rest_api/CORS/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/regressions/M18882/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/predial/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/pbx/pbx_lua_goto/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/pbx/pbx_lua_background/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/pbx/merge_contexts/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/pbx/dialplan_reload/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/pbx/dialplan/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/pbx/callerid_match/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/pbx/call-files/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/masquerade/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/manager/login/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/manager/danger/safe/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/manager/danger/dangerous/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/manager/bridge_actions/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/manager/acl-login/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/hangup/handlers_endbeforehexten/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/hangup/handlers/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/funcs/func_srv/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/funcs/func_presencestate/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/funcs/func_jitterbuffer/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/funcs/func_global/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/voxfax_g711/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/local_channel_t38_queryoption/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_timeout5/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_timeout4/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_timeout3/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_timeout2/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_timeout1/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_t38_g711/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_no_t38/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_native_t38_ced/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_native_t38/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_mix4/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_mix3/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_mix2/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_mix1/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/sip/gateway_g711_t38/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fax/pjsip/gateway_native_t38/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fastagi/stream-file/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fastagi/database/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fastagi/control-stream-file/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fastagi/connect/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/fastagi/channel-status/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/dynamic-modules/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/message/message_send_ami/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_endpoint/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_incompatible_codecs/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/playback/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/echo/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/AMISendTest.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/AMISendTest.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/AMISendTest.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/AMISendTest.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/AMISendTest.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/local/local_optimize_away/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/local/local_holding_bridge/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/local/local_call/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/local/local_app/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/iax2/hangupcause/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/iax2/basic-call/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/iax2/acl_call/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/use_contact_from_200/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_srtp/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_custom_presence/resubscribe/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_custom_presence/non_digium_state_change/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_custom_presence/nominal_state_change/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_custom_presence/multiple_state_change/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_cause/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_blind_transfer/caller_with_reinvite/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_blind_transfer/caller_refer_only/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_blind_transfer/callee_with_reinvite/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_blind_transfer/callee_refer_only/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_attended_transfer_tcp/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_attended_transfer/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip2cause/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers/uac_se_below_minse/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers/basic_uac_teardown/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers/basic_uac_refresh/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/secure_bridge_media/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/realtime_sipregs/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/realtime_nosipregs/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/pcap_demo/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/path/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/noload_res_srtp/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/nat_supertest/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/message_send_ami/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/info_dtmf/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/hangupcause/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/generic_ccss/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_properties/cdr_userfield/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_properties/cdr_accountcode/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_originate_sip_congestion_log/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_manipulation/nocdr/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_before_dial/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_after_busy_forward/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_manipulation/cdr_fork_end_time/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr-tests.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cdr/batch_cdrs/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/cause_answered_elsewhere/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/callparking/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/transfer_failure/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/transfer_capabilities_bridgefeatures/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/transfer_capabilities/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/simple_bridge/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_bridgefeatures/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_blindxfer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/disconnect/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/dial_LS_options/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/connected_line_update/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/bridge_action/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/bridge_action/bridge_action.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/blonde_nominal/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/blindxfer_setup/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/blindxfer_nominal/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/automon_bridgefeatures/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/automon/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/automixmon_bridgefeatures/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/automixmon/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_threeway_nominal/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_setup/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_nominal/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/asyncagi/asyncagi_break/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/play_message/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/func_vmcount/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/authenticate_nominal/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/authenticate_extensions/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/set_penalty/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/reload_queue_members/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/queue_transfer_callee/run-test <span style="color: grey">(UNKNOWN)</span></li>
<li>/asterisk/trunk/tests/apps/queues/queue_penalty_outside_range/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/queue_one_paused_no_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/queue_no_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/queue_baseline/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/queue_all_paused_no_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/playback/nominal/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/page/page_baseline/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/mixmonitor_func/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/mixmonitor/testaudio2.raw <span style="color: grey">(UNKNOWN)</span></li>
<li>/asterisk/trunk/tests/apps/mixmonitor/testaudio1.raw <span style="color: grey">(UNKNOWN)</span></li>
<li>/asterisk/trunk/tests/apps/incomplete/sip_incomplete/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/directory/directory_operator_exit/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/directory/directory_context_operator_exit/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/directory/directory_attendant_exit/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/directed_pickup/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_unavail/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_timeout/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_unavail/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_congestion/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_busy/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_unavail/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_congestion/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_cancel/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_busy/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_no_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_hangup/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_dtmf_hangup_cancel/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_congestion/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_busy/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_answer/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/control_playback/nominal/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/confbridge/confbridge_recording/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/confbridge/confbridge_nominal/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/chanspy/chanspy_w_mixmonitor/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/test-config.yaml <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/runtests.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/logger.conf <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/voicemail.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/version.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/syncami.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/sippversion.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/sipp.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/config.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/confbridge.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/cel.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/cdr.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/buildoptions.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/astcsv.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ari.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/apptest.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ami.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ThreadTestCondition.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ThreadTestCondition.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestSuiteUtils.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestSuiteUtils.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestState.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestState.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestRunner.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestRunner.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestConfig.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestConfig.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestConditions.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestConditions.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/SipDialogTestCondition.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/SipDialogTestCondition.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/SipChannelTestCondition.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/SipChannelTestCondition.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/SimpleTestCase.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/PluggableModules.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/PluggableModules.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/LockTestCondition.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/LockTestCondition.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/FdTestCondition.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/FdTestCondition.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ChannelTestCondition.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ChannelTestCondition.py <span style="color: grey">(4509)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/CDRTestCase.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/BridgeTestCase.py <span style="color: grey">(4535)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/BridgeTestCase.py <span style="color: grey">(4509)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3096/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>