<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3072/">https://reviewboard.asterisk.org/r/3072/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3072/diff/2/?file=49798#file49798line978" style="color: black; font-weight: bold; text-decoration: underline;">/branches/12/CHANGES</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">978</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">VMCOUNT:</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">979</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> * Mailboxes defined by app_voicemail MUST be referenced by the rest of the</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For formatting consistency, add a line of '----' below VMCOUNT.</pre>
</div>
<br />
<p>- Matt Jordan</p>
<br />
<p>On December 18th, 2013, 12:51 p.m. CST, rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2013, 12:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed code from the system for normal mailbox handling that appends @default to the mailbox identifier if it does not have a context. The only exception is the legacy hasvoicemail users.conf option. The legacy option will only work for app_voicemail mailboxes. (I'd like to just remove the hasvoicemail option since it is usually superceeded by an explicit mailbox option. :) ) The system cannot make any assumptions about the format of the mailbox identifer used by app_voicemail.
chan_sip and chan_dahdi/sig_pri had the most changes because they both tried to interpret the mailbox identifier. chan_sip just stored and compared the two components. chan_dahdi actually used the box information.
The ISDN MWI support configuration options had to be reworked because chan_dahdi was parsing the box@context format to get the box number. As a result the mwi_vm_boxes chan_dahdi.conf option was added and is documented in the chan_dahdi.conf.sample file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested chan_dahdi to be sure that the new mwi_vm_boxes option parses correctly and sets up mailboxes.
Tested chan_sip to be sure that the mailbox option works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_xmpp.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/res/res_jabber.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/main/app.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/include/asterisk/app.h <span style="color: grey">(404197)</span></li>
<li>/branches/12/funcs/func_vmcount.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/configs/voicemail.conf.sample <span style="color: grey">(404197)</span></li>
<li>/branches/12/configs/skinny.conf.sample <span style="color: grey">(404197)</span></li>
<li>/branches/12/configs/sip.conf.sample <span style="color: grey">(404197)</span></li>
<li>/branches/12/configs/iax.conf.sample <span style="color: grey">(404197)</span></li>
<li>/branches/12/configs/chan_dahdi.conf.sample <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/sip/include/sip.h <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/sig_pri.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/sig_pri.h <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/h323/chan_h323.h <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_unistim.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_skinny.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_sip.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_mgcp.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_iax2.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_h323.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_dahdi.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/channels/chan_dahdi.h <span style="color: grey">(404197)</span></li>
<li>/branches/12/apps/app_voicemail.c <span style="color: grey">(404197)</span></li>
<li>/branches/12/UPGRADE.txt <span style="color: grey">(404197)</span></li>
<li>/branches/12/CHANGES <span style="color: grey">(404197)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3072/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>