<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3066/">https://reviewboard.asterisk.org/r/3066/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Heh, every time I thought I spotted something wrong, it turned out I was wrong instead :)
The only suggestion I have for this is that since RTP glue update_peer() method is now consistently called with the channel locked, I would update its documentation in rtp_engine.h to note this.</pre>
<br />
<p>- Mark Michelson</p>
<br />
<p>On December 11th, 2013, 11:20 p.m. UTC, Kevin Harwell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and kmoore.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated Dec. 11, 2013, 11:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22749">ASTERISK-22749</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This contains the patch on the issue (submitted by kmoore), as well as the fix for the adding in a bridge lock while calling bridge_start from the framehook callback. Since the framehook callback is not called from the bridging core the bridge is not locked, but needs to be before calling bridge_start. The addition to the given patch adds in the necessary bridge locking in order to avoid a deadlock.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added channels via DTMF attended transfer to get to a 4-way bridge and then removed them and noted all channels and the bridge had been torn down.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/main/channel.c <span style="color: grey">(403687)</span></li>
<li>branches/12/include/asterisk/channel.h <span style="color: grey">(403687)</span></li>
<li>branches/12/channels/chan_sip.c <span style="color: grey">(403687)</span></li>
<li>branches/12/channels/chan_pjsip.c <span style="color: grey">(403687)</span></li>
<li>branches/12/bridges/bridge_native_rtp.c <span style="color: grey">(403687)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3066/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>