<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2779/">https://reviewboard.asterisk.org/r/2779/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Mark</p>
<br />
<p>On September 4th, 2013, 1:40 p.m. UTC, jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, kmoore and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2013, 1:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22328">ASTERISK-22328</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test had been skipped due to failures for some time and also wouldn't work with 12. It turned out to be written in BASH, so I rewrote the test in Python. The functionality is pretty much the same though, just substituting originating through asterisk command line execution to using AMI to originate and also adding extra verification that the parking is taking place with the expected parameters regarding who is being parked and who is retrieving calls as well as having a certain flow of AMI events.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the test against 1.8 and 12 to check that they pass. Checked failures by supplying known bad expectations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/callparking_retrieval/userB/iax.conf <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/userB/extensions.conf <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/userA/iax.conf <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/userA/extensions.conf <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/test-config.yaml <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/run-test <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast3/res_parking.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast3/iax.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast3/features.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast3/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast2/iax.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast1/res_parking.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast1/iax.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast1/features.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/userC/extensions.conf <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/userC/features.conf <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/callparking_retrieval/userC/iax.conf <span style="color: grey">(4081)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2779/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>