<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2765/">https://reviewboard.asterisk.org/r/2765/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2013, 10:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Modified so that RTP media is sent over the local IPv4 & IPv6 address. This required modifying some of the playback_with_initial_sdp.xml SIPp scenarios to include the SDP on the INVITE with the authentication credentials along with other minor changes.
* Removed configuration that wasn't needed from pjsip.conf files.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22282">ASTERISK-22282</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds TCP and IPv6 iterations to the existing inbound call tests for pjsip.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Checked logs and packet captures to ensure that IPv6 and TCP were being used</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/configs/ast1/pjsip.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/configs/ast1/pjsip.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/sipp/unknown_destination.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/sipp/incompatible_codecs.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/incoming_calls_without_auth/configs/ast1/pjsip.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/configs/ast1/pjsip.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/configs/ast1/pjsip.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_user/configs/ast1/pjsip.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/configs/ast1/pjsip.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_user/test-config.yaml <span style="color: grey">(4102)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2765/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>