<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2660/">https://reviewboard.asterisk.org/r/2660/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 5th, 2013, 3:37 p.m. UTC, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First, thanks for IPv6-ifying chan_iax2. It's been a long time coming, and I think *every* AstriDevCon we talk about it, try to make it a priority, and it never seems to quite get done. Or even started, really. So - thanks!
Olle mentioned on the asterisk-dev mailing list (http://lists.digium.com/pipermail/asterisk-dev/2013-July/061189.html) that this does suffer from a lack of support for the happy eyeballs RFC - see http://tools.ietf.org/html/rfc6555. I didn't see the branch he was referring to in his branch index (http://svn.asterisk.org/svn/asterisk/team/oej/00INDEX/branch-directory.txt) - but I could be missing it.
So, I'm not sure how much the lack of happy eyeball support impacts this work. I would hope that the management of the dual stack would occur at a lower layer than the chan_iax driver - having each of the channel drivers attempt to manage the IPv6/IPv4 fallback would get messy very quickly. At the same time, given that chan_iax tracks a peer based on its current address, there may be some ripple effects back up into chan_iax2. I'm not sure if this would have to change given Olle's patches.
Olle - what patches are you referring to? And can that work occur at a lower layer than the channel drivers?
</pre>
</blockquote>
<p>On August 28th, 2013, 10:42 p.m. UTC, <b>Michael Young</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, it has been on my list of things I wanted to do (don't ask me why) when starting to help IPv6-ify parts of Asterisk. I started it last year before or around when 11 was released. Never could get back to debugging it and polishing it up.
I saw Olle's post and wasn't sure either which branch to look at. I was kind of waiting for someone to respond like you did here. My initial reaction was "Oh crap. I hope that it doesn't have to be done in the channel driver. That should be handled elsewhere." From a quick look, it would seem that dnsmgr.c and acl.c would need to be changed and then the channel driver would need to be updated to work with those changes. So, I personally feel it is out of the scope of this work but it is something that needs to be fixed. I believe this is an overall issue that affects other parts of Asterisk and not just this channel driver.</pre>
</blockquote>
<p>On August 29th, 2013, 6:40 a.m. UTC, <b>Olle E Johansson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Happy Eyeballs for UDP is something we still discuss in the IETF and the SIP Forum. There's no elegant solution in SIP. We might end up simply recommending TCP only for happy eyeballs-situations and different host names for IPv4/ipv6 servers. For media, ICE is the way to find a working flow.
The problem is finding a working flow if client and server is both dual stack. If one of the protocols doesn't have a working flow between the endpoints, there are long timeouts. In HTTP around 20 seconds, in SIP with default timers 32 seconds. This is not acceptable for a phone call. So we do need to consider this.
What I did in code was to handle the DNS SRV records properly, which is the simple part. It's in "pgtips". If you have an IPv4 only client, and the first priority hostnames only resolve to IPv6, you should go to next priority. (and opposite). If you have a dual stack client, you should try all IP addresses for a host name before trying next host in your list. You can end up with multiple A and AAAA records, which all should be tried.
With Happy Eyeballs the application sets up connections in parallell, with a small priority for one address family (by default IPv6, but policy can change that). The first one that succeeds is selected. As UDP is connectionless, the protocol needs to handle this, which has turned out very hard for SIP. We don't want to send TWO SIP messages, end up with multiple registrations and other weird stuff.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we can extend your "there's no elegant solution in SIP" to "there's no elegant solution in IAX". Both are using a similar approach to their handling of the transports.
It sounds like to handle this properly in chan_iax2, it'd need your pgtips work completed and merged. chan_iax2 would have to be updated to use that. I think I agree with Michael here - it definitely is something we should look at doing, and ideally the various channel drivers would all behave properly. On the other hand, Michael's work in this patch is still necessary and a good first step at getting IPv6 support in chan_iax2, and I'd hate to not get it in 12 - which is a standard release - while we work on something that affects chan_sip as well.
I think at this point it's worth getting this into Asterisk 12, barring any other technical problems a review finds.</pre>
<br />
<p>- Matt</p>
<br />
<p>On August 29th, 2013, 4:29 a.m. UTC, Michael Young wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Michael Young.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2013, 4:29 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22025">ASTERISK-22025</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the ability to bind and communicate over IPv6 addresses using chan_iax2.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully made calls using iax2 over IPv6 between two dev machines. SIP Softphone -> dev vm (iax2 ipv6) -> (iax2 ipv6) dev box -> SIP ITSP -> mobile phone</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/netsock.c <span style="color: grey">(397908)</span></li>
<li>/trunk/main/acl.c <span style="color: grey">(397908)</span></li>
<li>/trunk/include/asterisk/acl.h <span style="color: grey">(397908)</span></li>
<li>/trunk/channels/iax2/parser.c <span style="color: grey">(397908)</span></li>
<li>/trunk/channels/iax2/include/parser.h <span style="color: grey">(397908)</span></li>
<li>/trunk/channels/iax2/include/iax2.h <span style="color: grey">(397908)</span></li>
<li>/trunk/CHANGES <span style="color: grey">(397908)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(397908)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2660/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>