<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2796/">https://reviewboard.asterisk.org/r/2796/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Excellent!
As a final wrap-up to this, you should probably check the phone B SIPp scenarios being used in the non-direct media hold tests and be sure they are also include appropriate SDPs in their 200 OKs.</pre>
<br />
<p>- Mark</p>
<br />
<p>On August 28th, 2013, 4:37 p.m. UTC, jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Joshua Colp, kmoore, Matt Jordan, and Mark Michelson.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2013, 4:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-22217">https://issues.asterisk.org/jira/browse/ASTERISK-22217</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On Friday I committed a patch which addressed some bugs with holding in Asterisk 12 while using native RTP bridges and directmedia. As part of that effort, the SIP hold tests in the testsuite were split up and divided into tests which used direct media and tests which didn't use direct media. At the time, Asterisk 12 failed the tests which used direct media. This patch fixes those tests by making the test use Asterisk 12 specific sipp scenarios (which were based on the existing scenarios). The main difference between the Asterisk 12 scenarios and their older counterparts was always just the addition of more expected invites and responses to those invites on account of how directmedia is established in Asterisk 12 both during the initial setup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran modified tests against Asterisk 12.
Ran modified tests against Asterisk 11.
Repeated this process many times to make sure the results were consistent.
Tracked the invites in 12 against the code that was generating them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/sipp/phone_B_media_restrict.xml <span style="color: grey">(4089)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/sipp/phone_B_IP_restrict.xml <span style="color: grey">(4089)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/sipp/phone_B_IP_media_restrict.xml <span style="color: grey">(4089)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/sipp/phone_A_IP_restrict.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/run-test <span style="color: grey">(4089)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/sipp/inject_bypass.csv <span style="color: grey">(4089)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/sipp/phone_A.xml <span style="color: grey">(4089)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2796/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>