<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2785/">https://reviewboard.asterisk.org/r/2785/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2013, 3:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed Kinsey's findings</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22112">ASTERISK-22112</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22359">ASTERISK-22359</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are times when a configuration option should not have documentation.
1. Some options are registered with a particular object merely as a warning to users. These options aren't even really 'deprecated', they are just provided by a different configuration file.
2. Some object types - most notably some used by modules that use sorcery - are completely internal and should never be shown to the user.
3. Sorcery itself has several 'hidden' fields that should never be shown to a user.
This patch updates the configuration framework and sorcery with additional API calls that allow a module to register types as internal and options as not requiring documentation. This bypasses the XML documentation checking.
This patch also re-enables the strict XML documentation checking in trunk, as well as updates some documentation that was missing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_pjsip.c <span style="color: grey">(397523)</span></li>
<li>/trunk/res/res_pjsip/pjsip_configuration.c <span style="color: grey">(397523)</span></li>
<li>/trunk/main/sorcery.c <span style="color: grey">(397523)</span></li>
<li>/trunk/main/features_config.c <span style="color: grey">(397523)</span></li>
<li>/trunk/include/asterisk/sorcery.h <span style="color: grey">(397523)</span></li>
<li>/trunk/main/config_options.c <span style="color: grey">(397523)</span></li>
<li>/trunk/include/asterisk/config_options.h <span style="color: grey">(397523)</span></li>
<li>/trunk/res/res_pjsip/pjsip_options.c <span style="color: grey">(397523)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2785/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>