<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2761/">https://reviewboard.asterisk.org/r/2761/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- jrose</p>
<br />
<p>On August 20th, 2013, 6:55 p.m. UTC, rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2013, 6:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Added an option flags parameter to interval hooks. Interval hooks now can specify if the callback will affect the media path or not.
* Added an option flags parameter to the bridge action custom callback. The action callback now can specify if the callback will affect the media path or not.
* Made the holding bridge technology reexamine the participant idle mode option whenever the entertainment is restarted.
* Fixed app_agent_pool waiting agents needlessly starting and stopping MOH every second by specifying the heartbeat interval hook as not affecting the media path.
* Fixed app_agent_pool agent alert from restarting the MOH after the alert beep. The agent entertainment is now changed from MOH to silence after the alert beep.
* Fixed holding bridge technology to defer starting the entertainment. It was previously a mixture of immediate and deferred.
* Fixed holding bridge technology to immediately stop the entertainment. It was previously a mixture of immediate and deferred. If the channel left the bridging system, any deferred stopping was discarded before taking effect.
* Miscellaneous holding bridge technology rework coding improvements.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Waiting agents no longer start and stop MOH every second. (Tests the interval hook options flag parameter.)
* Waiting agents hear the alerting beep followed by silence again. (Tests the holding bridge reexamining the idle mode option.)
* Tested BridgeWait announcer and participant entering leaving combinations. They still work. (Tests entertainment starting and stopping.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_agent_pool.c <span style="color: grey">(397192)</span></li>
<li>/trunk/apps/app_bridgewait.c <span style="color: grey">(397192)</span></li>
<li>/trunk/bridges/bridge_builtin_interval_features.c <span style="color: grey">(397192)</span></li>
<li>/trunk/bridges/bridge_holding.c <span style="color: grey">(397192)</span></li>
<li>/trunk/include/asterisk/bridge_channel.h <span style="color: grey">(397192)</span></li>
<li>/trunk/include/asterisk/bridge_features.h <span style="color: grey">(397192)</span></li>
<li>/trunk/main/bridge.c <span style="color: grey">(397192)</span></li>
<li>/trunk/main/bridge_channel.c <span style="color: grey">(397192)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(397192)</span></li>
<li>/trunk/res/parking/parking_bridge_features.c <span style="color: grey">(397192)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2761/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>