<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2733/">https://reviewboard.asterisk.org/r/2733/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Matt</p>


<br />
<p>On August 1st, 2013, 7:43 p.m. UTC, jbigelow wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By jbigelow.</div>


<p style="color: grey;"><i>Updated Aug. 1, 2013, 7:43 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test sends registrations over IPv4/IPv6 and UDP/TCP to test the pjsip.conf configuration options minimum_expiration, maximum_expiration, and remove_existing. This covers tests 4, 5, and 6 of the nominal inbound registrations listed on the test plan page of the wiki.

Tests:
* minimum_expiration - register a contact where the Expires header and the expires parameter on the contact are lower than the value set for the minimum_expiration configuration option. This is to ensure the value of minimum_expiration is used.

* maximum_expiration - register a contact where the Expires header and the expires parameter on the contact are higher than the value set for the maximum_expiration configuration option. This is to ensure the value of maximum_expiration is used.

* remove_existing - register two contacts per AOR. Then register two different contacts for the same AORs. This ensures that with the remove_existing configuration option enabled, the first two contacts are removed and the new contacts are added.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Ensured the tests fail if:
- the Test Events aren&#39;t received or do not match. (all tests)
- the expires parameter of the contact header in the 200 OK isn&#39;t what is expected. (minimum_expiration &amp; maximum_expiration)
- the old contacts are present or the max contacts are reached. (remove_existing)
* Reviewed logs to ensure that the registrations were using all the combinations of IPv4/IPv6 and UDP/TCP. (all test)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/maximum_expiration/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/maximum_expiration/sipp/register-noauth.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/maximum_expiration/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/minimum_expiration/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/minimum_expiration/sipp/register-noauth.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/minimum_expiration/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/sipp/register-noauth-ipv4.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/sipp/register-noauth-ipv6.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(3972)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2733/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>