<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2468/">https://reviewboard.asterisk.org/r/2468/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 25th, 2013, 4:42 p.m. UTC, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2468/diff/2/?file=36382#file36382line257" style="color: black; font-weight: bold; text-decoration: underline;">team/group/pimp_my_sip/include/asterisk/res_sip.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">257</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="cm">/*! Do not offer media encryption, but accept it if offered */</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">258</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">AST_SIP_MEDIA_ENCRYPT_NONE</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't know if I like this none option. It's like optional SRTP. :P "I don't require it but if they offer it sure why not"</pre>
</blockquote>
<p>On April 25th, 2013, 6 p.m. UTC, <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the way that chan_sip currently behaves for encryption=no as I understand the code (it's entirely possible that I read it wrong). Are you saying we want to drop the behavior I've specified for "no" and replace it with the behavior I've specified for "deny"?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enabling encryption should make it required, disabling encryption should make it be rejected if offered.
This forces the user to be aware of the encryption status. If you have it "upgrade" then the encryption may or may not be present, which makes it optional and potentially useless.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On April 24th, 2013, 8:02 p.m. UTC, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated April 24, 2013, 8:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21416">ASTERISK-21416</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for SDES SRTP in chan_gulp/res_sip. Available options for media encryption for a given endpoint are deny (no encryption allowed), no (none offered by default, but silent upgrade to SDES allowed), and sdes. This also supports mid-call rekeying as far as I could test it. Much of the code necessary for this functionality was factored out of chan_sip or pulled from channels/sip/.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hand testing with several SRTP-capable endpoints and mid-call rekeying tested with minor tweaks to an otherwise unmodified chan_sip.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/group/pimp_my_sip/channels/sip/include/sip.h <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/channels/sip/include/sdp_crypto.h <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/channels/chan_sip.c <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/channels/sip/include/srtp.h <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/channels/sip/sdp_crypto.c <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/channels/sip/srtp.c <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/configs/res_sip.conf.sample <span style="color: grey">(386430)</span></li>
<li>team/group/pimp_my_sip/include/asterisk/res_sip.h <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/include/asterisk/res_sip_session.h <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/include/asterisk/sdp_srtp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>team/group/pimp_my_sip/main/sdp_srtp.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>team/group/pimp_my_sip/res/res_sip/sip_configuration.c <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/res/res_sip_sdp_rtp.c <span style="color: grey">(386429)</span></li>
<li>team/group/pimp_my_sip/res/res_sip_session.c <span style="color: grey">(386429)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2468/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>