<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/931/">https://reviewboard.asterisk.org/r/931/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry Alec, I should had made it clear when I closed this that I was just removing some old cruft. These changes were released orignally in DAHDI-Linux 2.5...
The final commit of the series that removed it was http://git.asterisk.org/gitweb/?p=dahdi/linux.git;a=commit;h=579ea560efd7a82ac34ca211571ad426fff86c0d</pre>
<br />
<p>- Shaun</p>
<br />
<p>On April 11th, 2013, 2:19 p.m. UTC, Shaun Ruffell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Tzafrir Cohen.</div>
<div>By Shaun Ruffell.</div>
<p style="color: grey;"><i>Updated April 11, 2013, 2:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
DAHDI
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review is for the 11 commits on http://github.com/sruffell/dahdi-linux/tree/chan_list (b07adb15484398f8fb37...8425d20d6e84766590ec) It completely removes the 'chans' array from dahdi-base.c, but keeps the external behavior the same, namely channels are numbered in registration order.
The point of these changes is to eventually support renumbering spans / channels on the fly as part of supporting hot pluggable spans, but this change set has the affect of reducing memory usage for small/normal installations (since arrays no longer need to be setup for spans and chans).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Again, hasn't gone through a complete regression, but I've been using it as the base for most of my work in order to ensure that there aren't any performance regressions.
With DAHDI_CHUNKSIZE == 8, the practical limit is still something under 1024 channels due to the masterspan processing overhead, but this change, in conjunction with some improvements/changes there (default CHUNKSIZE something other than 8? Reduced locking?) this could be part of a solution to allow more channels on a single system without recompiling.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>linux/trunk/drivers/dahdi/dahdi-base.c <span style="color: grey">(9390)</span></li>
<li>linux/trunk/include/dahdi/kernel.h <span style="color: grey">(9390)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/931/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>