<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2424/">https://reviewboard.asterisk.org/r/2424/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated April 6, 2013, 3:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change has three pieces:
1. Conversion of realtime to use ast_variable instead of va_arg
2. A res_sorcery_realtime module for using all of the realtime config engines with sorcery
3. Unit tests for res_sorcery_realtime
There should be no functional impact as a result of the ast_variable conversion.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran against an actual realtime config engine, postgresql, to confirm that it works as expected. Ran it against unit tests as well to confirm that the wizard works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/res_config_mysql.c <span style="color: grey">(383654)</span></li>
<li>/trunk/include/asterisk/config.h <span style="color: grey">(383654)</span></li>
<li>/trunk/main/config.c <span style="color: grey">(383654)</span></li>
<li>/trunk/main/sorcery.c <span style="color: grey">(383654)</span></li>
<li>/trunk/res/res_config_curl.c <span style="color: grey">(383654)</span></li>
<li>/trunk/res/res_config_ldap.c <span style="color: grey">(383654)</span></li>
<li>/trunk/res/res_config_odbc.c <span style="color: grey">(383654)</span></li>
<li>/trunk/res/res_config_pgsql.c <span style="color: grey">(383654)</span></li>
<li>/trunk/res/res_config_sqlite3.c <span style="color: grey">(383654)</span></li>
<li>/trunk/res/res_sorcery_realtime.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/tests/test_sorcery_realtime.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2424/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>