<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2079/">https://reviewboard.asterisk.org/r/2079/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm of the opinion that this isn't necessarily a bug and should not go into Asterisk 1.8. To me, the queue log entry just indicates the command was issued. The lack of individual queue entries afterward is a good indicator that the interface did not actually get removed from any queues.</pre>
<br />
<p>- Mark</p>
<br />
<p>On August 17th, 2012, 4:32 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Jason Parker, jbigelow, and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2012, 4:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When pause or unpause to an interface for a queue either through manager or the CLI command 'queue pause <interface>' without specifying a specific queue, Asterisk will currently write the following to the queue log:
<epoch>|NONE|NONE|<interface>|PAUSEALL
- or UNPAUSEALL in the case of unpausing.
This will happen regardless of whether the interface is actually a member of any queue.
If the interface is a member of any queue, the following events will be issued for each queue the interface is a member of:
<epoch>|NONE|<queuename>|<interface>|PAUSE
- or UNPAUSE in the case of uspausing.
This patch changes the behavior of logging the PAUSEALL/UNPAUSEALL events so that they are only written once a queue has been found for which the interface is a member. Our current concensus is that having the PAUSEALL/UNPAUSEALL events displayed when no members are actually affected is confusing and unnecessary.
NOTE:
We are currently unsure of which branches this patch should go into. The discovery was made against 1.8, but this does introduce a slight behavior change to queue logging. We'd appreciate some feedback from the community indicating if anyone feels strongly for or against including this patch in 1.8.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Issued the commands mentioned above against interfaces which were either included or not included against a number of queues. Situations included interfaces that were a member of 0, 1, and 2 queues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/apps/app_queue.c <span style="color: grey">(371481)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2079/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>