<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1717/">https://reviewboard.asterisk.org/r/1717/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 22nd, 2012, 8:43 a.m., <b>nixon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I try to compile and result are...
chan_sip.c: In function ‘register_realtime_peers_with_callbackextens’:
chan_sip.c:4996: warning: implicit declaration of function ‘sip_unref_peer’
asterisk-1.8.16.0-rc1</pre>
</blockquote>
<p>On August 22nd, 2012, 8:52 a.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nixon: This was a patch against trunk. It has even been submitted to trunk already.
If you try asterisk-11, this feature should be included already.</pre>
</blockquote>
<p>On August 22nd, 2012, 1:37 p.m., <b>nixon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Include this patch in *-1.8 branch please.</pre>
</blockquote>
<p>On August 22nd, 2012, 9:38 p.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New features or intrusive improvements are not made to released branches of Asterisk. This will not go into Asterisk 1.8. You are more then welcome to backport this feature to the 1.8 branch and maintain a patch yourself, or a team branch in subversion.</pre>
</blockquote>
<p>On August 25th, 2012, 6:03 a.m., <b>nixon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested *-11 beta1. "sip reload" not work properly for peers with "callbackextension". There are unregistered after sip reload.
More... after initial * start callbackextension's peers not registering without "sip reload". :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please stop commenting on this review.
If you have valid bugs to report on a committed feature, please report them to the issue tracker at https://issues.asterisk.org/jira.</pre>
<br />
<p>- Matt</p>
<br />
<p>On February 7th, 2012, 2:11 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and wdoekes.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2012, 2:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is a continuation of the one on https://reviewboard.asterisk.org/r/344/. If multiple peers are defined with the same host/port, but differing callbackextensions, it chooses the peer with the matching callbackextension. Since callbackextension creates an outbound registration with the callbackextension as the Contact address, matching an incoming request by that (in addition to the host/port) makes a lot of sense.
This patch also adds support for callbackextension to realtime by querying all peers with callbackextensions on reload and adding registrations for them. The patch on /r/344 didn't support matching realtime peers, but this one does.
While callbackextension certainly has its detractors, it is what we have to work with at this time and we should make it work until we have a better solution available.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I set up outbound registrations via differing callbackextensions for two peers with the same host/port. I then dialed from the Asterisk box that those peers were registered to and verified that the correct peer was matched in each case. I tried this with realtime and non-realtime configs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-13456">ASTERISK-13456</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(353913)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(353913)</span></li>
<li>/trunk/contrib/realtime/postgresql/realtime.sql <span style="color: grey">(353913)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1717/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>