<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2024/">https://reviewboard.asterisk.org/r/2024/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Mark</p>
<br />
<p>On July 12th, 2012, 5:28 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated July 12, 2012, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This converts the confbridge app to use the new ACO API. A couple of small additions were added to the ACO API to accomodate app_confbridge:
1) A default handler was added for storing options in character arrays of a given length
2) A NoOp default handler was added so that that type= fields that are used for matching a specific type can be ignored and not cause a parsing failure
3) The aco_process_var() function was added to allow processing an individual option/value and applying it to an object. app_confbridge uses this to create user/bridge profiles with the CONFBRIDGE dialplan function.
The only behavior change that I am aware of is that the announce_only_user option (which defaulted to "yes" and used ast_true() with negative logic to clear the USER_OPT_NOONLYPERSON flag) now defaults to "yes" and evaluates using ast_false(). So basically "true" used to be default or ast_true(var->value). Now it is default or !ast_false(var->value) which is more in keeping with "yes" being the default anyway.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created several users/bridges and verified that settings looked right with the CLI confbridge show profile/menu commands. Ran dialplan with some CONFBRIDGE() calls to verify that settings changed appropriately and that templates appeared to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/confbridge/conf_config_parser.c <span style="color: grey">(370043)</span></li>
<li>/trunk/apps/confbridge/include/confbridge.h <span style="color: grey">(370043)</span></li>
<li>/trunk/include/asterisk/config_options.h <span style="color: grey">(370043)</span></li>
<li>/trunk/main/config_options.c <span style="color: grey">(370043)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2024/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>