<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2032/">https://reviewboard.asterisk.org/r/2032/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 12th, 2012, 10:46 a.m., <b>Tilghman Lesher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That alloca() cannot return NULL is a Linux-ism. On FreeBSD, for example, it's perfectly possible for alloca() to return NULL. Therefore, this patch should fail on cross-platform compatibility.</pre>
</blockquote>
<p>On July 12th, 2012, 12:13 p.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If that is the case, then the other half of the code is broken ;)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, would be better to fix the code than breaking the rest of it. ;)</pre>
<br />
<p>- Tilghman</p>
<br />
<p>On July 12th, 2012, 10:26 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated July 12, 2012, 10:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">alloca and ast_strdupa shouldn't be checked for NULL.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20125">ASTERISK-20125</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/addons/res_config_mysql.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_macro.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_meetme.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_minivm.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_osplookup.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_gtalk.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_iax2.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_jingle.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_cut.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_logic.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_strings.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/file.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/http.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/pbx.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/strcompat.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/pbx/pbx_dundi.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/pbx/pbx_realtime.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/res/res_agi.c <span style="color: grey">(369969)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2032/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>