<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1954/">https://reviewboard.asterisk.org/r/1954/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other than my minor nits, this looks great.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On May 30th, 2012, 3:35 p.m., Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated May 30, 2012, 3:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is similar but not quite the same as my previous review request. The goal of this setting is to prevent reinvite glare scenarios that arise when multiple Asterisk servers are in a path where direct media will be used. The most common glare scenario arises because the two Asterisk servers immediately send direct media reinvites to each other once the initial INVITE transaction has completed.
This review request adds a new option for the directmedia setting, called "outgoing". If set, then Asterisk will only transmit an immediate direct media reinvite if the call direction is outgoing. The key word here is "immediate." Asterisk will still be able to send direct media reinvites on incoming calls, but they will only be sent in reaction to changes in the remote RTP address.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This has been tested in a scenario with two phones and two Asterisk servers. I have verified that with this set, direct media is properly set up between the two phones and I saw no glares in many calls (around 20)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(367639)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(367639)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(367639)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1954/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>