<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1852/">https://reviewboard.asterisk.org/r/1852/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2012, 12:04 p.m., <b>Tzafrir Cohen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This still has a surprising element: if I use: ./configure CFLAGS="<flags>" , I probably won't expect to get in practice CFLAGS="<flags> -march=native" (this is added later on in the Makefile directly).
Also: what happens in a cross-build? Will the test in configure.ac fail?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've taken care of the first item in the patch I'm about to upload.
Checking the GCC 4.5.3 AVR cross compiler I have on my system, it appears to reject the flag. The only cross compilers where I might worry that the result would be different are cross compilers where the targets are i386/x86_64, rs6000, mips, or alpha since these also have CPU auto-detection capabilities within GCC 4.6.3 and I don't currently have a cross-compiler I can use to test those.</pre>
<br />
<p>- opticron</p>
<br />
<p>On April 10th, 2012, 9:35 a.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated April 10, 2012, 9:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The selection of PROC as k8 for -march on 64bit systems can cause gcc to create binaries that will not run on the local machine since it will optimize to use 3Dnow! and extended 3Dnow! instructions where possible. This type of code shouldn't even really be in the Asterisk build system so I'm ripping it out in its entirety instead of changing k8 to native. There is now a menuselect option that is available when a version of gcc that supports -march=native is being used to enable or disable tailoring of generated code to the instruction sets available on the local CPU.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran this through the testsuite and it didn't break anything.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19462">ASTERISK-19462</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/1.8/Makefile <span style="color: grey">(361490)</span></li>
<li>branches/1.8/Makefile.rules <span style="color: grey">(361490)</span></li>
<li>branches/1.8/build_tools/cflags.xml <span style="color: grey">(361490)</span></li>
<li>branches/1.8/build_tools/menuselect-deps.in <span style="color: grey">(361490)</span></li>
<li>branches/1.8/codecs/gsm/Makefile <span style="color: grey">(361490)</span></li>
<li>branches/1.8/codecs/gsm/src/k6opt.s <span style="color: grey">(361490)</span></li>
<li>branches/1.8/codecs/lpc10/Makefile <span style="color: grey">(361490)</span></li>
<li>branches/1.8/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>branches/1.8/configure.ac <span style="color: grey">(361490)</span></li>
<li>branches/1.8/makeopts.in <span style="color: grey">(361490)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1852/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>