<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1822/">https://reviewboard.asterisk.org/r/1822/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 22nd, 2012, 2:55 p.m., <b>Tilghman Lesher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is another case here that MASTER_CHANNEL handles that is not tested here, and that is whether the cause is passed back across a Local channel. I don't know whether it would work or not, but it's definitely something to add to your tests.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is one of the situations I tested and is why the handling of the PVT_CAUSE_CODE control frames occur below the attempted indication in channel.c. It will be in the tests that go into the testsuite.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 22nd, 2012, 2:55 p.m., <b>Tilghman Lesher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1822/diff/1/?file=26416#file26416line4283" style="color: black; font-weight: bold; text-decoration: underline;">trunk/main/channel.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int ast_indicate_data(struct ast_channel *chan, int _condition,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4283</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">pbx_builtin_setvar_helper</span><span class="p">(</span><span class="n">chan</span><span class="p">,</span> <span class="n">causevar</span><span class="p">,</span> <span class="n">cause_code</span><span class="o">-></span><span class="n">code</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Might as well call ast_func_write directly, here.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done.</pre>
<br />
<p>- opticron</p>
<br />
<p>On March 23rd, 2012, 10 a.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add PVT_CAUSE as a drop-in replacement for SIP_CAUSE that does not incur the overhead of the MASTER_CHANNEL dialplan function. This feature uses control frames to pass the data and creates a mechanism by which any channel driver can report cause information. This implementation includes only SIP, but implementations for other channel drivers will be available in the next month.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified that this functions identically to SIP_CAUSE in single-channel dials, forked dials, and forked dials behind a local dial.
Sample dialplan:
[foo]
exten => s,1,Dial(SIP/bar)
exten => h,1,noop()
exten => h,n,set(PVT_CAUSE_STRING=${HASHKEYS(PVT_CAUSE)})
; start loop
exten => h,n(pvt_begin),noop()
; check exit condition (no more array to check)
exten => h,n,gotoif($[${LEN(${PVT_CAUSE_STRING})} = 0]?pvt_exit)
; pull the next item
exten => h,n,set(ARRAY(item)=${PVT_CAUSE_STRING})
exten => h,n,set(PVT_CAUSE_STRING=${PVT_CAUSE_STRING:${LEN(${item})}})
; display the channel ID and cause code
exten => h,n,noop(got channel ID ${item} with pvt cause ${HASH(PVT_CAUSE,${item})})
; check exit condition (no more array to check)
exten => h,n,gotoif($[${LEN(${PVT_CAUSE_STRING})} = 0]?pvt_exit)
; we still have entries to process, so strip the leading comma
exten => h,n,set(PVT_CAUSE_STRING=${PVT_CAUSE_STRING:1})
; go back to the beginning of the loop
exten => h,n,goto(pvt_begin)
exten => h,n(pvt_exit),noop(All PVT_CAUSE entries processed)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-4221">SWP-4221</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/funcs/func_frame_trace.c <span style="color: grey">(360259)</span></li>
<li>trunk/include/asterisk/frame.h <span style="color: grey">(360259)</span></li>
<li>trunk/main/channel.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/dial.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/features.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/file.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/rtp_engine.c <span style="color: grey">(360259)</span></li>
<li>trunk/CHANGES <span style="color: grey">(360259)</span></li>
<li>trunk/UPGRADE.txt <span style="color: grey">(360259)</span></li>
<li>trunk/apps/app_dial.c <span style="color: grey">(360259)</span></li>
<li>trunk/apps/app_followme.c <span style="color: grey">(360259)</span></li>
<li>trunk/apps/app_queue.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_sip.c <span style="color: grey">(360259)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1822/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>